audrius/contract
1
0
Fork 1
mirror of https://github.com/OCA/contract.git synced 2025-02-13 17:57:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] Skip revising lines that are not valid anymore

Browse Source
This commit is contained in:
Andrea
2020-02-14 16:57:54 +01:00
parent 5ec8837097
commit db5c3d6472
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
contract_price_revision/wizards/create_revision_line.py
View File

@@ -25,10 +25,9 @@ class CreateRevisionLineWizard(models.TransientModel):
contract_obj = self.env['account.analytic.account'] contract_obj = self.env['account.analytic.account']
line_obj = self.env['account.analytic.invoice.line'] line_obj = self.env['account.analytic.invoice.line']
active_ids = self.env.context['active_ids'] active_ids = self.env.context['active_ids']
contracts = contract_obj.browse(active_ids)
line_news = line_obj line_news = line_obj
for item in contract_obj.browse(active_ids).mapped( for item in self._get_contract_lines_to_revise(contracts):
'recurring_invoice_line_ids').filtered(
lambda x: not x.automatic_price):
line_news |= item.copy({ line_news |= item.copy({
'date_start': self.date_start, 'date_start': self.date_start,
'date_end': self.date_end, 'date_end': self.date_end,
@@ -48,3 +47,14 @@ class CreateRevisionLineWizard(models.TransientModel):
'form')] 'form')]
action['res_id'] = active_ids[0] action['res_id'] = active_ids[0]
return action return action
def _get_contract_lines_to_revise(self, contracts):
self.ensure_one()
to_revise = (
contracts.mapped("recurring_invoice_line_ids")
.filtered(
lambda x: not x.automatic_price
and (not x.date_end or x.date_end >= self.date_start)
)
)
return to_revise