[FIX] contract: Don't execute onchange after invoice creation + Tests with duplicated name

- Don't execute onchange after invoice creation
  Using that approach (that is the current one in core)  has a lot of side effects and
  performance bottlenecks. You can read odoo/odoo#40156 for summarizing them.
  This also improves the handling of the values of payment term an fiscal position
  for using the partner ones if not set.
- Tests with duplicated name
  So they are not executed at all. Detected by chance looking for a test for the other PR.
This commit is contained in:
Pedro M. Baeza
2019-12-02 13:25:07 +01:00
committed by Christopher Rogos
parent ab32fa5f30
commit 912480c68d
71 changed files with 86 additions and 85 deletions

View File

@@ -631,7 +631,7 @@ class TestContract(TestContractBase):
self.acct_line.write({'date_end': False, 'is_auto_renew': False})
self.assertFalse(self.contract.date_end)
def test_stop_contract_line(self):
def test_cancel_contract_line(self):
"""It should raise a validation error"""
self.acct_line.cancel()
with self.assertRaises(ValidationError):
@@ -1808,7 +1808,7 @@ class TestContract(TestContractBase):
self.contract._compute_invoice_count()
self.assertEqual(self.contract.invoice_count, 3)
def test_contract_count_invoice(self):
def test_contract_count_invoice_2(self):
invoices = self.env['account.invoice']
invoices |= self.contract.recurring_create_invoice()
invoices |= self.contract.recurring_create_invoice()