From 7e5917b270a75bc75898a017216e4435ba4a6ec2 Mon Sep 17 00:00:00 2001
From: Juanjo <juanjose.segui@tecnativa.com>
Date: Thu, 25 Jul 2024 15:46:22 +0200
Subject: [PATCH] [MIG] contract_price_revision: Migration to 17.0

---
 contract_price_revision/README.rst                     |  1 +
 contract_price_revision/__manifest__.py                |  2 +-
 contract_price_revision/models/contract_line.py        |  2 +-
 contract_price_revision/readme/CONTRIBUTORS.md         |  1 +
 contract_price_revision/static/description/index.html  |  1 +
 .../tests/test_contract_price_revision.py              |  6 ++++++
 contract_price_revision/views/contract_line.xml        |  2 +-
 .../wizards/contract_price_revision_views.xml          | 10 ++--------
 8 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/contract_price_revision/README.rst b/contract_price_revision/README.rst
index 36373a287..60b017de7 100644
--- a/contract_price_revision/README.rst
+++ b/contract_price_revision/README.rst
@@ -83,6 +83,7 @@ Contributors
    -  Vicent Cubells
    -  Carlos Dauden
    -  Carolina Fernandez
+   -  Juan José Seguí
 
 Maintainers
 -----------
diff --git a/contract_price_revision/__manifest__.py b/contract_price_revision/__manifest__.py
index 85e3ce33e..879aaccaa 100644
--- a/contract_price_revision/__manifest__.py
+++ b/contract_price_revision/__manifest__.py
@@ -6,7 +6,7 @@
 {
     "name": "Contract Price Revision",
     "summary": "Easy revision of contract prices",
-    "version": "15.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Contract",
     "author": "ACSONE SA/NV, Tecnativa, Odoo Community Association (OCA)",
     "license": "AGPL-3",
diff --git a/contract_price_revision/models/contract_line.py b/contract_price_revision/models/contract_line.py
index 54d566c58..d694a29a7 100644
--- a/contract_price_revision/models/contract_line.py
+++ b/contract_price_revision/models/contract_line.py
@@ -30,7 +30,7 @@ class ContractLine(models.Model):
 
     @api.depends_context("date_start")
     def _compute_price_can_be_revised(self):
-        date_start = self.env.context.get("date_start", fields.Date.today())
+        date_start = self.env.context.get("date_start", fields.Date.context_today(self))
         lines_can_be_revised = self.filtered(
             lambda line: not line.never_revise_price
             and not line.automatic_price
diff --git a/contract_price_revision/readme/CONTRIBUTORS.md b/contract_price_revision/readme/CONTRIBUTORS.md
index f3cfddabb..aab8f5460 100644
--- a/contract_price_revision/readme/CONTRIBUTORS.md
+++ b/contract_price_revision/readme/CONTRIBUTORS.md
@@ -2,3 +2,4 @@
   - Vicent Cubells
   - Carlos Dauden
   - Carolina Fernandez
+  - Juan José Seguí
diff --git a/contract_price_revision/static/description/index.html b/contract_price_revision/static/description/index.html
index 2bd91eb17..73d118ad6 100644
--- a/contract_price_revision/static/description/index.html
+++ b/contract_price_revision/static/description/index.html
@@ -429,6 +429,7 @@ If you spotted it first, help us to smash it by providing a detailed and welcome
 <li>Vicent Cubells</li>
 <li>Carlos Dauden</li>
 <li>Carolina Fernandez</li>
+<li>Juan José Seguí</li>
 </ul>
 </li>
 </ul>
diff --git a/contract_price_revision/tests/test_contract_price_revision.py b/contract_price_revision/tests/test_contract_price_revision.py
index fb4104fdb..106f41b04 100644
--- a/contract_price_revision/tests/test_contract_price_revision.py
+++ b/contract_price_revision/tests/test_contract_price_revision.py
@@ -82,3 +82,9 @@ class TestContractPriceRevision(TestContractBase):
         self.assertEqual(len(lines), 2)
         lines = lines.filtered(lambda x: x.price_unit == 200.0)
         self.assertEqual(len(lines), 1)
+
+    def test_compute_variation_percent(self):
+        self.acct_line.write({"price_unit": 200.0, "previous_price": 100.0})
+        self.assertEqual(self.acct_line.variation_percent, 100.0)
+        self.acct_line.write({"price_unit": 200.0, "previous_price": 0.0})
+        self.assertEqual(self.acct_line.variation_percent, 0.0)
diff --git a/contract_price_revision/views/contract_line.xml b/contract_price_revision/views/contract_line.xml
index 05a816c22..1d767d3f5 100644
--- a/contract_price_revision/views/contract_line.xml
+++ b/contract_price_revision/views/contract_line.xml
@@ -19,7 +19,7 @@
                 <field
                     name="variation_percent"
                     groups="base.group_no_one"
-                    attrs="{'invisible': [('predecessor_contract_line_id', '=', False)]}"
+                    invisible="not predecessor_contract_line_id"
                 />
             </field>
         </field>
diff --git a/contract_price_revision/wizards/contract_price_revision_views.xml b/contract_price_revision/wizards/contract_price_revision_views.xml
index 2c109be10..a7e9705f7 100644
--- a/contract_price_revision/wizards/contract_price_revision_views.xml
+++ b/contract_price_revision/wizards/contract_price_revision_views.xml
@@ -18,16 +18,10 @@
                         <field name="date_end" />
                         <field name="variation_type" />
                     </group>
-                    <group
-                        name="percentage"
-                        attrs="{'invisible': [('variation_type', '!=', 'percentage')]}"
-                    >
+                    <group name="percentage" invisible="variation_type != 'percentage'">
                         <field name="variation_percent" />
                     </group>
-                    <group
-                        name="fixed"
-                        attrs="{'invisible': [('variation_type', '!=', 'fixed')]}"
-                    >
+                    <group name="fixed" invisible="variation_type != 'fixed'">
                         <field name="fixed_price" />
                     </group>
                 </group>