audrius/contract
1
0
Fork 1
mirror of https://github.com/OCA/contract.git synced 2025-02-13 17:57:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] product_contract: use _compute_display_name. Moved it to contract module.

Browse Source
This commit is contained in:
Ilyas
2023-03-21 15:57:07 +01:00
parent b793cf6356
commit 72c7743293
2 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contract/models/contract_line.py
View File

@@ -112,6 +112,10 @@ class ContractLine(models.Model):
default=True, default=True,
) )
def _compute_display_name(self):
for rec in self:
rec.display_name = "%s - %s" % (rec.date_start, rec.name)
@api.depends( @api.depends(
"last_date_invoiced", "date_start", "date_end", "contract_id.last_date_invoiced" "last_date_invoiced", "date_start", "date_end", "contract_id.last_date_invoiced"
) )

9
product_contract/models/contract_line.py
View File

@@ -16,7 +16,6 @@ class ContractLine(models.Model):
required=False, required=False,
copy=False, copy=False,
) )
display_name = fields.Char(compute="_compute_display_name_2")
def _prepare_invoice_line(self, move_form): def _prepare_invoice_line(self, move_form):
res = super(ContractLine, self)._prepare_invoice_line(move_form) res = super(ContractLine, self)._prepare_invoice_line(move_form)
@@ -48,11 +47,3 @@ class ContractLine(models.Model):
rec.termination_notice_rule_type = ( rec.termination_notice_rule_type = (
rec.product_id.termination_notice_rule_type rec.product_id.termination_notice_rule_type
) )
@api.depends("name", "date_start")
def _compute_display_name_2(self):
# FIXME: _compute_display_name depends on rec_name (display_name)
# and this trigger a WARNING : display_name depends on itself;
# please fix its decorator
for rec in self:
rec.display_name = ("%s - %s") % (rec.date_start, rec.name)