From 6977906e13699ccbb05aec6cc7ea0725ba83b59e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Bidoul=20=28ACSONE=29?=
 <stephane.bidoul@acsone.eu>
Date: Sun, 8 Dec 2019 12:31:04 +0100
Subject: [PATCH] [IMP] contract: support pre-paid for monthlylastday

monthlylastday is (almost) not a special case anymore \o/.
montlylastday is simply a montly period where the
periods are aligned on month boundaries.
The last bit of special casing is that postpaid generates
invoice the day after the last dasy of the period, except
for monthlylastday where the invoice is generated on the
last day of the period. This last exception will disappear
when we put the offset under user control.

This is a breaking change because the post-paid/pre-paid
mode becomes relevant for monthlylastday invoicing.
The field becomes visible in the UI. Code that generate
monthlylastday contract lines must now correctly set
the pre-paid/post-paid mode too. Some tests have had
to be adapted to reflect that.
---
 product_contract/tests/test_sale_order.py   | 1 +
 product_contract/views/product_template.xml | 3 +--
 product_contract/views/sale_order.xml       | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/product_contract/tests/test_sale_order.py b/product_contract/tests/test_sale_order.py
index 7a630cbbd..307cf9084 100644
--- a/product_contract/tests/test_sale_order.py
+++ b/product_contract/tests/test_sale_order.py
@@ -43,6 +43,7 @@ class TestSaleOrder(TransactionCase):
                 'is_contract': True,
                 'default_qty': 12,
                 'recurring_rule_type': "monthlylastday",
+                'recurring_invoicing_type': "post-paid",
                 'contract_template_id': self.contract_template1.id,
             }
         )
diff --git a/product_contract/views/product_template.xml b/product_contract/views/product_template.xml
index 400afa990..057ec95bc 100644
--- a/product_contract/views/product_template.xml
+++ b/product_contract/views/product_template.xml
@@ -33,8 +33,7 @@
                         </group>
                         <group>
                             <field name="default_qty"/>
-                            <field name="recurring_invoicing_type"
-                            attrs="{'invisible': [('recurring_rule_type', '=', 'monthlylastday')]}"/>
+                            <field name="recurring_invoicing_type"/>
                         </group>
                     </group>
                     <group>
diff --git a/product_contract/views/sale_order.xml b/product_contract/views/sale_order.xml
index e5da25feb..4fd1b90b9 100644
--- a/product_contract/views/sale_order.xml
+++ b/product_contract/views/sale_order.xml
@@ -58,8 +58,7 @@
                     <field name="recurring_rule_type"/>
                 </group>
                 <group attrs="{'invisible': [('is_contract', '=', False)]}">
-                    <field name="recurring_invoicing_type"
-                           attrs="{'invisible': [('recurring_rule_type', '=', 'monthlylastday')]}"/>
+                    <field name="recurring_invoicing_type"/>
                 </group>
                 <group attrs="{'invisible': [('is_contract', '=', False)]}">
                     <field name="date_start"