Apply suggestions from code review

Co-Authored-By: Bhavesh Odedra <bodedra@opensourceintegrators.com>

agreement_maintenance/i18n/agreement_maintenance.pot

@@ -25,18 +25,30 @@ msgstr ""
 
 #. module: agreement_maintenance
 #: model:ir.model,name:agreement_maintenance.model_agreement
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__agreement_id
 #: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__agreement_id
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_equipment_filter_agreement
 msgid "Agreement"
 msgstr ""
 
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_agreement_serviceprofile
+msgid "Agreement Service Profiles"
+msgstr ""
+
 #. module: agreement_maintenance
 #: model_terms:ir.actions.act_window,help:agreement_maintenance.action_maintenance_request_agreement_specific
 msgid "Create Maintenance Requests"
 msgstr ""
 
 #. module: agreement_maintenance
-#: model:ir.actions.act_window,name:agreement_maintenance.action_maintenance_request_agreement_specific
+#: model:ir.model.fields,field_description:agreement_maintenance.field_agreement_serviceprofile__equipment_id
-msgid "Maaintenance Requests"
+msgid "Equipment"
+msgstr ""
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_maintenance_equipment
+msgid "Maintenance Equipment"
 msgstr ""
 
 #. module: agreement_maintenance
@@ -44,9 +56,24 @@ msgstr ""
 msgid "Maintenance Request"
 msgstr ""
 
+#. module: agreement_maintenance
+#: model:ir.actions.act_window,name:agreement_maintenance.action_maintenance_request_agreement_specific
+msgid "Maintenance Requests"
+msgstr ""
+
 #. module: agreement_maintenance
 #: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__serviceprofile_id
 #: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_request_filter_agreement
 msgid "Service Profile"
 msgstr ""
 
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__serviceprofile_ids
+msgid "Service Profiles"
+msgstr ""
+
+#. module: agreement_maintenance
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.maintenance_equipment_form_view_agreement
+msgid "Services"
+msgstr ""
+

agreement_maintenance/i18n/de.po

@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 11.0\n"
 "Report-Msgid-Bugs-To: \n"
-"PO-Revision-Date: 2019-06-28 13:42+0000\n"
+"PO-Revision-Date: 2019-10-09 13:36+0000\n"
 "Last-Translator: Maria Sparenberg <maria.sparenberg@gmx.net>\n"
 "Language-Team: none\n"
 "Language: de\n"
@@ -14,7 +14,7 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
 "Plural-Forms: nplurals=2; plural=n != 1;\n"
-"X-Generator: Weblate 3.6.1\n"
+"X-Generator: Weblate 3.8\n"
 
 #. module: agreement_maintenance
 #: model:ir.model.fields,field_description:agreement_maintenance.field_agreement__mr_count
@@ -28,30 +28,57 @@ msgstr "<span class=\"o_stat_text\">Wartungsanfragen</span>"
 
 #. module: agreement_maintenance
 #: model:ir.model,name:agreement_maintenance.model_agreement
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__agreement_id
 #: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__agreement_id
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_equipment_filter_agreement
 msgid "Agreement"
 msgstr "Vereinbarung"
 
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_agreement_serviceprofile
+msgid "Agreement Service Profiles"
+msgstr "Vereinbarungsserviceprofil"
+
 #. module: agreement_maintenance
 #: model_terms:ir.actions.act_window,help:agreement_maintenance.action_maintenance_request_agreement_specific
 msgid "Create Maintenance Requests"
 msgstr "Wartungsanfrage erzeugen"
 
 #. module: agreement_maintenance
-#: model:ir.actions.act_window,name:agreement_maintenance.action_maintenance_request_agreement_specific
+#: model:ir.model.fields,field_description:agreement_maintenance.field_agreement_serviceprofile__equipment_id
-msgid "Maaintenance Requests"
+msgid "Equipment"
-msgstr "Wartungsanfragen"
+msgstr "Equipment"
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_maintenance_equipment
+msgid "Maintenance Equipment"
+msgstr "Wartungsequipment"
 
 #. module: agreement_maintenance
 #: model:ir.model,name:agreement_maintenance.model_maintenance_request
 msgid "Maintenance Request"
 msgstr "Wartungsanfrage"
 
+#. module: agreement_maintenance
+#: model:ir.actions.act_window,name:agreement_maintenance.action_maintenance_request_agreement_specific
+msgid "Maintenance Requests"
+msgstr "Wartungsanfragen"
+
 #. module: agreement_maintenance
 #: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__serviceprofile_id
 #: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_request_filter_agreement
 msgid "Service Profile"
 msgstr "Dienstleistungsprofil"
 
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__serviceprofile_ids
+msgid "Service Profiles"
+msgstr "Serviceprofile"
+
+#. module: agreement_maintenance
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.maintenance_equipment_form_view_agreement
+msgid "Services"
+msgstr "Dienste"
+
 #~ msgid "agreement"
 #~ msgstr "Vereinbarung"

agreement_maintenance/i18n/zh_CN.po

@@ -0,0 +1,81 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+#	* agreement_maintenance
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"
+"Report-Msgid-Bugs-To: \n"
+"PO-Revision-Date: 2019-09-04 18:23+0000\n"
+"Last-Translator: 黎伟杰 <674416404@qq.com>\n"
+"Language-Team: none\n"
+"Language: zh_CN\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: nplurals=1; plural=0;\n"
+"X-Generator: Weblate 3.8\n"
+
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_agreement__mr_count
+msgid "# Maintenance Requests"
+msgstr "# 维护请求"
+
+#. module: agreement_maintenance
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.partner_agreement_form_view
+msgid "<span class=\"o_stat_text\">Maintenance Requests</span>"
+msgstr "<span class=\"o_stat_text\">维护请求</span>"
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_agreement
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__agreement_id
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__agreement_id
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_equipment_filter_agreement
+msgid "Agreement"
+msgstr "协议"
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_agreement_serviceprofile
+msgid "Agreement Service Profiles"
+msgstr "协议服务配置文件"
+
+#. module: agreement_maintenance
+#: model_terms:ir.actions.act_window,help:agreement_maintenance.action_maintenance_request_agreement_specific
+msgid "Create Maintenance Requests"
+msgstr "创建维护请求"
+
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_agreement_serviceprofile__equipment_id
+msgid "Equipment"
+msgstr "设备"
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_maintenance_equipment
+msgid "Maintenance Equipment"
+msgstr "维护设备"
+
+#. module: agreement_maintenance
+#: model:ir.model,name:agreement_maintenance.model_maintenance_request
+msgid "Maintenance Request"
+msgstr "维护申请"
+
+#. module: agreement_maintenance
+#: model:ir.actions.act_window,name:agreement_maintenance.action_maintenance_request_agreement_specific
+msgid "Maintenance Requests"
+msgstr "维护请求"
+
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_request__serviceprofile_id
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.view_maintenance_request_filter_agreement
+msgid "Service Profile"
+msgstr "服务资料"
+
+#. module: agreement_maintenance
+#: model:ir.model.fields,field_description:agreement_maintenance.field_maintenance_equipment__serviceprofile_ids
+msgid "Service Profiles"
+msgstr "服务资料"
+
+#. module: agreement_maintenance
+#: model_terms:ir.ui.view,arch_db:agreement_maintenance.maintenance_equipment_form_view_agreement
+msgid "Services"
+msgstr "服务"

agreement_maintenance/views/maintenance_equipment_view.xml

@@ -15,8 +15,7 @@
             <xpath expr="//notebook" position="inside">
                 <page string="Services" id="services">
                     <field name="serviceprofile_ids"
-                           domain="[('active', '=', True),
+                           domain="[('equipment_id', '=', False)]"
-                                    ('equipment_id', '=', False)]"
                            widget="many2many">
                         <tree>
                             <field name="name"/>