audrius/contract
1
0
Fork 1
mirror of https://github.com/OCA/contract.git synced 2025-02-13 17:57:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] contract: remove redundant method

Browse Source 
I have detected a method that was created as redundant and with the same
technique used when preparing the line values, so better to have
everything together in the same method instead of having it spread.
This commit is contained in:
Pedro M. Baeza
2020-01-08 17:18:28 +01:00
committed by Francisco Ivan Anton Prieto
parent d58d313846
commit 39becb9dc9
2 changed files with 21 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
contract/models/contract_line.py
View File

@@ -644,7 +644,7 @@ class ContractLine(models.Model):
)
@api.multi
def _prepare_invoice_line(self, invoice_id=False):
def _prepare_invoice_line(self, invoice_id=False, invoice_values=False):
self.ensure_one()
dates = self._get_period_to_invoice(
self.last_date_invoiced, self.recurring_next_date
@@ -661,6 +661,11 @@ class ContractLine(models.Model):
invoice_line = self.env['account.invoice.line'].with_context(
force_company=self.contract_id.company_id.id,
).new(invoice_line_vals)
if invoice_values and not invoice_id:
invoice = self.env['account.invoice'].with_context(
force_company=self.contract_id.company_id.id,
).new(invoice_values)
invoice_line.invoice_id = invoice
# Get other invoice line values from product onchange
invoice_line._onchange_product_id()
invoice_line_vals = invoice_line._convert_to_write(invoice_line._cache)