[IMP] agreement: black, isort, prettier

agreement/__manifest__.py

@@ -2,27 +2,24 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 {
-    'name': 'Agreement',
-    'summary': "Adds an agreement object",
-    'version': '12.0.1.2.0',
-    'category': 'Contract',
-    'author': 'Akretion, '
-              'Yves Goldberg (Ygol Internetwork), '
-              'Odoo Community Association (OCA)',
-    'website': 'https://github.com/oca/contract',
-    'license': 'AGPL-3',
-    'depends': ['mail'],
-    'data': [
-        'security/ir.model.access.csv',
-        'security/agreement_security.xml',
-        'views/agreement.xml',
-        'views/agreement_type.xml',
+    "name": "Agreement",
+    "summary": "Adds an agreement object",
+    "version": "12.0.1.2.0",
+    "category": "Contract",
+    "author": "Akretion, "
+    "Yves Goldberg (Ygol Internetwork), "
+    "Odoo Community Association (OCA)",
+    "website": "https://github.com/oca/contract",
+    "license": "AGPL-3",
+    "depends": ["mail"],
+    "data": [
+        "security/ir.model.access.csv",
+        "security/agreement_security.xml",
+        "views/agreement.xml",
+        "views/agreement_type.xml",
     ],
-    'demo': ['demo/demo.xml'],
-    'development_status': 'Beta',
-    'maintainers': [
-        'ygol',
-        'alexis-via',
-    ],
-    'installable': True,
+    "demo": ["demo/demo.xml"],
+    "development_status": "Beta",
+    "maintainers": ["ygol", "alexis-via",],
+    "installable": True,
 }

agreement/demo/demo.xml

@@ -1,63 +1,53 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!--
   © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
   License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
-
 <odoo noupdate="1">
-
-
-<record id="market1" model="agreement">
+    <record id="market1" model="agreement">
         <field name="code">C2C-IT0042</field>
         <field name="name">Hardware IT</field>
-    <field name="partner_id" ref="base.res_partner_12"/>
+        <field name="partner_id" ref="base.res_partner_12" />
         <field name="signature_date">2017-09-10</field>
         <field name="start_date">2017-09-10</field>
         <field name="end_date">2018-09-10</field>
-</record>
-
-<record id="market2" model="agreement">
+    </record>
+    <record id="market2" model="agreement">
         <field name="code">C2C-IT0043</field>
         <field name="name">Fiber access office Lausanne</field>
-    <field name="partner_id" ref="base.res_partner_12"/>
-    <field name="signature_date" eval="time.strftime('%Y-01-01')"/>
-    <field name="start_date" eval="time.strftime('%Y-01-01')"/>
-    <field name="end_date" eval="time.strftime('%Y-01-01')"/>
-</record>
-
-<record id="market3" model="agreement">
+        <field name="partner_id" ref="base.res_partner_12" />
+        <field name="signature_date" eval="time.strftime('%Y-01-01')" />
+        <field name="start_date" eval="time.strftime('%Y-01-01')" />
+        <field name="end_date" eval="time.strftime('%Y-01-01')" />
+    </record>
+    <record id="market3" model="agreement">
         <field name="code">AGR-VETO001</field>
         <field name="name">Vétérinaire</field>
-    <field name="partner_id" ref="base.res_partner_2"/>
+        <field name="partner_id" ref="base.res_partner_2" />
         <field name="signature_date">2017-08-01</field>
         <field name="start_date">2017-08-01</field>
         <field name="end_date">2018-08-01</field>
-</record>
-
-<record id="market4" model="agreement">
+    </record>
+    <record id="market4" model="agreement">
         <field name="code">AGR-TEL001</field>
         <field name="name">Wazo IPBX deployment and maintenance</field>
-    <field name="partner_id" ref="base.res_partner_2"/>
+        <field name="partner_id" ref="base.res_partner_2" />
         <field name="signature_date">2017-05-05</field>
         <field name="start_date">2017-05-05</field>
         <field name="end_date">2018-09-10</field>
-</record>
-
-<record id="market5" model="agreement">
+    </record>
+    <record id="market5" model="agreement">
         <field name="code">BUY-VOIP012</field>
         <field name="name">SIP Phones supply</field>
-    <field name="partner_id" ref="base.res_partner_1"/>
-    <field name="signature_date" eval="time.strftime('%Y-01-01')"/>
-    <field name="start_date" eval="time.strftime('%Y-01-01')"/>
-    <field name="end_date" eval="time.strftime('%Y-01-01')"/>
-</record>
-
-<record id="market6" model="agreement">
+        <field name="partner_id" ref="base.res_partner_1" />
+        <field name="signature_date" eval="time.strftime('%Y-01-01')" />
+        <field name="start_date" eval="time.strftime('%Y-01-01')" />
+        <field name="end_date" eval="time.strftime('%Y-01-01')" />
+    </record>
+    <record id="market6" model="agreement">
         <field name="code">BUY-VOIP013</field>
         <field name="name">SIP-ISDN gateways</field>
-    <field name="partner_id" ref="base.res_partner_3"/>
+        <field name="partner_id" ref="base.res_partner_3" />
         <field name="signature_date">2017-09-02</field>
-</record>
-
-
+    </record>
 </odoo>

agreement/models/agreement.py

@@ -2,50 +2,57 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 
-from odoo import _, api, models, fields
+from odoo import _, api, fields, models
 
 
 class Agreement(models.Model):
-    _name = 'agreement'
-    _description = 'Agreement'
+    _name = "agreement"
+    _description = "Agreement"
     _inherit = ["mail.thread", "mail.activity.mixin"]
 
-    code = fields.Char(required=True, track_visibility='onchange')
-    name = fields.Char(required=True, track_visibility='onchange')
+    code = fields.Char(required=True, track_visibility="onchange")
+    name = fields.Char(required=True, track_visibility="onchange")
     partner_id = fields.Many2one(
-        'res.partner', string='Partner', ondelete='restrict',
-        domain=[('parent_id', '=', False)], track_visibility='onchange')
+        "res.partner",
+        string="Partner",
+        ondelete="restrict",
+        domain=[("parent_id", "=", False)],
+        track_visibility="onchange",
+    )
     company_id = fields.Many2one(
-        'res.company', string='Company',
-        default=lambda self: self.env['res.company']._company_default_get())
+        "res.company",
+        string="Company",
+        default=lambda self: self.env["res.company"]._company_default_get(),
+    )
     is_template = fields.Boolean(
         string="Is a Template?",
         default=False,
         copy=False,
         help="Set if the agreement is a template. "
-        "Template agreements don't require a partner."
+        "Template agreements don't require a partner.",
     )
     agreement_type_id = fields.Many2one(
-        'agreement.type',
-        string="Agreement Type",
-        help="Select the type of agreement",
+        "agreement.type", string="Agreement Type", help="Select the type of agreement",
     )
     domain = fields.Selection(
-        '_domain_selection', string='Domain', default='sale',
-        track_visibility='onchange')
+        "_domain_selection",
+        string="Domain",
+        default="sale",
+        track_visibility="onchange",
+    )
     active = fields.Boolean(default=True)
-    signature_date = fields.Date(track_visibility='onchange')
-    start_date = fields.Date(track_visibility='onchange')
-    end_date = fields.Date(track_visibility='onchange')
+    signature_date = fields.Date(track_visibility="onchange")
+    start_date = fields.Date(track_visibility="onchange")
+    end_date = fields.Date(track_visibility="onchange")
 
     @api.model
     def _domain_selection(self):
         return [
-            ('sale', _('Sale')),
-            ('purchase', _('Purchase')),
+            ("sale", _("Sale")),
+            ("purchase", _("Purchase")),
         ]
 
-    @api.onchange('agreement_type_id')
+    @api.onchange("agreement_type_id")
     def agreement_type_change(self):
         if self.agreement_type_id and self.agreement_type_id.domain:
             self.domain = self.agreement_type_id.domain
@@ -55,21 +62,23 @@ class Agreement(models.Model):
         for agr in self:
             name = agr.name
             if agr.code:
-                name = '[%s] %s' % (agr.code, agr.name)
+                name = "[{}] {}".format(agr.code, agr.name)
             res.append((agr.id, name))
         return res
 
-    _sql_constraints = [(
-        'code_partner_company_unique',
-        'unique(code, partner_id, company_id)',
-        'This agreement code already exists for this partner!'
-        )]
+    _sql_constraints = [
+        (
+            "code_partner_company_unique",
+            "unique(code, partner_id, company_id)",
+            "This agreement code already exists for this partner!",
+        )
+    ]
 
-    @api.returns('self', lambda value: value.id)
+    @api.returns("self", lambda value: value.id)
     def copy(self, default=None):
         """Always assign a value for code because is required"""
         default = dict(default or {})
-        if default.get('code', False):
+        if default.get("code", False):
             return super().copy(default)
-        default.setdefault('code', _("%s (copy)") % (self.code))
+        default.setdefault("code", _("%s (copy)") % (self.code))
         return super().copy(default)

agreement/models/agreement_type.py

@@ -10,9 +10,8 @@ class AgreementType(models.Model):
 
     name = fields.Char(string="Name", required=True)
     active = fields.Boolean(default=True)
-    domain = fields.Selection(
-        '_domain_selection', string='Domain', default='sale')
+    domain = fields.Selection("_domain_selection", string="Domain", default="sale")
 
     @api.model
     def _domain_selection(self):
-        return self.env['agreement']._domain_selection()
+        return self.env["agreement"]._domain_selection()

agreement/security/agreement_security.xml

@@ -1,26 +1,22 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!--
   © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
   License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
-
 <odoo noupdate="1">
-
-
-<record id="agreement_rule" model="ir.rule">
+    <record id="agreement_rule" model="ir.rule">
         <field name="name">Agreement multi-company</field>
-    <field name="model_id" ref="model_agreement"/>
-    <field name="domain_force">['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>
-</record>
-
-<record id="group_use_agreement_type" model="res.groups">
+        <field name="model_id" ref="model_agreement" />
+        <field
+            name="domain_force"
+        >['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>
+    </record>
+    <record id="group_use_agreement_type" model="res.groups">
         <field name="name">Use agreement type</field>
-    <field name="category_id" ref="base.module_category_hidden"/>
-</record>
-
-<record id="group_use_agreement_template" model="res.groups">
+        <field name="category_id" ref="base.module_category_hidden" />
+    </record>
+    <record id="group_use_agreement_template" model="res.groups">
         <field name="name">Use agreement template</field>
-    <field name="category_id" ref="base.module_category_hidden"/>
-</record>
-
+        <field name="category_id" ref="base.module_category_hidden" />
+    </record>
 </odoo>

agreement/views/agreement.xml

@@ -1,120 +1,159 @@
-<?xml version="1.0"?>
+<?xml version="1.0" ?>
 <!--
   © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
   License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 -->
-
 <odoo>
-
-
-<record id="agreement_form" model="ir.ui.view">
+    <record id="agreement_form" model="ir.ui.view">
         <field name="name">agreement.form</field>
         <field name="model">agreement</field>
         <field name="arch" type="xml">
             <form string="Agreement">
                 <sheet>
                     <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                        class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                            options='{"terminology": "archive"}'/>
+                        <button
+                            name="toggle_active"
+                            type="object"
+                            class="oe_stat_button"
+                            icon="fa-archive"
+                        >
+                            <field
+                                name="active"
+                                widget="boolean_button"
+                                options='{"terminology": "archive"}'
+                            />
                         </button>
                     </div>
                     <div class="oe_title">
-                    <label for="name" class="oe_edit_only" string="Agreement Name"/>
+                        <label
+                            for="name"
+                            class="oe_edit_only"
+                            string="Agreement Name"
+                        />
                         <h1>
-                        <field name="name"/>
+                            <field name="name" />
                         </h1>
                     </div>
                     <group name="main">
                         <group name="left">
-                        <field name="code"/>
-                        <field name="partner_id"
-                            attrs="{'required': [('is_template', '=', False)]}"/>
-                        <field name="agreement_type_id"
-                            groups="agreement.group_use_agreement_type"/>
-                        <field name="domain" widget="radio"/>
-                        <field name="is_template" groups="agreement.group_use_agreement_template"/>
+                            <field name="code" />
+                            <field
+                                name="partner_id"
+                                attrs="{'required': [('is_template', '=', False)]}"
+                            />
+                            <field
+                                name="agreement_type_id"
+                                groups="agreement.group_use_agreement_type"
+                            />
+                            <field name="domain" widget="radio" />
+                            <field
+                                name="is_template"
+                                groups="agreement.group_use_agreement_template"
+                            />
                         </group>
                         <group name="right">
-                        <field name="signature_date"/>
-                        <field name="start_date"/>
-                        <field name="end_date"/>
-                        <field name="company_id" groups="base.group_multi_company"/>
+                            <field name="signature_date" />
+                            <field name="start_date" />
+                            <field name="end_date" />
+                            <field
+                                name="company_id"
+                                groups="base.group_multi_company"
+                            />
                         </group>
                     </group>
                     <notebook>
-                    <page name="config" string="Configuration" attrs="{'invisible': True}"/>
+                        <page
+                            name="config"
+                            string="Configuration"
+                            attrs="{'invisible': True}"
+                        />
                     </notebook>
                 </sheet>
                 <div class="oe_chatter">
-                <field name="message_follower_ids" widget="mail_followers"/>
-                <field name="activity_ids" widget="mail_activity"/>
-                <field name="message_ids" widget="mail_thread"/>
+                    <field name="message_follower_ids" widget="mail_followers" />
+                    <field name="activity_ids" widget="mail_activity" />
+                    <field name="message_ids" widget="mail_thread" />
                 </div>
             </form>
         </field>
-</record>
-
-<record id="agreement_tree" model="ir.ui.view">
+    </record>
+    <record id="agreement_tree" model="ir.ui.view">
         <field name="name">agreement.tree</field>
         <field name="model">agreement</field>
         <field name="arch" type="xml">
             <tree string="Agreements">
-            <field name="partner_id"/>
-            <field name="code"/>
-            <field name="name"/>
-            <field name="signature_date"/>
-            <field name="start_date"/>
-            <field name="end_date"/>
-            <field name="domain"/>
-            <field name="company_id" groups="base.group_multi_company"/>
+                <field name="partner_id" />
+                <field name="code" />
+                <field name="name" />
+                <field name="signature_date" />
+                <field name="start_date" />
+                <field name="end_date" />
+                <field name="domain" />
+                <field name="company_id" groups="base.group_multi_company" />
             </tree>
         </field>
-</record>
-
-<record id="agreement_search" model="ir.ui.view">
+    </record>
+    <record id="agreement_search" model="ir.ui.view">
         <field name="name">agreement.search</field>
         <field name="model">agreement</field>
         <field name="arch" type="xml">
             <search string="Search Agreements">
-            <field name="name" filter_domain="['|', ('name', 'ilike', self), ('code', 'ilike', self)]" string="Name or Number"/>
-            <field name="partner_id"/>
-            <separator/>
-            <filter name="sale" string="Sale" domain="[('domain', '=', 'sale')]"/>
-            <filter name="purchase" string="Purchase" domain="[('domain', '=', 'purchase')]"/>
-            <separator/>
-            <filter name="inactive" string="Archived" domain="[('active', '=', False)]"/>
+                <field
+                    name="name"
+                    filter_domain="['|', ('name', 'ilike', self), ('code', 'ilike', self)]"
+                    string="Name or Number"
+                />
+                <field name="partner_id" />
+                <separator />
+                <filter name="sale" string="Sale" domain="[('domain', '=', 'sale')]" />
+                <filter
+                    name="purchase"
+                    string="Purchase"
+                    domain="[('domain', '=', 'purchase')]"
+                />
+                <separator />
+                <filter
+                    name="inactive"
+                    string="Archived"
+                    domain="[('active', '=', False)]"
+                />
                 <group name="groupby">
-                <filter name="partner_groupby" string="Partner"
-                    context="{'group_by': 'partner_id'}"/>
-                <filter name="signature_date_groupby" string="Signature Date"
-                    context="{'group_by': 'signature_date'}"/>
-                <filter name="domain_groupby" string="Domain"
-                    context="{'group_by': 'domain'}"/>
+                    <filter
+                        name="partner_groupby"
+                        string="Partner"
+                        context="{'group_by': 'partner_id'}"
+                    />
+                    <filter
+                        name="signature_date_groupby"
+                        string="Signature Date"
+                        context="{'group_by': 'signature_date'}"
+                    />
+                    <filter
+                        name="domain_groupby"
+                        string="Domain"
+                        context="{'group_by': 'domain'}"
+                    />
                 </group>
             </search>
         </field>
-</record>
-
-<record id="agreement_action" model="ir.actions.act_window">
+    </record>
+    <record id="agreement_action" model="ir.actions.act_window">
         <field name="name">Agreements</field>
         <field name="res_model">agreement</field>
         <field name="view_mode">tree,form</field>
-</record>
-
-
-<!-- Top menu item -->
-<menuitem id="agreement_menu_root"
+    </record>
+    <!-- Top menu item -->
+    <menuitem
+        id="agreement_menu_root"
         name="Agreements"
         web_icon="agreement,static/description/icon.png"
-    sequence="10"/>
-
-<menuitem id="agreement_menu"
+        sequence="10"
+    />
+    <menuitem
+        id="agreement_menu"
         name="Agreements"
         parent="agreement_menu_root"
         sequence="0"
         action="agreement_action"
-/>
-
+    />
 </odoo>

agreement/views/agreement_type.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
     <!-- Agreement Type List View-->
     <record model="ir.ui.view" id="agreement_type_list_view">
@@ -6,12 +6,11 @@
         <field name="model">agreement.type</field>
         <field name="arch" type="xml">
             <tree string="Agreement Types" default_order="name">
-                <field name="name" string="Type Name"/>
-                <field name="domain"/>
+                <field name="name" string="Type Name" />
+                <field name="domain" />
             </tree>
         </field>
     </record>
-
     <!-- Agreement Type Form View -->
     <record model="ir.ui.view" id="agreement_type_form_view">
         <field name="name">Agreement Type Form</field>
@@ -19,43 +18,62 @@
         <field name="arch" type="xml">
             <form string="Agreement Type">
                 <div class="oe_button_box" name="button_box">
-                    <button name="toggle_active" type="object"
-                            class="oe_stat_button" icon="fa-archive">
-                        <field name="active" widget="boolean_button"
-                               options='{"terminology": "archive"}'/>
+                    <button
+                        name="toggle_active"
+                        type="object"
+                        class="oe_stat_button"
+                        icon="fa-archive"
+                    >
+                        <field
+                            name="active"
+                            widget="boolean_button"
+                            options='{"terminology": "archive"}'
+                        />
                     </button>
                 </div>
                 <sheet>
                     <div class="oe_title">
-                        <label for="name" class="oe_edit_only"/>
-                        <h1><field name="name"/></h1>
+                        <label for="name" class="oe_edit_only" />
+                        <h1>
+                            <field name="name" />
+                        </h1>
                     </div>
                     <group name="main">
-                        <field name="domain" widget="radio"/>
+                        <field name="domain" widget="radio" />
                     </group>
                 </sheet>
             </form>
         </field>
     </record>
-
     <record id="agreement_type_search" model="ir.ui.view">
         <field name="name">agreement.type.search</field>
         <field name="model">agreement.type</field>
         <field name="arch" type="xml">
             <search string="Agreement Type">
-                <field name="name"/>
-                <separator/>
-                <filter name="sale" string="Sale" domain="[('domain', '=', 'sale')]"/>
-                <filter name="purchase" string="Purchase" domain="[('domain', '=', 'purchase')]"/>
-                <separator/>
-                <filter name="archived" string="Archived" domain="[('active', '=', False)]"/>
+                <field name="name" />
+                <separator />
+                <filter name="sale" string="Sale" domain="[('domain', '=', 'sale')]" />
+                <filter
+                    name="purchase"
+                    string="Purchase"
+                    domain="[('domain', '=', 'purchase')]"
+                />
+                <separator />
+                <filter
+                    name="archived"
+                    string="Archived"
+                    domain="[('active', '=', False)]"
+                />
                 <group name="groupby">
-                    <filter name="domain_groupby" string="Domain" context="{'group_by': 'domain'}"/>
+                    <filter
+                        name="domain_groupby"
+                        string="Domain"
+                        context="{'group_by': 'domain'}"
+                    />
                 </group>
             </search>
         </field>
     </record>
-
     <!-- Actions opening views on models -->
     <record model="ir.actions.act_window" id="agreement_type_action">
         <field name="name">Agreement Types</field>

setup/agreement/odoo/addons/agreement

@@ -0,0 +1 @@
+../../../../agreement

setup/agreement/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)