From 2c370b6208dfff9547eb2298d6e193a472e50cfd Mon Sep 17 00:00:00 2001
From: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
Date: Fri, 27 Sep 2019 09:41:19 +0200
Subject: [PATCH] [IMP] move some notions from agreement_legal to agreement

we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
---
 agreement_legal_sale/views/sale_order.xml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/agreement_legal_sale/views/sale_order.xml b/agreement_legal_sale/views/sale_order.xml
index 8b607a891..8a077c3db 100644
--- a/agreement_legal_sale/views/sale_order.xml
+++ b/agreement_legal_sale/views/sale_order.xml
@@ -7,12 +7,11 @@
     <record id="sale_order_agreement_form_view" model="ir.ui.view">
         <field name="name">sale.order.agreement.form.view</field>
         <field name="model">sale.order</field>
-        <field name="inherit_id" ref="sale.view_order_form"/>
+        <field name="inherit_id" ref="agreement_sale.sale_order_agreement_form_view"/>
         <field name="arch" type="xml">
-            <field name="client_order_ref" position="after">
-                <field name="agreement_id"
-                       readonly="1"
-                       attrs="{'invisible': [('agreement_id', '=', False)]}"/>
+            <field name="agreement_id" position="attributes">
+                <attribute name="readonly" eval='1'/>
+                <attribute name="attrs">{'invisible': [('agreement_id', '=', False)]}</attribute>
             </field>
             <field name="partner_id" position="after">
                 <field name="agreement_template_id"/>