[IMP] account_bank_statement_clear_partner: black, isort, prettier

account_bank_statement_clear_partner/__manifest__.py

@@ -9,10 +9,6 @@
     "website": "https://github.com/OCA/bank-statement-import",
     "author": "Tecnativa, Odoo Community Association (OCA)",
     "license": "AGPL-3",
-    "depends": [
+    "depends": ["account"],
-        'account',
+    "data": ["views/account_bank_statement_views.xml"],
-    ],
-    "data": [
-        "views/account_bank_statement_views.xml"
-    ]
 }

account_bank_statement_clear_partner/tests/test_account_bank_statement_clear_patner.py

@@ -8,76 +8,68 @@ class TestAccountBankStatementClearPartner(common.SavepointCase):
     @classmethod
     def setUpClass(cls):
         super(TestAccountBankStatementClearPartner, cls).setUpClass()
-        cls.partner_1 = cls.env['res.partner'].create(
+        cls.partner_1 = cls.env["res.partner"].create({"name": "Partner 1"})
+        cls.partner_2 = cls.env["res.partner"].create({"name": "Partner 2"})
+        cls.account_type_1 = cls.env["account.account.type"].create(
+            {"name": "Test Account Type 1", "type": "other"}
+        )
+        cls.account_1 = cls.env["account.account"].create(
             {
-                "name": "Partner 1",
+                "name": "Test Account 1",
+                "code": "AAAAAAAAAAAAAAAA",
+                "user_type_id": cls.account_type_1.id,
             }
         )
-        cls.partner_2 = cls.env['res.partner'].create(
+        cls.sequence_1 = cls.env["ir.sequence"].create({"name": "Test Sequence 1"})
+        cls.journal_1 = cls.env["account.journal"].create(
             {
-                "name": "Partner 2",
+                "name": "Test Journal 1",
+                "type": "bank",
+                "sequence_id": cls.sequence_1.id,
             }
         )
-        cls.account_type_1 = cls.env['account.account.type'].create({
+        cls.statement_1 = cls.env["account.bank.statement"].create(
-            "name": "Test Account Type 1",
+            {"name": "Test Bank Statement 1", "journal_id": cls.journal_1.id}
-            "type": "other"
+        )
-        })
+        cls.account_move_1 = cls.env["account.move"].create(
-        cls.account_1 = cls.env['account.account'].create({
+            {"name": "Test Account Move 1", "journal_id": cls.journal_1.id}
-            "name": "Test Account 1",
+        )
-            "code": "AAAAAAAAAAAAAAAA",
+        cls.account_move_line_1 = cls.env["account.move.line"].create(
-            "user_type_id": cls.account_type_1.id,
+            {"move_id": cls.account_move_1.id, "account_id": cls.account_1.id}
-        })
+        )
-        cls.sequence_1 = cls.env['ir.sequence'].create({
-            "name": "Test Sequence 1",
-        })
-        cls.journal_1 = cls.env['account.journal'].create({
-            "name": "Test Journal 1",
-            "type": "bank",
-            "sequence_id": cls.sequence_1.id,
-        })
-        cls.statement_1 = cls.env["account.bank.statement"].create({
-            "name": "Test Bank Statement 1",
-            "journal_id": cls.journal_1.id,
-        })
-        cls.account_move_1 = cls.env["account.move"].create({
-            "name": "Test Account Move 1",
-            "journal_id": cls.journal_1.id,
-        })
-        cls.account_move_line_1 = cls.env["account.move.line"].create({
-            "move_id": cls.account_move_1.id,
-            "account_id": cls.account_1.id,
-        })
         line_obj = cls.env["account.bank.statement.line"]
-        cls.st_line_w_partner_not_reconciled = line_obj.create({
+        cls.st_line_w_partner_not_reconciled = line_obj.create(
-            "name": "Test Account Bank Statement 1",
+            {
-            "statement_id": cls.statement_1.id,
+                "name": "Test Account Bank Statement 1",
-            "partner_id": cls.partner_1.id,
+                "statement_id": cls.statement_1.id,
-            "journal_entry_ids": False,
+                "partner_id": cls.partner_1.id,
-            "account_id": False,
+                "journal_entry_ids": False,
-        })
+                "account_id": False,
-        cls.st_line_wo_partner_not_reconciled = line_obj.create({
+            }
-            "name": "Test Account Bank Statement 2",
+        )
-            "statement_id": cls.statement_1.id,
+        cls.st_line_wo_partner_not_reconciled = line_obj.create(
-            "partner_id": False,
+            {
-            "journal_entry_ids": False,
+                "name": "Test Account Bank Statement 2",
-            "account_id": False,
+                "statement_id": cls.statement_1.id,
-        })
+                "partner_id": False,
-        cls.st_line_w_partner_reconciled = line_obj.create({
+                "journal_entry_ids": False,
-            "name": "Test Account Bank Statement 3",
+                "account_id": False,
-            "statement_id": cls.statement_1.id,
+            }
-            "partner_id": cls.partner_2.id,
+        )
-        })
+        cls.st_line_w_partner_reconciled = line_obj.create(
-        cls.account_move_line_1.write({
+            {
-            "statement_line_id": cls.st_line_w_partner_reconciled.id,
+                "name": "Test Account Bank Statement 3",
-        })
+                "statement_id": cls.statement_1.id,
+                "partner_id": cls.partner_2.id,
+            }
+        )
+        cls.account_move_line_1.write(
+            {"statement_line_id": cls.st_line_w_partner_reconciled.id}
+        )
 
     def test_bank_statements_clear_partner(self):
         self.statement_1.clear_partners()
         # Confirm statement_line_1 has no parter
-        self.assertFalse(
+        self.assertFalse(self.st_line_w_partner_not_reconciled.partner_id)
-            self.st_line_w_partner_not_reconciled.partner_id
-        )
         # Confirm statement_line_3 still has partner because it was already reconciled
-        self.assertTrue(
+        self.assertTrue(self.st_line_w_partner_reconciled.partner_id)
-            self.st_line_w_partner_reconciled.partner_id
-        )

account_bank_statement_clear_partner/views/account_bank_statement_views.xml

@@ -1,14 +1,22 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!-- Copyright 2020 Tecnativa - João Marques
      License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
-
 <odoo>
     <record id="view_bank_statement_form" model="ir.ui.view">
         <field name="model">account.bank.statement</field>
-        <field name="inherit_id" ref="account.view_bank_statement_form"></field>
+        <field name="inherit_id" ref="account.view_bank_statement_form" />
         <field name="arch" type="xml">
-            <button name="%(account.action_bank_reconcile_bank_statements)d" position="after">
+            <button
-                <button name="clear_partners" string="Clear partners" type="object" class="oe_highlight" attrs="{'invisible':['|','|',('all_lines_reconciled','=',True),('line_ids','=',[]),('state', '!=', 'open')]}"/>
+                name="%(account.action_bank_reconcile_bank_statements)d"
+                position="after"
+            >
+                <button
+                    name="clear_partners"
+                    string="Clear partners"
+                    type="object"
+                    class="oe_highlight"
+                    attrs="{'invisible':['|','|',('all_lines_reconciled','=',True),('line_ids','=',[]),('state', '!=', 'open')]}"
+                />
             </button>
         </field>
     </record>

setup/account_bank_statement_clear_partner/odoo/addons/account_bank_statement_clear_partner

@@ -0,0 +1 @@
+../../../../account_bank_statement_clear_partner

setup/account_bank_statement_clear_partner/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)