diff --git a/account_statement_import_camt/models/parser.py b/account_statement_import_camt/models/parser.py index 0ee3e739..0fdbeb27 100644 --- a/account_statement_import_camt/models/parser.py +++ b/account_statement_import_camt/models/parser.py @@ -219,8 +219,6 @@ class CamtParser(models.AbstractModel): result["date"] = sorted( transactions, key=lambda x: x["date"], reverse=True )[0]["date"] - for seq, vals in enumerate(transactions, start=1): - vals["sequence"] = seq return result def check_version(self, ns, root): diff --git a/account_statement_import_camt/test_files/golden-camt053-txdtls.pydata b/account_statement_import_camt/test_files/golden-camt053-txdtls.pydata index 37b60b30..44418034 100644 --- a/account_statement_import_camt/test_files/golden-camt053-txdtls.pydata +++ b/account_statement_import_camt/test_files/golden-camt053-txdtls.pydata @@ -10,13 +10,11 @@ 'narration': 'CRÉDIT GROUPÉ BVR TRAITEMENT DU 22.03.2017 NUMÉRO CLIENT 01-70884-3 PAQUET ID: 123456CHCAFEBABE', 'partner_name': 'Banque Cantonale Vaudoise', 'payment_ref': '/', - 'ref': '302388292000011111111111111', - 'sequence': 1}, + 'ref': '302388292000011111111111111'}, {'account_number': 'CH3333000000123456789', 'amount': 1296.0, 'date': '2017-03-22', 'narration': 'CRÉDIT GROUPÉ BVR TRAITEMENT DU 22.03.2017 NUMÉRO CLIENT 01-70884-3 PAQUET ID: 123456CHCAFEBABE', 'partner_name': 'Banque Cantonale Vaudoise', 'payment_ref': '/', - 'ref': '302388292000022222222222222', - 'sequence': 2}]}]) + 'ref': '302388292000022222222222222'}]}]) diff --git a/account_statement_import_camt/test_files/golden-camt053.pydata b/account_statement_import_camt/test_files/golden-camt053.pydata index 528f4f61..4c116025 100644 --- a/account_statement_import_camt/test_files/golden-camt053.pydata +++ b/account_statement_import_camt/test_files/golden-camt053.pydata @@ -9,26 +9,22 @@ 'date': '2014-01-05', 'partner_name': 'INSURANCE COMPANY TESTX', 'payment_ref': 'MKB Insurance 859239PERIOD 01.01.2014 - 31.12.2014', - 'ref': '435005714488-ABNO33052620', - 'sequence': 1}, + 'ref': '435005714488-ABNO33052620'}, {'account_number': 'NL46ABNA0499998748', 'amount': -564.05, 'date': '2014-01-05', 'partner_name': 'Test Customer', 'payment_ref': 'Direct debit S14 0410 AC07 Rek.nummer blokkade TESTBANK/NL/20141229/01206408', - 'ref': 'TESTBANK/NL/20141229/01206408', - 'sequence': 2}, + 'ref': 'TESTBANK/NL/20141229/01206408'}, {'account_number': 'NL46ABNA0499998748', 'amount': -100.0, 'date': '2014-01-05', 'partner_name': 'Test Customer', 'payment_ref': 'Direct debit S14 0410 AC07 Rek.nummer blokkade TESTBANK/NL/20141229/01206408', - 'ref': 'TESTBANK/NL/20141229/01206407', - 'sequence': 3}, + 'ref': 'TESTBANK/NL/20141229/01206407'}, {'account_number': 'NL69ABNA0522123643', 'amount': 1405.31, 'date': '2014-01-05', 'partner_name': '3rd party Media', 'payment_ref': '#RD PARTY MEDIA CUSNO 90782 4210773', - 'ref': '115', - 'sequence': 4}]}]) + 'ref': '115'}]}]) diff --git a/account_statement_import_camt/tests/test_import_bank_statement.py b/account_statement_import_camt/tests/test_import_bank_statement.py index 5e7b3a13..cda12fa9 100644 --- a/account_statement_import_camt/tests/test_import_bank_statement.py +++ b/account_statement_import_camt/tests/test_import_bank_statement.py @@ -118,6 +118,7 @@ class TestImport(TransactionCase): ) with open(testfile, "rb") as datafile: camt_file = base64.b64encode(datafile.read()) + self.env["account.statement.import"].create( { "statement_filename": "test import", @@ -156,4 +157,5 @@ class TestImport(TransactionCase): [("name", "in", ["1234Test/2", "1234Test/3"])] ) - self.assertTrue(all([st.line_ids for st in bank_st_record])) + self.assertTrue(all([st.line_ids for st in bank_st_record])) + self.assertEqual(bank_st_record[0].line_ids.mapped("sequence"), [1, 2, 3])