diff --git a/account_statement_import_online_ponto_ing/README.rst b/account_statement_import_online_ponto_ing/README.rst new file mode 100644 index 00000000..65848055 --- /dev/null +++ b/account_statement_import_online_ponto_ing/README.rst @@ -0,0 +1,84 @@ +===================================================== +Online Bank Statements: MyPonto.com ING customization +===================================================== + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github + :target: https://github.com/OCA/bank-statement-import/tree/14.0/account_statement_import_online_ponto_ing + :alt: OCA/bank-statement-import +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online_ponto_ing + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png + :target: https://runbot.odoo-community.org/runbot/174/14.0 + :alt: Try me on Runbot + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module provides special handling for Bank Transactions imported from Ponto +for the Dutch ING bank. Specifically it removes unneeded information from the +reference field (filled from the remittanceInformation) that is also provided in +other fields, like the counterpart accountnumber (IBAN) en the partnername. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +The code in this module will automatically be active if bank statements are +imported from Ponto and the Bank Identifier Code is INGBNL2A. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* Therp BV + +Contributors +~~~~~~~~~~~~ + +* `Therp BV `__ + + * Ronald Portier + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/bank-statement-import `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/account_statement_import_online_ponto_ing/__init__.py b/account_statement_import_online_ponto_ing/__init__.py new file mode 100644 index 00000000..31660d6a --- /dev/null +++ b/account_statement_import_online_ponto_ing/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import models diff --git a/account_statement_import_online_ponto_ing/__manifest__.py b/account_statement_import_online_ponto_ing/__manifest__.py new file mode 100644 index 00000000..f5d14ab3 --- /dev/null +++ b/account_statement_import_online_ponto_ing/__manifest__.py @@ -0,0 +1,12 @@ +# Copyright 2021 Therp BV . +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +{ + "name": "Online Bank Statements: MyPonto.com ING customization", + "version": "14.0.1.0.0", + "category": "Account", + "website": "https://github.com/OCA/bank-statement-import", + "author": "Therp BV, Odoo Community Association (OCA)", + "license": "AGPL-3", + "installable": True, + "depends": ["account_statement_import_online_ponto"], +} diff --git a/account_statement_import_online_ponto_ing/models/__init__.py b/account_statement_import_online_ponto_ing/models/__init__.py new file mode 100644 index 00000000..236b6f14 --- /dev/null +++ b/account_statement_import_online_ponto_ing/models/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import online_bank_statement_provider_ponto diff --git a/account_statement_import_online_ponto_ing/models/online_bank_statement_provider_ponto.py b/account_statement_import_online_ponto_ing/models/online_bank_statement_provider_ponto.py new file mode 100644 index 00000000..afb076b1 --- /dev/null +++ b/account_statement_import_online_ponto_ing/models/online_bank_statement_provider_ponto.py @@ -0,0 +1,36 @@ +# Copyright 2021 Therp BV . +# @author: Ronald Portier . +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import models + + +class OnlineBankStatementProviderPonto(models.Model): + _inherit = "online.bank.statement.provider" + + def _ponto_get_transaction_vals(self, transaction, sequence): + """Remove duplicate information from payment_ref (Label).""" + self.ensure_one() + vals_line = super()._ponto_get_transaction_vals(transaction, sequence) + if not self.journal_id.bank_account_id.bank_id.bic == "INGBNL2A": + return vals_line + payment_ref = vals_line["payment_ref"] + payment_ref_elements = payment_ref.split("
") + keep_elements = [] + for element in payment_ref_elements: + if element.startswith("Naam"): + continue + if element.startswith("Datum"): + continue + if element.startswith("Valutadatum"): + continue + if element.startswith("IBAN"): + continue + element = element.replace("Omschrijving: ", "") # Remove unneeded tag. + keep_elements.append(element) + if keep_elements: + payment_ref = ", ".join(keep_elements) + else: + payment_ref = False + vals_line["payment_ref"] = payment_ref + return vals_line diff --git a/account_statement_import_online_ponto_ing/readme/CONFIGURE.rst b/account_statement_import_online_ponto_ing/readme/CONFIGURE.rst new file mode 100644 index 00000000..5baa422d --- /dev/null +++ b/account_statement_import_online_ponto_ing/readme/CONFIGURE.rst @@ -0,0 +1,2 @@ +The code in this module will automatically be active if bank statements are +imported from Ponto and the Bank Identifier Code is INGBNL2A. diff --git a/account_statement_import_online_ponto_ing/readme/CONTRIBUTORS.rst b/account_statement_import_online_ponto_ing/readme/CONTRIBUTORS.rst new file mode 100644 index 00000000..fabaf043 --- /dev/null +++ b/account_statement_import_online_ponto_ing/readme/CONTRIBUTORS.rst @@ -0,0 +1,3 @@ +* `Therp BV `__ + + * Ronald Portier diff --git a/account_statement_import_online_ponto_ing/readme/DESCRIPTION.rst b/account_statement_import_online_ponto_ing/readme/DESCRIPTION.rst new file mode 100644 index 00000000..09f20c0e --- /dev/null +++ b/account_statement_import_online_ponto_ing/readme/DESCRIPTION.rst @@ -0,0 +1,4 @@ +This module provides special handling for Bank Transactions imported from Ponto +for the Dutch ING bank. Specifically it removes unneeded information from the +reference field (filled from the remittanceInformation) that is also provided in +other fields, like the counterpart accountnumber (IBAN) en the partnername. diff --git a/account_statement_import_online_ponto_ing/static/description/icon.png b/account_statement_import_online_ponto_ing/static/description/icon.png new file mode 100644 index 00000000..09847ed7 Binary files /dev/null and b/account_statement_import_online_ponto_ing/static/description/icon.png differ diff --git a/account_statement_import_online_ponto_ing/static/description/index.html b/account_statement_import_online_ponto_ing/static/description/index.html new file mode 100644 index 00000000..41dc0817 --- /dev/null +++ b/account_statement_import_online_ponto_ing/static/description/index.html @@ -0,0 +1,431 @@ + + + + + + +Online Bank Statements: MyPonto.com ING customization + + + +
+

Online Bank Statements: MyPonto.com ING customization

+ + +

Beta License: AGPL-3 OCA/bank-statement-import Translate me on Weblate Try me on Runbot

+

This module provides special handling for Bank Transactions imported from Ponto +for the Dutch ING bank. Specifically it removes unneeded information from the +reference field (filled from the remittanceInformation) that is also provided in +other fields, like the counterpart accountnumber (IBAN) en the partnername.

+

Table of contents

+ +
+

Configuration

+

The code in this module will automatically be active if bank statements are +imported from Ponto and the Bank Identifier Code is INGBNL2A.

+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Therp BV
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/bank-statement-import project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/account_statement_import_online_ponto_ing/tests/__init__.py b/account_statement_import_online_ponto_ing/tests/__init__.py new file mode 100644 index 00000000..d1f2895e --- /dev/null +++ b/account_statement_import_online_ponto_ing/tests/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import test_account_statement_import_online_ponto diff --git a/account_statement_import_online_ponto_ing/tests/test_account_statement_import_online_ponto.py b/account_statement_import_online_ponto_ing/tests/test_account_statement_import_online_ponto.py new file mode 100644 index 00000000..e4375565 --- /dev/null +++ b/account_statement_import_online_ponto_ing/tests/test_account_statement_import_online_ponto.py @@ -0,0 +1,195 @@ +# Copyright 2020 Florent de Labarre +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from datetime import date, datetime +from unittest import mock + +from odoo import fields +from odoo.tests import Form, common + +_module_ns = "odoo.addons.account_statement_import_online_ponto" +_provider_class = ( + _module_ns + + ".models.online_bank_statement_provider_ponto" + + ".OnlineBankStatementProviderPonto" +) + + +class TestAccountBankAccountStatementImportOnlinePonto(common.TransactionCase): + def setUp(self): + super().setUp() + + self.now = fields.Datetime.now() + self.currency_eur = self.env.ref("base.EUR") + self.currency_usd = self.env.ref("base.USD") + self.AccountJournal = self.env["account.journal"] + self.ResPartnerBank = self.env["res.partner.bank"] + self.OnlineBankStatementProvider = self.env["online.bank.statement.provider"] + self.AccountBankStatement = self.env["account.bank.statement"] + self.AccountBankStatementLine = self.env["account.bank.statement.line"] + self.AccStatemenPull = self.env["online.bank.statement.pull.wizard"] + + self.bank_account = self.ResPartnerBank.create( + { + "acc_number": "FR0214508000302245362775K46", + "partner_id": self.env.user.company_id.partner_id.id, + } + ) + self.journal = self.AccountJournal.create( + { + "name": "Bank", + "type": "bank", + "code": "BANK", + "currency_id": self.currency_eur.id, + "bank_statements_source": "online", + "online_bank_statement_provider": "ponto", + "bank_account_id": self.bank_account.id, + } + ) + self.provider = self.journal.online_bank_statement_provider_id + + self.mock_header = lambda: mock.patch( + _provider_class + "._ponto_header", + return_value={ + "Accept": "application/json", + "Authorization": "Bearer --TOKEN--", + }, + ) + + self.mock_account_ids = lambda: mock.patch( + _provider_class + "._ponto_get_account_ids", + return_value={"FR0214508000302245362775K46": "id"}, + ) + self.mock_synchronisation = lambda: mock.patch( + _provider_class + "._ponto_synchronisation", + return_value=None, + ) + + self.mock_transaction = lambda: mock.patch( + _provider_class + "._ponto_get_transaction", + return_value=[ + { + "type": "transaction", + "relationships": { + "account": { + "links": {"related": "https://api.myponto.com/accounts/"}, + "data": { + "type": "account", + "id": "fd3d5b1d-fca9-4310-a5c8-76f2a9dc7c75", + }, + } + }, + "id": "701ab965-21c4-46ca-b157-306c0646e0e2", + "attributes": { + "valueDate": "2019-11-18T00:00:00.000Z", + "remittanceInformationType": "unstructured", + "remittanceInformation": "Minima vitae totam!", + "executionDate": "2019-11-20T00:00:00.000Z", + "description": "Wire transfer", + "currency": "EUR", + "counterpartReference": "BE26089479973169", + "counterpartName": "Osinski Group", + "amount": 6.08, + }, + }, + { + "type": "transaction", + "relationships": { + "account": { + "links": {"related": "https://api.myponto.com/accounts/"}, + "data": { + "type": "account", + "id": "fd3d5b1d-fca9-4310-a5c8-76f2a9dc7c75", + }, + } + }, + "id": "9ac50483-16dc-4a82-aa60-df56077405cd", + "attributes": { + "valueDate": "2019-11-04T00:00:00.000Z", + "remittanceInformationType": "unstructured", + "remittanceInformation": "Quia voluptatem blanditiis.", + "executionDate": "2019-11-06T00:00:00.000Z", + "description": "Wire transfer", + "currency": "EUR", + "counterpartReference": "BE97201830401438", + "counterpartName": "Stokes-Miller", + "amount": 5.48, + }, + }, + { + "type": "transaction", + "relationships": { + "account": { + "links": {"related": "https://api.myponto.com/accounts/"}, + "data": { + "type": "account", + "id": "fd3d5b1d-fca9-4310-a5c8-76f2a9dc7c75", + }, + } + }, + "id": "b21a6c65-1c52-4ba6-8cbc-127d2b2d85ff", + "attributes": { + "valueDate": "2019-11-04T00:00:00.000Z", + "remittanceInformationType": "unstructured", + "remittanceInformation": "Laboriosam repelo?", + "executionDate": "2019-11-04T00:00:00.000Z", + "description": "Wire transfer", + "currency": "EUR", + "counterpartReference": "BE10325927501996", + "counterpartName": "Strosin-Veum", + "amount": 5.83, + }, + }, + ], + ) + + def test_balance_start(self): + st_form = Form(self.AccountBankStatement) + st_form.journal_id = self.journal + st_form.date = date(2019, 11, 1) + st_form.balance_end_real = 100 + with st_form.line_ids.new() as line_form: + line_form.payment_ref = "test move" + line_form.amount = 100 + initial_statement = st_form.save() + initial_statement.button_post() + with self.mock_transaction(), self.mock_header(), self.mock_synchronisation(), self.mock_account_ids(): # noqa: B950 + vals = { + "provider_ids": self.provider.ids, + "date_since": datetime(2019, 11, 4), + "date_until": datetime(2019, 11, 5), + } + wizard = self.AccStatemenPull.with_context( + active_model="account.journal", + active_id=self.journal.id, + ).create(vals) + wizard.action_pull() + statements = self.AccountBankStatement.search( + [("journal_id", "=", self.journal.id)] + ) + new_statement = statements - initial_statement + self.assertEqual(len(new_statement.line_ids), 1) + self.assertEqual(new_statement.balance_start, 100) + self.assertEqual(new_statement.balance_end_real, 105.83) + + def test_ponto(self): + with self.mock_transaction(), self.mock_header(), self.mock_synchronisation(), self.mock_account_ids(): # noqa: B950 + vals = { + "provider_ids": self.provider.ids, + "date_since": datetime(2019, 11, 3), + "date_until": datetime(2019, 11, 17), + } + wizard = self.AccStatemenPull.with_context( + active_model="account.journal", + active_id=self.journal.id, + ).create(vals) + # To get all the moves at once + self.provider.statement_creation_mode = "monthly" + wizard.action_pull() + statement = self.AccountBankStatement.search( + [("journal_id", "=", self.journal.id)] + ) + self.assertEqual(len(statement), 1) + self.assertEqual(len(statement.line_ids), 3) + self.assertEqual(statement.line_ids.mapped("amount"), [6.08, 5.48, 5.83]) + self.assertEqual(statement.balance_end_real, 17.39) diff --git a/setup/account_statement_import_online_ponto_ing/odoo/addons/account_statement_import_online_ponto_ing b/setup/account_statement_import_online_ponto_ing/odoo/addons/account_statement_import_online_ponto_ing new file mode 120000 index 00000000..0e490aea --- /dev/null +++ b/setup/account_statement_import_online_ponto_ing/odoo/addons/account_statement_import_online_ponto_ing @@ -0,0 +1 @@ +../../../../account_statement_import_online_ponto_ing \ No newline at end of file diff --git a/setup/account_statement_import_online_ponto_ing/setup.py b/setup/account_statement_import_online_ponto_ing/setup.py new file mode 100644 index 00000000..28c57bb6 --- /dev/null +++ b/setup/account_statement_import_online_ponto_ing/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +)