mirror of
https://github.com/OCA/bank-payment.git
synced 2025-02-02 10:37:31 +02:00
7768143563
On certain v16 instances, although the partner bank account that is being pre-set in the account.payment creation values dictionary: https://github.com/OCA/bank-payment/blob/fc7783669f40d85/account_payment_order/models/account_payment_line.py#L206 it's being marked as dirty (it's a computed writable field), and thus, being recomputed before being saved, getting an invalid value (on direct debits, the company's bank account). The triggers that lead to this situation are unknown due to the low level where it's happening and the tons of interactions being taken in place, so the best way to deal with this is to override the compute method that computes this value, so even if the field is recomputed, it gets the correct value. Let's be pragmatic... TT50804
99 lines
3.9 KiB
Python
99 lines
3.9 KiB
Python
# Copyright 2019 ACSONE SA/NV
|
|
# Copyright 2022 Tecnativa - Pedro M. Baeza
|
|
# Copyright 2023 Noviat
|
|
# Copyright 2024 Tecnativa - Víctor Martínez
|
|
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
|
|
|
|
from odoo import _, api, fields, models
|
|
|
|
|
|
class AccountPayment(models.Model):
|
|
_inherit = "account.payment"
|
|
|
|
payment_order_id = fields.Many2one(comodel_name="account.payment.order")
|
|
payment_line_ids = fields.Many2many(comodel_name="account.payment.line")
|
|
order_state = fields.Selection(
|
|
related="payment_order_id.state", string="Payment Order State"
|
|
)
|
|
payment_line_date = fields.Date(compute="_compute_payment_line_date")
|
|
|
|
@api.depends("payment_type", "journal_id")
|
|
def _compute_payment_method_line_fields(self):
|
|
res = super()._compute_payment_method_line_fields()
|
|
for pay in self:
|
|
if pay.payment_order_id:
|
|
pay.available_payment_method_line_ids = (
|
|
pay.payment_order_id.journal_id._get_available_payment_method_lines(
|
|
pay.payment_type
|
|
)
|
|
)
|
|
else:
|
|
pay.available_payment_method_line_ids = (
|
|
pay.journal_id._get_available_payment_method_lines(
|
|
pay.payment_type
|
|
).filtered(lambda x: not x.payment_method_id.payment_order_only)
|
|
)
|
|
to_exclude = pay._get_payment_method_codes_to_exclude()
|
|
if to_exclude:
|
|
pay.available_payment_method_line_ids = (
|
|
pay.available_payment_method_line_ids.filtered(
|
|
lambda x: x.code not in to_exclude
|
|
)
|
|
)
|
|
return res
|
|
|
|
@api.depends("payment_line_ids", "payment_line_ids.date")
|
|
def _compute_payment_line_date(self):
|
|
for item in self:
|
|
item.payment_line_date = item.payment_line_ids[:1].date
|
|
|
|
@api.depends("payment_line_ids")
|
|
def _compute_partner_bank_id(self):
|
|
# Force the payment line bank account. The grouping function has already
|
|
# assured that there's no more than one bank account in the group
|
|
order_pays = self.filtered("payment_line_ids")
|
|
for pay in order_pays:
|
|
pay.partner_bank_id = pay.payment_line_ids.partner_bank_id
|
|
return super(AccountPayment, self - order_pays)._compute_partner_bank_id()
|
|
|
|
@api.constrains("payment_method_line_id")
|
|
def _check_payment_method_line_id(self):
|
|
for pay in self:
|
|
transfer_journal = (
|
|
pay.payment_order_id.payment_mode_id.transfer_journal_id
|
|
or pay.company_id.transfer_journal_id
|
|
)
|
|
if pay.journal_id == transfer_journal:
|
|
continue
|
|
else:
|
|
super(AccountPayment, pay)._check_payment_method_line_id()
|
|
return
|
|
|
|
def update_payment_reference(self):
|
|
view = self.env.ref("account_payment_order.account_payment_update_view_form")
|
|
return {
|
|
"name": _("Update Payment Reference"),
|
|
"view_type": "form",
|
|
"view_mode": "form",
|
|
"res_model": "account.payment.update",
|
|
"view_id": view.id,
|
|
"target": "new",
|
|
"type": "ir.actions.act_window",
|
|
"context": dict(
|
|
self.env.context, default_payment_reference=self.payment_reference
|
|
),
|
|
}
|
|
|
|
def _prepare_move_line_default_vals(self, write_off_line_vals=None):
|
|
"""Overwrite date_maturity of the move_lines that are generated when related
|
|
to a payment order.
|
|
"""
|
|
vals_list = super()._prepare_move_line_default_vals(
|
|
write_off_line_vals=write_off_line_vals
|
|
)
|
|
if not self.payment_order_id:
|
|
return vals_list
|
|
for vals in vals_list:
|
|
vals["date_maturity"] = self.payment_line_ids[0].date
|
|
return vals_list
|