Commit Graph

39 Commits

Author SHA1 Message Date
Andrea
d7e72114e6 [FIX] avoid cache miss in compute 2022-03-09 17:58:47 +01:00
Valentin Vinagre Urteaga
ad66139589 [FIX] account_payment_order: fix set partner_bank_id in account move lines
Case:
The bank account isn't set properly in the payment order lines, because the bank account is only got from account.move.line or the first bank account in the partner_id, but never from the invoice (account.move).

Solution:
With this fix, the bank account will be get from account.move when matching the criteria.
2022-03-09 17:58:47 +01:00
Raf Ven
10a529c859 [MIG] account_payment_order: Migration to 13.0 2022-03-09 17:58:47 +01:00
Raf Ven
4f076b21f4 [IMP] account_payment_order: black, isort 2022-03-09 17:58:47 +01:00
Carlos Dauden
46245a3288 [IMP] account_payment_order: Select first partner bank 2022-03-09 17:58:47 +01:00
Pedro M. Baeza
de31571676 [FIX] account_payment_error: Avoid singleton error in allowed_journal_ids
Fixes #612
2022-03-09 17:58:47 +01:00
Guewen Baconnier
6d862e3e71 Add indexes on account payment models
The fields where the indexes are added are used in searches in
account_payment_order, which becomes really slow when a database have
many lines.
2022-03-09 17:58:47 +01:00
Thomas Binsfeld
a78917fa89 [REF] Payment Order: move all move preparation code in _prepare_move 2022-03-09 17:58:47 +01:00
Thomas Binsfeld
257289dfb2 [ADD] Payment Order: only payment order option on payment methods
New option on payment methods: payment order only (unchecked by default) allowing to enforce the use of payment orders for some payment methods
2022-03-09 17:58:47 +01:00
Thomas Binsfeld
ec160255a8 [REF] Account Payment Order: split generate_move method 2022-03-09 17:58:47 +01:00
Thomas Binsfeld
1ad7003dd1 [REF] Payment Order: payment line creation from move line
Benefits of the batch creation of Odoo 12.0
The method returns the created payment lines
2022-03-09 17:58:47 +01:00
Thomas Binsfeld
cdacd28064 [REF] Payment Order: allow add to order from invoice if order exists 2022-03-09 17:58:47 +01:00
Pedro M. Baeza
e652a4a6ac [FIX] account_payment_order: Fix journal domain
Steps to reproduce
------------------

* Create a payment mode with "Link to Bank Account" = "Variable".
* Select several journals.
* Create a payment order with that payment mode.
* Save.
* Go to other menu and come back to payment order.
* Try to select a journal: the list is empty.

Fixes #544
2022-03-09 17:58:47 +01:00
Thomas Binsfeld
660a461697 [REF] Payment Order: better performance of draft2open method
Add a norecompute in draft2open to avoid the recomputation of total_company_currency n times (where n is the number of payment lines)
2022-03-09 17:58:47 +01:00
Pedro M. Baeza
43e2876e76 [MIG] account_banking_sepa_direct_debit: Finish migration to 12.0
* Fixed tests
* Adjust code for Python dates handling
* Update copyrights
2022-03-09 17:58:47 +01:00
Pedro M. Baeza
82d1cade74 [MIG] account_payment_order: Finish migration to v12
* Removed deprecated YAML tests.
* Removed document dependency, as now there's no attachment dropdown.
* Switched deprecated `compute` method of res.currency.
* Restored missing field `reference_type` in invoices.
* Fixed call to `message_post`.
* Added missing description in model.
2022-03-09 17:58:47 +01:00
Martronic SA
105d3d080f Fix structured communication
Adds 'structured' to the invoice_reference_type2communication_type ans the 'structured' type is added by the module itself in account_invoice but breaks the account_move_line.py as explained here: https://github.com/OCA/bank-payment/issues/495
2022-03-09 17:58:47 +01:00
ecino
c1a9f672f5 [IMP] account_payment_order: Use bank.payment.line reference in Payment Order Move Lines (#418) 2022-03-09 17:58:47 +01:00
Alexis de Lattre
dde0542196 Several small usability improvements
- when manually encoding a payment line, get company currency as default currency
- Search on payment order numbers
- Direct search on bank journal name in payment orders
- remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
2022-03-09 17:58:47 +01:00
Pedro M. Baeza
34c82d0c2d [FIX] account_payment_order: Take payment mode from move (#466)
When adding to a payment order from invoices, the payment mode
considered is the one in the invoice, but once you have confirmed it,
you can't change it, so if you change the payment mode in the journal
items, it doesn't make the difference.

With this change, this is taken into account for adding to the
payment order(s) properly.
2022-03-09 17:58:47 +01:00
Jordi Ballester
664efc93c5 When the user looks for open payables or receivables, in the
context of payment orders, she should ocus on the amount that
is due to be paid. In this method we are forcing to display both
the amount due in company and in the invoice currency.

We then hide the fields debit and credit, because they add no value.
2022-03-09 17:58:47 +01:00
etobella
4cc8a3aa8e [MIG] account_payment_order 2022-03-09 17:58:47 +01:00
Gilles Meyomesse (ACSONE)
75b0e49949 [ADD] report for payment order (#370) 2022-03-09 17:58:47 +01:00
gilles
01ffe7e665 [ADD] description field for payment order 2022-03-09 17:58:47 +01:00
Akim Juillerat
85bb5853a4 [10.0]Fix payment method onchange with multicompany (#374) 2022-03-09 17:58:47 +01:00
Adrien Peiffer (ACSONE)
acbf3aac29 [IMP] account_payment_order: select partner bank account automatically. 2022-03-09 17:58:47 +01:00
Akim Juillerat
04df6fa875 [IMP] account_payment_order: Restriction + tests
* Restrict the deletion of bank payment line
* Add test_cancel_payment_order
2022-03-09 17:58:47 +01:00
mdietrichc2c
5767d27a78 [IMP] account_payment_order: Don't allow deletion of an uploaded payment order + allow to cancel an uploaded payment order 2022-03-09 17:58:47 +01:00
Alexis de Lattre
9d0c4a5a7d [FIX+IMP] account_payment_order:
* FIX: Bug #353 crash when selecting a payment mode that has a variable link to a bank account
* FIX: Add 'post_move' option on account.payment.mode with default True, to keep the previous behavior
* IMP: Explicit error when bank account is missing on bank journal
* IMP: Add field default_date_prefered on payment mode.
2022-03-09 17:58:47 +01:00
vrenaville
1a29d111df [FIX] fill date instead off maturity date on account move line generated 2022-03-09 17:58:47 +01:00
Jose Maria Alzaga
327ea2645e Remove internal_type=other restriction for transfer account (#311) 2022-03-09 17:58:47 +01:00
Adrien Peiffer (ACSONE)
cd58b9df2e [FIX] account_payment_order: Use 'index' instead of 'select' 2022-03-09 17:58:47 +01:00
Alexis de Lattre
8c82f7af87 Port almost all modules to v10 (#305)
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug #300)
2022-03-09 17:58:47 +01:00
Stéphane Bidoul (ACSONE)
7af8870e37 [IMP] set partner on offsetting account move line if possible
fixes #277
2022-03-09 17:58:47 +01:00
Alexis de Lattre
0c1463fc17 [FIX] account_payment_order: 4 things:
* Fix crash when selecting a customer that has a direct debit payment mode but no mandate
* Hide many fields when payment_order_ok is False on a payment_mode
* Fix payment line communication when the move line is not linked to an invoice (problem found when porting donation_debit_debit to v9)
* For the communication field, if self.move_id.ref is False, fallback on self.move_id.name
2022-03-09 17:58:47 +01:00
Stéphane Bidoul (ACSONE)
b1f03931bf [FIX+IMP] account_payment_order: 2 more things:
* IMP: extensibility of _prepare_move

  Pass the list of bank lines to _prepare_move so it is possible to customize the move (eg it's name) based on the lines being paid.

* FIX: payment order: add missing onchange dependencies in move selection wizard
2022-03-09 17:58:47 +01:00
Alexis de Lattre
a21d1065bd Add support for multi-currency in the generation of the account move.
Take into account all the remaining remarks of Frederic Clementi dated May 30:
- see multi-currency amounts in the wizard to add transaction lines
- add help msg on bank payment lines
2022-03-09 17:58:47 +01:00
Stéphane Bidoul
fd3083a588 [FIX+IMP] account_payment_order: 2 things:
* IMP: prevent deleting a move-line that is linked to a payment order line
* FIX: better filtering of move lines already included in open payment order
2022-03-09 17:58:47 +01:00
Alexis de Lattre
1c15633dbf Start to port bank-payment to v9 (with a lot of improvements) during the Sorrento Code sprint 2016
Improvements include:
- full re-organisation of modules and big re-organisation of the code
- simplification of the code related to the fact that support for direct debit is now in t
he base module, not added by an optional module account_direct_debit (module was removed)
- new design of the wizard to select move lines to pay
- support for non-SEPA file transfer-
- support for German direct debit SEPA files (fixes bug #129)
- remove workflow of payment.order
- add wizard of selection of move lines to pay
2022-03-09 17:58:47 +01:00