From c06c90f557519a063b202c351c3832568f370dea Mon Sep 17 00:00:00 2001 From: Stefan Rijnhart Date: Fri, 30 Aug 2013 22:54:33 +0200 Subject: [PATCH 1/3] [FIX] Preserve bank statement order by date --- account_banking/account_banking.py | 1 - 1 file changed, 1 deletion(-) diff --git a/account_banking/account_banking.py b/account_banking/account_banking.py index 14d9cc807..7b56e70f3 100644 --- a/account_banking/account_banking.py +++ b/account_banking/account_banking.py @@ -284,7 +284,6 @@ class account_bank_statement(orm.Model): 4. Ordering is based on auto generated id. ''' _inherit = 'account.bank.statement' - _order = 'id' _columns = { 'period_id': fields.many2one('account.period', 'Period', From 352f65fadc5c81f8a299630c1e43ba04550030f1 Mon Sep 17 00:00:00 2001 From: Stefan Rijnhart Date: Fri, 6 Sep 2013 15:42:33 +0200 Subject: [PATCH 2/3] [RFR] Update class doc --- account_banking/account_banking.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/account_banking/account_banking.py b/account_banking/account_banking.py index 7b56e70f3..32d5cb57d 100644 --- a/account_banking/account_banking.py +++ b/account_banking/account_banking.py @@ -274,14 +274,11 @@ account_banking_imported_file() class account_bank_statement(orm.Model): ''' - Extensions from account_bank_statement: - 1. Removed period_id (transformed to optional boolean) - as it is no - longer needed. - NB! because of #1. changes required to account_voucher! - 2. Extended 'button_confirm' trigger to cope with the period per - statement_line situation. - 3. Added optional relation with imported statements file - 4. Ordering is based on auto generated id. + Implement changes to this model for the following features: + - period_id on the bank statement line is leading + - bank statement lines have state. Move lines are + - upon confirmation of a statement line, the generated move + line is reconciled according to the matched entries ''' _inherit = 'account.bank.statement' From 1d8ce928e94611fe7386c655b166c5ef22599663 Mon Sep 17 00:00:00 2001 From: Stefan Rijnhart Date: Mon, 9 Sep 2013 11:16:53 +0200 Subject: [PATCH 3/3] [RFR] Improved doc --- account_banking/account_banking.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/account_banking/account_banking.py b/account_banking/account_banking.py index 32d5cb57d..99ba5acde 100644 --- a/account_banking/account_banking.py +++ b/account_banking/account_banking.py @@ -275,10 +275,15 @@ account_banking_imported_file() class account_bank_statement(orm.Model): ''' Implement changes to this model for the following features: - - period_id on the bank statement line is leading - - bank statement lines have state. Move lines are - - upon confirmation of a statement line, the generated move - line is reconciled according to the matched entries + + * bank statement lines have their own period_id, derived from + their effective date. The period and date are propagated to + the move lines created from each statement line + * bank statement lines have their own state. When a statement + is confirmed, all lines are confirmed too. When a statement + is reopened, lines remain confirmed until reopened individually. + * upon confirmation of a statement line, the move line is + created and reconciled according to the matched entry(/ies) ''' _inherit = 'account.bank.statement'