From a3aed62583609d3473ba392c2a92a629e374ac1f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= <stephane.bidoul@acsone.eu>
Date: Tue, 27 Aug 2024 22:02:03 +0200
Subject: [PATCH] [FIX] account_payment_order: allow multiple payment lines
 without move line

---
 .../models/account_payment_order.py           |  4 ++-
 .../tests/test_payment_order_outbound.py      | 28 +++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/account_payment_order/models/account_payment_order.py b/account_payment_order/models/account_payment_order.py
index cab62cdc3..7b740b8e3 100644
--- a/account_payment_order/models/account_payment_order.py
+++ b/account_payment_order/models/account_payment_order.py
@@ -224,7 +224,9 @@ class AccountPaymentOrder(models.Model):
     @api.constrains("payment_line_ids")
     def _check_payment_lines(self):
         for order in self:
-            move_line_ids = [x.move_line_id.id for x in order.payment_line_ids]
+            move_line_ids = [
+                x.move_line_id.id for x in order.payment_line_ids if x.move_line_id
+            ]
             if len(move_line_ids) != len(set(move_line_ids)):
                 raise ValidationError(
                     _(
diff --git a/account_payment_order/tests/test_payment_order_outbound.py b/account_payment_order/tests/test_payment_order_outbound.py
index 62f55680e..271b81ffc 100644
--- a/account_payment_order/tests/test_payment_order_outbound.py
+++ b/account_payment_order/tests/test_payment_order_outbound.py
@@ -7,6 +7,7 @@ from datetime import date, datetime, timedelta
 
 from odoo import fields
 from odoo.exceptions import UserError, ValidationError
+from odoo.fields import Command
 from odoo.tests import Form, tagged
 
 from odoo.addons.account.tests.common import AccountTestInvoicingCommon
@@ -479,6 +480,33 @@ class TestPaymentOrderOutbound(TestPaymentOrderOutboundBase):
 
         self.assertEqual("F/1234 FR/1234", payment_order.payment_line_ids.communication)
 
+    def test_multiple_lines_without_move_line(self):
+        """Test that a payment order with multiple lines without related
+        journal items can be created"""
+        self.env["account.payment.order"].create(
+            {
+                "date_prefered": "due",
+                "payment_type": "outbound",
+                "payment_mode_id": self.mode.id,
+                "journal_id": self.bank_journal.id,
+                "description": "order with manual line",
+                "payment_line_ids": [
+                    Command.create(
+                        {
+                            "partner_id": self.partner.id,
+                            "amount_currency": 101.00,
+                        }
+                    ),
+                    Command.create(
+                        {
+                            "partner_id": self.partner.id,
+                            "amount_currency": 101.00,
+                        }
+                    ),
+                ],
+            }
+        )
+
     def test_supplier_manual_refund(self):
         """
         Confirm the supplier invoice with reference