From 7ec6508724ec630518e0a64a94a84230dc33acca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?=
 <victor.martinez@tecnativa.com>
Date: Wed, 28 Feb 2024 09:56:11 +0100
Subject: [PATCH] [FIX] account_payment_order: Prevent duplicates archived bank
 accounts

TT47789
---
 account_payment_order/models/account_payment_order.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/account_payment_order/models/account_payment_order.py b/account_payment_order/models/account_payment_order.py
index 061c3d859..87dab6407 100644
--- a/account_payment_order/models/account_payment_order.py
+++ b/account_payment_order/models/account_payment_order.py
@@ -163,15 +163,15 @@ class AccountPaymentOrder(models.Model):
     )
     def _compute_partner_banks_archive_msg(self):
         """Information message to show archived bank accounts and to be able
-        to act on them before confirmation."""
+        to act on them before confirmation (avoid duplicates)."""
         for item in self:
             msg_lines = []
-            for line in item.payment_line_ids.filtered(
+            for partner_bank in item.payment_line_ids.filtered(
                 lambda x: x.partner_bank_id and not x.partner_bank_id.active
-            ):
+            ).mapped("partner_bank_id"):
                 msg_line = _("<b>Account Number</b>: %s - <b>Partner</b>: %s") % (
-                    line.partner_bank_id.acc_number,
-                    line.partner_bank_id.partner_id.display_name,
+                    partner_bank.acc_number,
+                    partner_bank.partner_id.display_name,
                 )
                 msg_lines.append(msg_line)
             item.partner_banks_archive_msg = (