From 6389e560c3bb3e471a2fcd71c8ef5a7698597310 Mon Sep 17 00:00:00 2001
From: Rodrigo <rodrigo.bonilla@factorlibre.com>
Date: Thu, 13 Apr 2023 15:37:27 +0200
Subject: [PATCH] [FIX] account_payment_partner: bad application of attributes
 on the field partner_bank_id, this commit fixes showing the same field twice
 in customer invoices.

---
 .../views/account_move_view.xml               | 21 ++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/account_payment_partner/views/account_move_view.xml b/account_payment_partner/views/account_move_view.xml
index f4e60fc01..4f2ac00a1 100644
--- a/account_payment_partner/views/account_move_view.xml
+++ b/account_payment_partner/views/account_move_view.xml
@@ -35,7 +35,13 @@
                 <field name="payment_mode_filter_type_domain" invisible="1" />
                 <field name="partner_bank_filter_type_domain" invisible="1" />
             </field>
-            <field name="partner_bank_id" position="attributes">
+            <xpath
+                expr="//group[@id='header_right_group']//field[@name='partner_bank_id']"
+                position="attributes"
+            >
+                <attribute name="context">
+                    {'default_partner_id':commercial_partner_id}
+                </attribute>
                 <attribute name="domain">
                     [('partner_id', '=', partner_bank_filter_type_domain),
                     '|',('company_id', '=', company_id),('company_id', '=', False)]
@@ -43,12 +49,21 @@
                 <attribute name="attrs">
                     {'required': [('bank_account_required', '=', True),('move_type', 'in', ('in_invoice', 'in_refund'))],
                     'readonly': [('state', '!=', 'draft')],
-                    'invisible': [('move_type', '=', 'entry')]}
+                    'invisible': [('move_type', 'not in', ('in_invoice', 'in_refund', 'in_receipt'))]}
                 </attribute>
+            </xpath>
+            <xpath
+                expr="//page[@id='other_tab']//field[@name='partner_bank_id']"
+                position="attributes"
+            >
                 <attribute name="context">
                     {'default_partner_id':commercial_partner_id}
                 </attribute>
-            </field>
+                <attribute name="domain">
+                    [('partner_id', '=', partner_bank_filter_type_domain),
+                    '|',('company_id', '=', company_id),('company_id', '=', False)]
+                </attribute>
+            </xpath>
         </field>
     </record>
     <record id="view_invoice_tree" model="ir.ui.view">