From 5579dd5c6066c641f625efd52305974331194fde Mon Sep 17 00:00:00 2001 From: "Pieter J. Kersten" Date: Thu, 28 Apr 2011 10:07:51 +0200 Subject: [PATCH] [FIX] account_banking: Changed German localized BBAN format Reactivated apparently unused/untested path [IMP] account_banking: Changed default type of parser model members to str Extended comments in template regarding numbering schemes --- account_banking/__terp__.py | 2 +- account_banking/parsers/models.py | 12 +++++++++++- account_banking/sepa/iban.py | 2 +- account_banking/wizard/bank_import.py | 2 +- account_banking_fi_patu/__terp__.py | 2 +- account_banking_nl_abnamro/__terp__.py | 2 +- account_banking_nl_clieop/__terp__.py | 2 +- account_banking_nl_girotel/__terp__.py | 2 +- account_banking_nl_multibank/__terp__.py | 2 +- account_banking_nl_triodos/__terp__.py | 2 +- 10 files changed, 20 insertions(+), 10 deletions(-) diff --git a/account_banking/__terp__.py b/account_banking/__terp__.py index 8641db9c3..c4db78cb4 100644 --- a/account_banking/__terp__.py +++ b/account_banking/__terp__.py @@ -25,7 +25,7 @@ ############################################################################## { 'name': 'Account Banking', - 'version': '0.1.60', + 'version': '0.1.61', 'license': 'GPL-3', 'author': 'EduSense BV', 'website': 'http://www.edusense.nl', diff --git a/account_banking/parsers/models.py b/account_banking/parsers/models.py index a0579af74..ee9802c23 100644 --- a/account_banking/parsers/models.py +++ b/account_banking/parsers/models.py @@ -239,7 +239,7 @@ class mem_bank_transaction(object): ''' super(mem_bank_transaction, self).__init__(*args, **kwargs) for attr in self.__slots__: - setattr(self, attr, None) + setattr(self, attr, '') self.remote_owner_address = [] def copy(self): @@ -344,6 +344,16 @@ class parser(object): numbers or bank statements ids on your own - stick with those provided by your bank. Doing so enables the users to re-load old transaction files without creating multiple identical bank statements. + + If your bank does not provide transaction ids, take a high resolution + and a repeatable algorithm for the numbering. For example the date can + be used as a prefix. Adding a tracer (day resolution) can create + uniqueness. Adding unique statement ids can add to the robustness of + your transaction numbering. + + Just mind that users can create random (file)containers with + transactions in it. Try not to depend on order of appearance within + these files. If in doubt: sort. ''' raise NotImplementedError( _('This is a stub. Please implement your own.') diff --git a/account_banking/sepa/iban.py b/account_banking/sepa/iban.py index 92b6ed120..eba743475 100644 --- a/account_banking/sepa/iban.py +++ b/account_banking/sepa/iban.py @@ -198,7 +198,7 @@ class IBAN(str): 'CS': BBANFormat('BBBAAAAAAAAAAAAAVV', '%B-%A-%V'), 'CY': BBANFormat('BBBCCCCCAAAAAAAAAAAAAAAA', '%B%C%A'), 'CZ': BBANFormat('BBBBPPPPPPAAAAAAAAAA', '%B-%P/%A'), - 'DE': BBANFormat('BBBBBBBBAAAAAAAAAAV', '%A%V BLZ %B'), + 'DE': BBANFormat('BBBBBBBBAAAAAAAAAAV', '%A BLZ %B'), 'DK': BBANFormat('CCCCAAAAAAAAAV', '%C %A%V'), 'EE': BBANFormat('BBCCAAAAAAAAAAAV', '%A%V'), 'ES': BBANFormat('BBBBCCCCWVAAAAAAAAAA', '%B%C%W%V%A'), diff --git a/account_banking/wizard/bank_import.py b/account_banking/wizard/bank_import.py index cf297e001..72928d311 100644 --- a/account_banking/wizard/bank_import.py +++ b/account_banking/wizard/bank_import.py @@ -544,7 +544,7 @@ class banking_import(wizard.interface): statement_line_obj = self.pool.get('account.bank.statement.line') statement_file_obj = self.pool.get('account.banking.imported.file') #account_obj = self.pool.get('account.account') - #payment_order_obj = self.pool.get('payment.order') + payment_order_obj = self.pool.get('payment.order') currency_obj = self.pool.get('res.currency') # get the parser to parse the file diff --git a/account_banking_fi_patu/__terp__.py b/account_banking_fi_patu/__terp__.py index a57dec14d..af0d07270 100644 --- a/account_banking_fi_patu/__terp__.py +++ b/account_banking_fi_patu/__terp__.py @@ -26,7 +26,7 @@ ############################################################################## { 'name': 'Account Banking PATU module', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'Sami Haahtinen', 'website': 'http://ressukka.net', diff --git a/account_banking_nl_abnamro/__terp__.py b/account_banking_nl_abnamro/__terp__.py index 3b573468a..895fbe96d 100644 --- a/account_banking_nl_abnamro/__terp__.py +++ b/account_banking_nl_abnamro/__terp__.py @@ -27,7 +27,7 @@ ############################################################################## { 'name': 'abnamro (NL) Bank Statements Import', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'Therp BV / EduSense BV', 'website': 'https://launchpad.net/account-banking', diff --git a/account_banking_nl_clieop/__terp__.py b/account_banking_nl_clieop/__terp__.py index 8cecbf046..1e24c6e86 100644 --- a/account_banking_nl_clieop/__terp__.py +++ b/account_banking_nl_clieop/__terp__.py @@ -25,7 +25,7 @@ ############################################################################## { 'name': 'Account Banking NL ClieOp', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'EduSense BV', 'website': 'http://www.edusense.nl', diff --git a/account_banking_nl_girotel/__terp__.py b/account_banking_nl_girotel/__terp__.py index f28ba42ec..f6c8421ed 100644 --- a/account_banking_nl_girotel/__terp__.py +++ b/account_banking_nl_girotel/__terp__.py @@ -25,7 +25,7 @@ ############################################################################## { 'name': 'Account Banking - Girotel', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'EduSense BV', 'website': 'http://www.edusense.nl', diff --git a/account_banking_nl_multibank/__terp__.py b/account_banking_nl_multibank/__terp__.py index 1d43eb1f1..904c8cc3b 100644 --- a/account_banking_nl_multibank/__terp__.py +++ b/account_banking_nl_multibank/__terp__.py @@ -25,7 +25,7 @@ ############################################################################## { 'name': 'Account Banking', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'EduSense BV', 'website': 'http://www.edusense.nl', diff --git a/account_banking_nl_triodos/__terp__.py b/account_banking_nl_triodos/__terp__.py index ce3680d38..97401a7c5 100644 --- a/account_banking_nl_triodos/__terp__.py +++ b/account_banking_nl_triodos/__terp__.py @@ -27,7 +27,7 @@ ############################################################################## { 'name': 'Triodos (NL) Bank Statements Import', - 'version': '0.60', + 'version': '0.61', 'license': 'GPL-3', 'author': 'Therp BV / EduSense BV', 'website': 'https://launchpad.net/account-banking',