diff --git a/account_vendor_bank_account_default/README.rst b/account_vendor_bank_account_default/README.rst new file mode 100644 index 000000000..5736c9260 --- /dev/null +++ b/account_vendor_bank_account_default/README.rst @@ -0,0 +1,120 @@ +=================================== +Account Vendor Bank Account Default +=================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:446b86643c42066a7533bf64a0cf696042ce0e2d902183ec50d5f9d9c3e255ed + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fbank--payment-lightgray.png?logo=github + :target: https://github.com/OCA/bank-payment/tree/17.0/account_vendor_bank_account_default + :alt: OCA/bank-payment +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_vendor_bank_account_default + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/bank-payment&target_branch=17.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module allows you to set a default bank account on partners for +their vendor bills. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +To configure this module, you need to: + +- Go to a partner form view, and edit the Default Bank Account in the + Sales and Purchase tab. The partner must be of type 'company', or an + individual without a parent company. + + **Note:** If you do not set this value, it will be equal to the first + bank account created in the contact. This is the standard behaviour + of Odoo + +- You can disable the default bank account option at contact level, + unmarking the "Has Default Bank Account" check. + +Usage +===== + +To use this module, you need to: + +1. Create a vendor bill and select a partner with a default bank + account. Its recipient bank account will be the default one. + +Known issues / Roadmap +====================== + +- This module depends on account_payment_partner. If the payment mode + of the invoice has a payment method that does not require a bank + account, the default bank account will be empty. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Sygel + +Contributors +------------ + +- `Sygel `__: + + - Harald Panten + - Valentin Vinagre + - Alberto Martínez + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +.. |maintainer-tisho99| image:: https://github.com/tisho99.png?size=40px + :target: https://github.com/tisho99 + :alt: tisho99 + +Current `maintainer `__: + +|maintainer-tisho99| + +This module is part of the `OCA/bank-payment `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/account_vendor_bank_account_default/__init__.py b/account_vendor_bank_account_default/__init__.py new file mode 100644 index 000000000..31660d6a9 --- /dev/null +++ b/account_vendor_bank_account_default/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import models diff --git a/account_vendor_bank_account_default/__manifest__.py b/account_vendor_bank_account_default/__manifest__.py new file mode 100644 index 000000000..8e2a74552 --- /dev/null +++ b/account_vendor_bank_account_default/__manifest__.py @@ -0,0 +1,22 @@ +# Copyright 2024 Alberto Martínez +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +{ + "name": "Account Vendor Bank Account Default", + "summary": "Set a default bank account on partners for their vendor bills", + "version": "17.0.1.0.0", + "development_status": "Beta", + "category": "Banking addons", + "website": "https://github.com/OCA/bank-payment", + "author": "Sygel, Odoo Community Association (OCA)", + "maintainers": ["tisho99"], + "license": "AGPL-3", + "application": False, + "installable": True, + "depends": [ + "account", + "account_payment_partner", + ], + "data": [ + "views/res_partner_views.xml", + ], +} diff --git a/account_vendor_bank_account_default/models/__init__.py b/account_vendor_bank_account_default/models/__init__.py new file mode 100644 index 000000000..77f8c6e4f --- /dev/null +++ b/account_vendor_bank_account_default/models/__init__.py @@ -0,0 +1,4 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import account_move +from . import res_partner diff --git a/account_vendor_bank_account_default/models/account_move.py b/account_vendor_bank_account_default/models/account_move.py new file mode 100644 index 000000000..49d550a34 --- /dev/null +++ b/account_vendor_bank_account_default/models/account_move.py @@ -0,0 +1,25 @@ +# Copyright 2024 Alberto Martínez +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import models + + +class AccountMove(models.Model): + _inherit = "account.move" + + def _compute_partner_bank_id(self): + res = super()._compute_partner_bank_id() + for move in self: + payment_mode = move.payment_mode_id + if ( + payment_mode + and move.move_type == "in_invoice" + and payment_mode.payment_type == "outbound" + and payment_mode.payment_method_id.bank_account_required + ): + move.partner_bank_id = ( + move.bank_partner_id.default_bank_id + if move.bank_partner_id.has_default_bank_id + else False + ) + return res diff --git a/account_vendor_bank_account_default/models/res_partner.py b/account_vendor_bank_account_default/models/res_partner.py new file mode 100644 index 000000000..e06ca22a3 --- /dev/null +++ b/account_vendor_bank_account_default/models/res_partner.py @@ -0,0 +1,43 @@ +# Copyright 2024 Alberto Martínez +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import api, fields, models + + +class ResPartner(models.Model): + _inherit = "res.partner" + + default_bank_id = fields.Many2one( + string="Default Bank Account", + comodel_name="res.partner.bank", + domain="[('partner_id', '=', commercial_partner_id)]", + compute="_compute_default_bank_id", + inverse="_inverse_default_bank_id", + store=True, + readonly=False, + ) + user_default_bank_id = fields.Many2one( + comodel_name="res.partner.bank", + string="User Default Bank Account", + ) + has_default_bank_id = fields.Boolean( + string="Has Default Bank Account", + default=True, + ) + + @api.depends("bank_ids", "user_default_bank_id") + def _compute_default_bank_id(self): + for rec in self: + rec.default_bank_id = rec.user_default_bank_id or rec.bank_ids[:1] + + def _inverse_default_bank_id(self): + for rec in self: + rec.user_default_bank_id = rec.default_bank_id + if not rec.user_default_bank_id: + rec._compute_default_bank_id() + + @api.model + def _commercial_fields(self): + res = super()._commercial_fields() + res += ["default_bank_id", "user_default_bank_id", "has_default_bank_id"] + return res diff --git a/account_vendor_bank_account_default/pyproject.toml b/account_vendor_bank_account_default/pyproject.toml new file mode 100644 index 000000000..4231d0ccc --- /dev/null +++ b/account_vendor_bank_account_default/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/account_vendor_bank_account_default/readme/CONFIGURE.md b/account_vendor_bank_account_default/readme/CONFIGURE.md new file mode 100755 index 000000000..efbe8384d --- /dev/null +++ b/account_vendor_bank_account_default/readme/CONFIGURE.md @@ -0,0 +1,11 @@ +To configure this module, you need to: + +- Go to a partner form view, and edit the Default Bank Account in the + Sales and Purchase tab. The partner must be of type 'company', or an + individual without a parent company. + + **Note:** If you do not set this value, it will be equal to the first + bank account created in the contact. This is the standard behaviour of Odoo + +- You can disable the default bank account option at contact level, unmarking the + "Has Default Bank Account" check. diff --git a/account_vendor_bank_account_default/readme/CONTRIBUTORS.md b/account_vendor_bank_account_default/readme/CONTRIBUTORS.md new file mode 100755 index 000000000..e614fca54 --- /dev/null +++ b/account_vendor_bank_account_default/readme/CONTRIBUTORS.md @@ -0,0 +1,4 @@ +- [Sygel](https://www.sygel.es): + - Harald Panten + - Valentin Vinagre + - Alberto Martínez diff --git a/account_vendor_bank_account_default/readme/DESCRIPTION.md b/account_vendor_bank_account_default/readme/DESCRIPTION.md new file mode 100755 index 000000000..d0ea2ffe7 --- /dev/null +++ b/account_vendor_bank_account_default/readme/DESCRIPTION.md @@ -0,0 +1 @@ +This module allows you to set a default bank account on partners for their vendor bills. diff --git a/account_vendor_bank_account_default/readme/ROADMAP.md b/account_vendor_bank_account_default/readme/ROADMAP.md new file mode 100755 index 000000000..03c686549 --- /dev/null +++ b/account_vendor_bank_account_default/readme/ROADMAP.md @@ -0,0 +1 @@ +- This module depends on account_payment_partner. If the payment mode of the invoice has a payment method that does not require a bank account, the default bank account will be empty. diff --git a/account_vendor_bank_account_default/readme/USAGE.md b/account_vendor_bank_account_default/readme/USAGE.md new file mode 100755 index 000000000..d4f7919c1 --- /dev/null +++ b/account_vendor_bank_account_default/readme/USAGE.md @@ -0,0 +1,3 @@ +To use this module, you need to: + +1. Create a vendor bill and select a partner with a default bank account. Its recipient bank account will be the default one. diff --git a/account_vendor_bank_account_default/static/description/icon.png b/account_vendor_bank_account_default/static/description/icon.png new file mode 100755 index 000000000..3a0328b51 Binary files /dev/null and b/account_vendor_bank_account_default/static/description/icon.png differ diff --git a/account_vendor_bank_account_default/static/description/icon.svg b/account_vendor_bank_account_default/static/description/icon.svg new file mode 100755 index 000000000..a7a26d093 --- /dev/null +++ b/account_vendor_bank_account_default/static/description/icon.svg @@ -0,0 +1,79 @@ + + + + + + + + image/svg+xml + + + + + + + + + + + diff --git a/account_vendor_bank_account_default/static/description/index.html b/account_vendor_bank_account_default/static/description/index.html new file mode 100644 index 000000000..45a7a0ebf --- /dev/null +++ b/account_vendor_bank_account_default/static/description/index.html @@ -0,0 +1,466 @@ + + + + + +Account Vendor Bank Account Default + + + +
+

Account Vendor Bank Account Default

+ + +

Beta License: AGPL-3 OCA/bank-payment Translate me on Weblate Try me on Runboat

+

This module allows you to set a default bank account on partners for +their vendor bills.

+

Table of contents

+ +
+

Configuration

+

To configure this module, you need to:

+
    +

  • Go to a partner form view, and edit the Default Bank Account in the +Sales and Purchase tab. The partner must be of type ‘company’, or an +individual without a parent company.

    +

    Note: If you do not set this value, it will be equal to the first +bank account created in the contact. This is the standard behaviour +of Odoo

    +
    • +

  • You can disable the default bank account option at contact level, +unmarking the “Has Default Bank Account” check.

    +
    • +
+
+
+

Usage

+

To use this module, you need to:

+
    +
  1. Create a vendor bill and select a partner with a default bank +account. Its recipient bank account will be the default one.
    2. +
+
+
+

Known issues / Roadmap

+
    +
  • This module depends on account_payment_partner. If the payment mode +of the invoice has a payment method that does not require a bank +account, the default bank account will be empty.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Sygel
    • +
+
+
+

Contributors

+
    +
  • Sygel:
      +
    • Harald Panten
      • +
    • Valentin Vinagre
      • +
    • Alberto Martínez
      • +
    +
    • +
+
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

Current maintainer:

+

tisho99

+

This module is part of the OCA/bank-payment project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/account_vendor_bank_account_default/tests/__init__.py b/account_vendor_bank_account_default/tests/__init__.py new file mode 100644 index 000000000..252822289 --- /dev/null +++ b/account_vendor_bank_account_default/tests/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import test_account_vendor_bank_account_default diff --git a/account_vendor_bank_account_default/tests/test_account_vendor_bank_account_default.py b/account_vendor_bank_account_default/tests/test_account_vendor_bank_account_default.py new file mode 100644 index 000000000..720858aa0 --- /dev/null +++ b/account_vendor_bank_account_default/tests/test_account_vendor_bank_account_default.py @@ -0,0 +1,112 @@ +# Copyright 2024 Alberto Martínez +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +import datetime + +import odoo.tests + +from odoo.addons.account.tests.common import AccountTestInvoicingCommon + + +@odoo.tests.tagged("post_install", "-at_install") +class TestAccountVendorBankAccountDefault(AccountTestInvoicingCommon): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.bank_account1 = cls.env["res.partner.bank"].create( + { + "acc_number": "12341", + "partner_id": cls.partner_a.id, + } + ) + cls.bank_account2 = cls.env["res.partner.bank"].create( + { + "acc_number": "12342", + "partner_id": cls.partner_a.id, + } + ) + cls.bank_account3 = cls.env["res.partner.bank"].create( + { + "acc_number": "12343", + "partner_id": cls.partner_a.id, + } + ) + cls.manual_out = cls.env.ref("account.account_payment_method_manual_out") + cls.journal_c1 = ( + cls.env["account.journal"] + .sudo() + .create({"name": "J1", "code": "J1", "type": "bank"}) + ) + cls.supplier_payment_mode = ( + cls.env["account.payment.mode"] + .sudo() + .create( + { + "name": "Suppliers Bank 1", + "bank_account_link": "variable", + "payment_method_id": cls.manual_out.id, + "show_bank_account_from_journal": True, + "fixed_journal_id": cls.journal_c1.id, + "variable_journal_ids": [(6, 0, [cls.journal_c1.id])], + } + ) + ) + cls.partner_a.supplier_payment_mode_id = cls.supplier_payment_mode + + def create_in_invoice(self): + return self.env["account.move"].create( + { + "partner_id": self.partner_a.id, + "move_type": "in_invoice", + "invoice_date": datetime.date.today(), + } + ) + + def test_account_default_partner(self): + # Test that the default partner account can be pertmanently changed manually + self.assertNotEqual(self.partner_a.default_bank_id, self.bank_account2) + self.partner_a.default_bank_id = self.bank_account2 + self.assertEqual(self.partner_a.default_bank_id, self.bank_account2) + self.bank_account4 = self.env["res.partner.bank"].create( + { + "acc_number": "12344", + "partner_id": self.partner_a.id, + } + ) + self.assertEqual(self.partner_a.default_bank_id, self.bank_account2) + + def test_account_default_in_invoice(self): + # Test the default partner account in vendor bills + self.partner_a.default_bank_id = self.bank_account2 + self.supplier_payment_mode.payment_method_id.bank_account_required = True + in_invoice = self.create_in_invoice() + self.assertEqual(in_invoice.partner_bank_id, self.bank_account2) + + def test_no_account_default_in_vendor(self): + # Test no bank account on partner without default bank account + self.partner_a.has_default_bank_id = False + self.supplier_payment_mode.payment_method_id.bank_account_required = True + in_invoice = self.create_in_invoice() + self.assertFalse(in_invoice.partner_bank_id) + + def test_no_account_default_in_invoice(self): + # Test no bank account on moves without bank_account_required in payment mode + self.partner_a.default_bank_id = self.bank_account2 + self.supplier_payment_mode.payment_method_id.bank_account_required = False + in_invoice = self.create_in_invoice() + self.assertFalse(in_invoice.partner_bank_id) + + def test_no_payment_mode(self): + # Test no bank account if bank_account is not required in payment mode + self.partner_a.default_bank_id = self.bank_account2 + self.partner_a.supplier_payment_mode_id = False + in_invoice = self.create_in_invoice() + self.assertFalse(in_invoice.partner_bank_id) + + def test_commercial_fields(self): + # Test the default partner account in vendor bills with individual partner + # Test that the default partner account can be pertmanently changed manually + self.partner_a.default_bank_id = self.bank_account2 + self.supplier_payment_mode.payment_method_id.bank_account_required = True + in_invoice = self.create_in_invoice() + self.assertEqual(in_invoice.partner_bank_id, self.bank_account2) diff --git a/account_vendor_bank_account_default/views/res_partner_views.xml b/account_vendor_bank_account_default/views/res_partner_views.xml new file mode 100644 index 000000000..a47578fcc --- /dev/null +++ b/account_vendor_bank_account_default/views/res_partner_views.xml @@ -0,0 +1,24 @@ + + + + + + res.partner.form + res.partner + + + + + + + + + +