From 2b95506d723cabc6b6a62fec0cae4ca6e3d2f5ed Mon Sep 17 00:00:00 2001 From: Alexis de Lattre Date: Mon, 23 May 2016 10:42:28 +0200 Subject: [PATCH] Take into accounts the remarks of Eric Caudal --- account_payment_order/README.rst | 31 +++++------------------- account_payment_order/models/res_bank.py | 4 +-- 2 files changed, 8 insertions(+), 27 deletions(-) diff --git a/account_payment_order/README.rst b/account_payment_order/README.rst index 291febbc1..b752fee40 100644 --- a/account_payment_order/README.rst +++ b/account_payment_order/README.rst @@ -1,27 +1,11 @@ .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg :alt: License: AGPL-3 -Account Banking - Payments Export Infrastructure -================================================ +===================== +Account Payment Order +===================== -This module provide an infrastructure to export payment orders. -It includes some bug fixes and obvious enhancements to payment orders that will hopefully land in offical addons one -day. -This technical module provides the base infrastructure to export payment orders -for electronic banking. It provides the following technical features: - -* a new payment.mode.type model -* payment.mode now has a mandatory type -* a better implementation of payment_mode.suitable_bank_types() based on - payment.mode.type -* the "make payment" button launches a wizard depending on the - payment.mode.type -* a manual payment mode type is provided as an example, with a default "do - nothing" wizard - -To enable the use of payment order to collect money for customers, -it adds a payment_order_type (payment|debit) as a basis of direct debit support -(this field becomes visible when account_direct_debit is installed). +This module adds support for payment orders and debit orders. Installation ============ @@ -30,6 +14,7 @@ This module depends on: * account_payment_partner * base_iban +* document This modules is part of the OCA/bank-payment suite. @@ -62,11 +47,7 @@ Bug Tracker Bugs are tracked on `GitHub Issues `_. In case of trouble, please check there if your issue has already been reported. If you spotted it first, -help us smashing it by providing a detailed and welcomed `feedback -`_. +help us smashing it by providing a detailed and welcomed feedback. Credits ======= diff --git a/account_payment_order/models/res_bank.py b/account_payment_order/models/res_bank.py index fa927bbd1..44dd6ecdb 100644 --- a/account_payment_order/models/res_bank.py +++ b/account_payment_order/models/res_bank.py @@ -15,8 +15,8 @@ class ResBank(models.Model): for bank in self: if bank.bic and len(bank.bic) not in (8, 11): raise ValidationError(_( - "A valid BIC contains 8 or 11 caracters. The BIC '%s' " - "contains %d caracters, so it is not valid.") + "A valid BIC contains 8 or 11 characters. The BIC '%s' " + "contains %d characters, so it is not valid.") % (bank.bic, len(bank.bic))) # in v9, on res.partner.bank bank_bic is a related of bank_id.bic