From 232b17b423d35c6affa5d628d7321c46555f8acd Mon Sep 17 00:00:00 2001
From: Valentin Vinagre Urteaga <valentin.vinagre@sygel.es>
Date: Wed, 22 Apr 2020 16:44:00 +0200
Subject: [PATCH] [FIX] account_payment_order: fix set partner_bank_id in
 account move lines Case: The bank account isn't set properly in the payment
 order lines, because the bank account is only got from account.move.line or
 the first bank account in the partner_id, but never from the invoice
 (account.move).

Solution:
With this fix, the bank account will be get from account.move when matching the criteria.
---
 .../models/account_move_line.py               | 22 ++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/account_payment_order/models/account_move_line.py b/account_payment_order/models/account_move_line.py
index e444ba2f7..2326d9bfe 100644
--- a/account_payment_order/models/account_move_line.py
+++ b/account_payment_order/models/account_move_line.py
@@ -2,7 +2,7 @@
 # © 2014 Serv. Tecnol. Avanzados - Pedro M. Baeza
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
-from odoo import fields, models
+from odoo import api, fields, models
 from odoo.fields import first
 
 
@@ -12,6 +12,9 @@ class AccountMoveLine(models.Model):
     partner_bank_id = fields.Many2one(
         comodel_name="res.partner.bank",
         string="Partner Bank Account",
+        compute="_compute_partner_bank_id",
+        readonly=False,
+        store=True,
         help="Bank account on which we should pay the supplier",
     )
     bank_payment_line_id = fields.Many2one(
@@ -23,6 +26,23 @@ class AccountMoveLine(models.Model):
         string="Payment lines",
     )
 
+    @api.depends(
+        "move_id", "move_id.invoice_partner_bank_id", "move_id.payment_mode_id"
+    )
+    def _compute_partner_bank_id(self):
+        for ml in self:
+            if (
+                ml.move_id.type in ("in_invoice", "in_refund")
+                and not ml.reconciled
+                and ml.payment_mode_id.payment_order_ok
+                and ml.account_id.internal_type in ("receivable", "payable")
+                and not any(
+                    p_state in ("draft", "open", "generated")
+                    for p_state in ml.payment_line_ids.mapped("state")
+                )
+            ):
+                ml.partner_bank_id = ml.move_id.invoice_partner_bank_id.id
+
     def _prepare_payment_line_vals(self, payment_order):
         self.ensure_one()
         assert payment_order, "Missing payment order"