audrius/bank-payment
1
0
Fork 1
mirror of https://github.com/OCA/bank-payment.git synced 2025-02-02 10:37:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

[RFR] Don't repeat assignment within loop

Browse Source
This commit is contained in:
Stefan Rijnhart
2013-10-06 20:55:54 +02:00
parent 74b96a834b
commit 1eec20504c
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
account_bank_statement_tax/model/account_bank_statement.py
View File

@@ -66,11 +66,6 @@ class AccountBankStatement(orm.Model):
update_move_line['tax_code_id'] = tax['base_code_id'] update_move_line['tax_code_id'] = tax['base_code_id']
update_move_line['tax_amount'] = tax['base_sign'] * ( update_move_line['tax_amount'] = tax['base_sign'] * (
computed_taxes.get('total', 0.0)) computed_taxes.get('total', 0.0))
# As the tax is inclusive, we need to correct the amount on the
# original move line
amount = computed_taxes.get('total', 0.0)
update_move_line['credit'] = ((amount < 0) and -amount) or 0.0
update_move_line['debit'] = ((amount > 0) and amount) or 0.0
move_lines.append({ move_lines.append({
'move_id': defaults['move_id'], 'move_id': defaults['move_id'],
@@ -87,6 +82,13 @@ class AccountBankStatement(orm.Model):
'account_id': tax.get('account_collected_id', defaults['account_id']), 'account_id': tax.get('account_collected_id', defaults['account_id']),
}) })
if move_lines:
# As the tax is inclusive, we need to correct the amount on the
# original move line
amount = computed_taxes.get('total', 0.0)
update_move_line['credit'] = ((amount < 0) and -amount) or 0.0
update_move_line['debit'] = ((amount > 0) and amount) or 0.0
return move_lines, update_move_line return move_lines, update_move_line
def _prepare_bank_move_line( def _prepare_bank_move_line(