From 018375d4f0931b4b9ae67ad602a0458407a3fe67 Mon Sep 17 00:00:00 2001 From: Alexis de Lattre Date: Wed, 10 Aug 2022 20:54:09 +0200 Subject: [PATCH] [FIX] account_payment_order: fix action returned by create_account_payment_line() create_account_payment_line() is supposed to returned a form view for a single payment order and a tree view for multiple payment orders. Before this fix, it would return a tree view if you were payment more than 1 invoices while generating a single payment order, because the list result_payorder_ids would contain several time the same ID. --- account_payment_order/__manifest__.py | 2 +- account_payment_order/models/account_move.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/account_payment_order/__manifest__.py b/account_payment_order/__manifest__.py index ffdc046c5..9a16d3f96 100644 --- a/account_payment_order/__manifest__.py +++ b/account_payment_order/__manifest__.py @@ -9,7 +9,7 @@ { "name": "Account Payment Order", - "version": "15.0.1.0.3", + "version": "15.0.1.0.4", "license": "AGPL-3", "author": "ACSONE SA/NV, " "Therp BV, " diff --git a/account_payment_order/models/account_move.py b/account_payment_order/models/account_move.py index cac14564d..917cb9d1e 100644 --- a/account_payment_order/models/account_move.py +++ b/account_payment_order/models/account_move.py @@ -52,7 +52,7 @@ class AccountMove(models.Model): def create_account_payment_line(self): apoo = self.env["account.payment.order"] - result_payorder_ids = [] + result_payorder_ids = set() action_payment_type = "debit" for move in self: if move.state != "posted": @@ -90,7 +90,7 @@ class AccountMove(models.Model): move._prepare_new_payment_order(payment_mode) ) new_payorder = True - result_payorder_ids.append(payorder.id) + result_payorder_ids.add(payorder.id) action_payment_type = payorder.payment_type count = 0 for line in applicable_lines.filtered(