Commit Graph

26 Commits

Author SHA1 Message Date
Giedrius Slavinskas
2601bf53e2 [FIX] account_reconciliation_widget: Show correct currency
When reconciling bank statement lines in a foreign currency,
it shows amounts in a company's currency while the symbol
is shown of foreign currency. Wrong currency appears on counterpart
lines and open balance line.

The wrong currency symbol only effects representation in the UI.
When reconciliation is validated, it sets company's currency on
account move lines.
2023-06-23 20:40:28 +03:00
Pedro M. Baeza
f78f1f4a57 [IMP] account_reconciliation_widget: Skip business models synchronization on reconcile
There's no need to synchronize business models (payments and statement
lines) when the reconcile is done, as the only value written in
the journal item is `full_reconcile_id`.

This way, we speed up the reconciliation process through the widget.
2023-06-17 08:33:11 +02:00
OCA-git-bot
840bb62dd8 Merge PR #531 into 15.0
Signed-off-by pedrobaeza
2023-06-03 09:36:24 +00:00
Pedro M. Baeza
f86c137e1e [FIX] account_reconciliation_widget: Hide own reconcilable items
If the journal destination account is reconcilable, as the journal entry
is pre-generated before reconciling, the line is appearing in the
reconciliation widget, provoking user confusion and error if that one
is selected.

We explicitly exclude in the matching domain for avoiding the problem.

TT42983
2023-05-31 16:52:02 +02:00
Pedro M. Baeza
2e961e1d64 [FIX] account_reconciliation_widget: Multiple blue lines
In case of multiple blue lines, the code was not working properly, as
the old temporary journal entry was being deleted several times.

This situation is handled in this commit.
2023-05-16 14:47:31 +02:00
Pedro M. Baeza
48413f0188 [FIX] account_reconciliation_widget: Handle blue lines
When coming from previous versions of Odoo, you may have payments
directly done against the bank account. On the reconciliation widget,
they are represented as blue lines.

One possibility is to replace in all these pending entries the bank
account by the outstanding payment/receipt account, but this means to
modify past accounting that may be locked.

So this commit is restoring the ability to reconcile against these blue
lines, although this is a deprecated thing.

Things done:

- Repair the JS widget for informing correctly about the blue lines
  to reconcile.
- When having such lines to reconcile, the temporary statement line is
  removed, and the payment one is linked.
- When reverting reconciliation of the statement lines linked to
  payments, the entry is not removed, just removed the link, and a new
  entry is created for the statement line.

TT43018
2023-05-11 18:37:24 +02:00
singwangho
7313df9b6a handle legacy case where st_line.currency_id is used as foreign currency 2023-03-16 16:07:22 +00:00
singwangho
9735b0c8e9 add basic support for statement line foreign currency 2023-03-03 06:51:08 +00:00
Jon Erik Ceberio
8a364674a4 [FIX] account_reconciliation_widget: in case of manual operation with analytic account/tags, create the analytic entry(ies) if the move is posted 2023-02-09 17:09:50 +01:00
Pedro M. Baeza
b44d9d49a3 [FIX] account_reconciliation_widget: Non existing field
It should be `partner_bank_id`.

Fixes #468
2022-05-28 14:13:56 +02:00
Miquel Raïch
5ca58418ec [FIX] account_reconciliation_widget: set statement name to move ref 2022-05-18 13:27:49 +02:00
Pedro M. Baeza
f343ccfa3c [FIX] account_reconciliation_widget: Don't suggest non posted moves
Fixes #429
2022-04-14 17:11:23 +02:00
Pedro M. Baeza
7c98fd89fa [IMP] account_reconcile_widget: Allow to reconcile payment/debit orders from OCA/bank-payment
Payments without payment_id related aren't showed in statement
reconciliation.

With this change, we show them as blue lines, the same as other coming
from Odoo core payments.

TT34508
2022-03-11 07:37:38 +01:00
kelvzxu
7f6d1a2ec6 [15.0][MIG] account_reconciliation_widget:Migration to 15.0 2022-02-02 22:44:06 +07:00
kelvzxu
842508fb86 [IMP] account_reconciliation_widget: black, isort, prettier 2022-02-02 22:44:06 +07:00
clementmbr
1597e6f65e [FIX] account_reconciliation_widget: better SQL request 2022-01-26 16:33:17 +07:00
Téo Goddet
62cd65ca8f Fix foreign_currency_id vs currency_id on statement
Fix 13 to 14 migration
2022-01-26 16:33:17 +07:00
Jairo Llopis
33d4223818 [IMP] account_reconciliation_widget: reduce heavy queries count
This specific query is quite expensive, and what's worse, it's also done twice: once to count records and once to get them.

By using a window function, we can get the count and results in one query, thus almost doubling performance in this operation.

Related resources:

- [Explanation](https://stackoverflow.com/a/22353886/1468388).
- [Explain of the 1st SELECT COUNT(*), before the patch](https://explain.dalibo.com/plan/TgL).
- [Explain of the 2nd SELECT, before the patch](https://explain.dalibo.com/plan/Yc9).
- [Explain of the new, unified SELECT, after the patch](https://explain.dalibo.com/plan/9MA).

@Tecnativa TT28595 TT29916 https://github.com/odoo/odoo/pull/73765
2022-01-26 16:33:17 +07:00
Florian da Costa
13f4a8d63d [FIX] prefill partner in reconciliation widget if it has been match by a reconciliation rule 2022-01-26 16:33:17 +07:00
Francisco Ivan Anton Prieto
446415c936 [14.0][FIX] account_reconciliation_widget: error checking res.partner.bank on account.bank.statement.line
bank_account_id is now partner_bank_id on account.bank.statement.line (inheriting from move)
2022-01-26 16:33:17 +07:00
Francisco Ivan Anton Prieto
d84eb3dbfe [14.0][FIX] account_reconciliation_widget: already posted move issue on reconcile
A new mod in Odoo base code disallows re-post an already posted move. This thing blocks reconciling and this commit fixes it.
2022-01-26 16:33:17 +07:00
Alexis de Lattre
6000982a57 account_reconciliation_widget: note -> narration on bank statement lines 2022-01-26 16:33:17 +07:00
Alexis de Lattre
d5b4cbe393 account_reconciliation_widget: Use payment_ref for the statement line label 2022-01-26 16:33:17 +07:00
Francisco Ivan Anton Prieto
a8efc5d52d [FIX] account_reconciliation_widget: dict refactoring / typo fix 2022-01-26 16:33:17 +07:00
Francisco Ivan Anton Prieto
231ddf9913 [ADD] account_reconciliation_widget: first working alpha 2022-01-26 16:33:17 +07:00
Odoo
509c1573df [ADD] account_reconciliation_widget: Base module code extracted from Odoo 13.0 2022-01-26 16:33:17 +07:00