[FIX] improve code quality

This commit is contained in:
Laurent Mignon
2014-08-04 15:32:34 +02:00
committed by Laurent Mignon (aka lmi)
parent 7cafa70ab6
commit f34f3fbbd6

View File

@@ -54,9 +54,9 @@ class AccountStatementCompletionRule(Model):
partner_acc_number = st_line['partner_acc_number'] partner_acc_number = st_line['partner_acc_number']
if not partner_acc_number: if not partner_acc_number:
return {} return {}
st_obj = self.pool.get('account.bank.statement.line') st_obj = self.pool['account.bank.statement.line']
res = {} res = {}
res_bank_obj = self.pool.get('res.partner.bank') res_bank_obj = self.pool['res.partner.bank']
ids = res_bank_obj.search_by_acc_number(cr, ids = res_bank_obj.search_by_acc_number(cr,
uid, uid,
partner_acc_number, partner_acc_number,
@@ -74,19 +74,13 @@ class AccountStatementCompletionRule(Model):
ids[0], ids[0],
context=context).partner_id context=context).partner_id
res['partner_id'] = partner.id res['partner_id'] = partner.id
profile_id = st_line['profile_id'] st_vals = st_obj.get_values_for_line(
m_acc_id = st_line['master_account_id'] cr, uid, profile_id=st_line['profile_id'],
partner_id = res.get('partner_id', False) master_account_id=st_line['master_account_id'],
line_type = st_line['type'] partner_id=res.get('partner_id', False),
amout = st_line['amount'] if st_line['amount'] else 0.0 line_type=st_line['type'],
st_vals = st_obj.get_values_for_line(cr, amount=st_line['amount'] if st_line['amount'] else 0.0,
uid, context=context)
profile_id=profile_id,
master_account_id=m_acc_id,
partner_id=partner_id,
line_type=line_type,
amount=amout,
context=context)
res.update(st_vals) res.update(st_vals)
return res return res
@@ -95,8 +89,6 @@ class AccountStatementLine(Model):
_inherit = "account.bank.statement.line" _inherit = "account.bank.statement.line"
_columns = { _columns = {
# 'additional_bank_fields' : fields.serialized('Additional infos from
# bank', help="Used by completion and import system."),
'partner_acc_number': fields.sparse( 'partner_acc_number': fields.sparse(
type='char', type='char',
string='Account Number', string='Account Number',