audrius/account-reconcile
1
0
Fork 1
mirror of https://github.com/OCA/account-reconcile.git synced 2025-01-20 12:27:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[fix] duplicate moves when confirming a statement with a confirmed line

Browse Source 
Add a test to expose the bug.
To reproduce: create a statement with two lines, confirm one, and then confirm
the whole statement. The first line has two associated moves.
This commit is contained in:
Leonardo Pistone
2014-06-13 12:04:16 +02:00
parent eaa1e8605f
commit e972437765
3 changed files with 93 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
account_statement_cancel_line/statement.py
View File

@@ -35,15 +35,29 @@ class Statement(orm.Model):
_inherit = "account.bank.statement"
def button_confirm_bank(self, cr, uid, ids, context=None):
"""Change the state on the statement lines. Return super."""
st_line_obj = self.pool['account.bank.statement.line']
for st_data in self.read(cr, uid, ids, ['line_ids'], context=context):
st_line_obj.write(cr, uid, st_data['line_ids'], {
'state': 'confirmed'
}, context=context)
"""If all lines are draft, change their state.
Otherwise, confirm line by line to avoid duplicate moves.
Return super.
return super(Statement, self).button_confirm_bank(
cr, uid, ids, context)
"""
st_line_obj = self.pool['account.bank.statement.line']
statement_ids_fully_confirm = []
for st in self.browse(cr, uid, ids, context=context):
if all(l.state == 'draft' for l in st.line_ids):
statement_ids_fully_confirm.append(st.id)
st_line_obj.write(cr, uid, [l.id for l in st.line_ids], {
'state': 'confirmed'
}, context=context)
else:
st_line_obj.confirm(cr, uid, [l.id for l in st.line_ids],
context=context)
if statement_ids_fully_confirm:
return super(Statement, self).button_confirm_bank(
cr, uid, statement_ids_fully_confirm, context)
else:
return True
def button_cancel(self, cr, uid, ids, context=None):
"""Check if there is any reconciliation. Return action."""