From 5fa89db115f0a7b8399d11fddb26856eeae16993 Mon Sep 17 00:00:00 2001 From: ecino Date: Wed, 29 Oct 2014 15:45:12 +0100 Subject: [PATCH 1/3] [FIX] If balance_start is set by parser and equals 0.0, don't override it with default value --- account_statement_base_import/statement.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account_statement_base_import/statement.py b/account_statement_base_import/statement.py index f8301e1b..2c9b1212 100644 --- a/account_statement_base_import/statement.py +++ b/account_statement_base_import/statement.py @@ -135,7 +135,7 @@ class AccountStatementProfil(orm.Model): """ vals = {'profile_id': profile_id} vals.update(parser.get_st_vals()) - if not vals.get('balance_start'): + if 'balance_start' not in vals.keys(): # Get starting balance from journal balance if parser doesn't # fill this data, simulating the manual flow statement_obj = self.pool['account.bank.statement'] From bf9d9fd2a94d146856a772ef6a3d2a8c417f8a23 Mon Sep 17 00:00:00 2001 From: ecino Date: Wed, 29 Oct 2014 16:19:18 +0100 Subject: [PATCH 2/3] Code style improvement --- account_statement_base_import/statement.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account_statement_base_import/statement.py b/account_statement_base_import/statement.py index 2c9b1212..19671ee1 100644 --- a/account_statement_base_import/statement.py +++ b/account_statement_base_import/statement.py @@ -135,7 +135,7 @@ class AccountStatementProfil(orm.Model): """ vals = {'profile_id': profile_id} vals.update(parser.get_st_vals()) - if 'balance_start' not in vals.keys(): + if 'balance_start' not in vals: # Get starting balance from journal balance if parser doesn't # fill this data, simulating the manual flow statement_obj = self.pool['account.bank.statement'] From 5209acc765dc5f5476412cbf6db982082630382c Mon Sep 17 00:00:00 2001 From: ecino Date: Thu, 30 Oct 2014 07:48:33 +0100 Subject: [PATCH 3/3] Adapt to the fact that the parser always return something for balance_start. --- account_statement_base_import/statement.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account_statement_base_import/statement.py b/account_statement_base_import/statement.py index 19671ee1..c87013b0 100644 --- a/account_statement_base_import/statement.py +++ b/account_statement_base_import/statement.py @@ -135,7 +135,7 @@ class AccountStatementProfil(orm.Model): """ vals = {'profile_id': profile_id} vals.update(parser.get_st_vals()) - if 'balance_start' not in vals: + if vals.get('balance_start') is None: # Get starting balance from journal balance if parser doesn't # fill this data, simulating the manual flow statement_obj = self.pool['account.bank.statement']