From adee24d769bc047adb878a636b9a900cf3fa443b Mon Sep 17 00:00:00 2001
From: Jordi Ballester Alomar <jordi.ballester@eficent.com>
Date: Fri, 26 Oct 2018 12:07:09 +0200
Subject: [PATCH] [9.0][imp][account_mass_reconcile] search for unreconciled
 entries using a search default method, instead of a domain. Fixes memory
 errors.

---
 account_mass_reconcile/models/mass_reconcile.py | 14 +++++++-------
 account_mass_reconcile/tests/test_reconcile.py  |  9 +++++++--
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/account_mass_reconcile/models/mass_reconcile.py b/account_mass_reconcile/models/mass_reconcile.py
index 6822df8e..c274748c 100644
--- a/account_mass_reconcile/models/mass_reconcile.py
+++ b/account_mass_reconcile/models/mass_reconcile.py
@@ -251,7 +251,7 @@ class AccountMassReconcile(models.Model):
         )
 
     @api.model
-    def _open_move_line_list(self, move_line_ids, name):
+    def _open_move_line_list(self, context, name):
         return {
             'name': name,
             'view_mode': 'tree,form',
@@ -261,19 +261,19 @@ class AccountMassReconcile(models.Model):
             'type': 'ir.actions.act_window',
             'nodestroy': True,
             'target': 'current',
-            'domain': unicode([('id', 'in', move_line_ids)]),
+            'context': context,
         }
 
     @api.multi
     def open_unreconcile(self):
         """ Open the view of move line with the unreconciled move lines"""
         self.ensure_one()
-        obj_move_line = self.env['account.move.line']
-        lines = obj_move_line.search(
-            [('account_id', '=', self.account.id),
-             ('reconciled', '=', False)])
+        context = {
+            'search_default_account_id': self.account.id,
+            'search_default_unreconciled': True
+        }
         name = _('Unreconciled items')
-        return self._open_move_line_list(lines.ids or [], name)
+        return self._open_move_line_list(context, name)
 
     @api.multi
     def last_history_reconcile(self):
diff --git a/account_mass_reconcile/tests/test_reconcile.py b/account_mass_reconcile/tests/test_reconcile.py
index b7697bed..60df0371 100644
--- a/account_mass_reconcile/tests/test_reconcile.py
+++ b/account_mass_reconcile/tests/test_reconcile.py
@@ -15,6 +15,7 @@ class TestReconcile(common.TransactionCase):
                            get_module_resource('account', 'test',
                                                'account_minimal_test.xml'),
                            {}, 'init', False, 'test')
+        self.reconcile_account_id = self.ref('account.a_salary_expense')
         self.rec_history_obj = self.env['mass.reconcile.history']
         self.mass_rec_obj = self.env['account.mass.reconcile']
         self.mass_rec_method_obj = (
@@ -23,7 +24,7 @@ class TestReconcile(common.TransactionCase):
         self.mass_rec = self.mass_rec_obj.create(
             {
                 'name': 'AER2',
-                'account': self.ref('account.a_salary_expense'),
+                'account': self.reconcile_account_id,
             }
             )
         self.mass_rec_method = self.mass_rec_method_obj.create(
@@ -61,7 +62,11 @@ class TestReconcile(common.TransactionCase):
 
     def test_open_unreconcile(self):
         res = self.mass_rec.open_unreconcile()
-        self.assertEqual(unicode([('id', 'in', [])]), res.get('domain', []))
+        context = {
+            'search_default_account_id': self.reconcile_account_id,
+            'search_default_unreconciled': True
+        }
+        self.assertEqual(context, res.get('context', {}))
 
     def test_prepare_run_transient(self):
         res = self.mass_rec._prepare_run_transient(self.mass_rec_method)