audrius/account-reconcile
1
0
Fork 1
mirror of https://github.com/OCA/account-reconcile.git synced 2025-01-20 12:27:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX]account_reconcile_widget: value cleaning & decimal separator choice

Browse Source 
When decimal separator is a dot, it has a special meaning in the regex (any character) that cause problem
For instance in 123.40 the regex will match .4 and remove it.
And then the proposal will be base on the number 120 instead of 123.40

The other problem with the actual regex is that minus sign get removed

In the fix, we start by replacing the decimal_separator by a dot (before it was done after the cleaning) and the clean with a character class that is clearly specified (dot, minus, numbers)

Bug was already present in odoo13 EE and CE
This commit is contained in:
Téo Goddet
2021-10-30 16:38:26 +02:00
committed by Téo Goddet
parent 3f109516f5
commit 7323e8d233
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
account_reconciliation_widget/static/src/js/reconciliation/reconciliation_model.js
View File

@@ -1603,7 +1603,10 @@ odoo.define("account.ReconciliationModel", function (require) {
);
if (matching && matching.length == 2) {
matching = matching[1].replace(
new RegExp("\\D" + reconcileModel.decimal_separator, "g"),
new RegExp(
"[^-d" + reconcileModel.decimal_separator + "]",
"g"
),
""
);
matching = matching.replace(