audrius/account-reconcile
1
0
Fork 1
mirror of https://github.com/OCA/account-reconcile.git synced 2025-01-20 12:27:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use float comparisons

Browse Source
This commit is contained in:
Guewen Baconnier
2014-11-26 09:59:41 +01:00
parent a87fdeb50a
commit 630e995ae8
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
account_statement_operation_rule/model/account_statement_operation_rule.py
View File

@@ -55,8 +55,14 @@ class AccountStatementOperationRule(models.Model):
@api.multi
def _is_valid_balance(self, statement_line, move_lines, balance):
# TODO use float compare
return self.amount_min <= balance <= self.amount_max
currency = (statement_line.currency_id or
statement_line.statement_id.currency)
# FIXME: is_valid_balance must not work with multicurrency
if currency.compare_amounts(balance, self.amount_min) == -1:
return False
if currency.compare_amounts(balance, self.amount_max) == 1:
return False
return True
@api.multi
def _is_valid_multicurrency(self, statement_line, move_lines, balance):
@@ -74,6 +80,7 @@ class AccountStatementOperationRule(models.Model):
# amount in currency is the same, so the balance is
# a difference due to currency rates
if statement_line.currency_id.is_zero(amount_currency):
# FIXME: is_valid_balance must not work with multicurrency
return self._is_valid_balance(statement_line, move_lines, balance)
return False
@@ -113,8 +120,10 @@ class AccountStatementOperationRule(models.Model):
balance = statement_line.amount
for move_line in move_lines:
balance += move_line.credit - move_line.debit
# TODO use is_zero
if not balance:
currency = (statement_line.currency_id or
statement_line.statement_id.currency)
if currency.is_zero(balance):
return self.browse()
rules = self.search([])