From 98323e23428a0543802cc216ce92787ff74675f0 Mon Sep 17 00:00:00 2001 From: Sebastien Beau Date: Wed, 4 Dec 2013 17:10:32 +0100 Subject: [PATCH 1/2] [IMP] do not recatch error in debug mode --- account_statement_base_import/statement.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/account_statement_base_import/statement.py b/account_statement_base_import/statement.py index 97e8e8ab..3964d77c 100644 --- a/account_statement_base_import/statement.py +++ b/account_statement_base_import/statement.py @@ -26,6 +26,7 @@ import datetime from openerp.osv.orm import Model from openerp.osv import fields, osv from parser import new_bank_statement_parser +from openerp.tools.config import config class AccountStatementProfil(Model): @@ -211,6 +212,8 @@ class AccountStatementProfil(Model): error_type, error_value, trbk = sys.exc_info() st = "Error: %s\nDescription: %s\nTraceback:" % (error_type.__name__, error_value) st += ''.join(traceback.format_tb(trbk, 30)) + if config['debug_mode']: + raise raise osv.except_osv(_("Statement import error"), _("The statement cannot be created: %s") % st) return statement_id From da6c89f9dc603f66e1d275582f4803a186c59c18 Mon Sep 17 00:00:00 2001 From: Sebastien Beau Date: Mon, 24 Feb 2014 14:05:38 +0100 Subject: [PATCH 2/2] [REF] add TODO comment for using python exception --- account_statement_base_import/statement.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/account_statement_base_import/statement.py b/account_statement_base_import/statement.py index 3964d77c..e8cc6596 100644 --- a/account_statement_base_import/statement.py +++ b/account_statement_base_import/statement.py @@ -212,6 +212,9 @@ class AccountStatementProfil(Model): error_type, error_value, trbk = sys.exc_info() st = "Error: %s\nDescription: %s\nTraceback:" % (error_type.__name__, error_value) st += ''.join(traceback.format_tb(trbk, 30)) + #TODO we should catch correctly the exception with a python + #Exception and only re-catch some special exception. + #For now we avoid re-catching error in debug mode if config['debug_mode']: raise raise osv.except_osv(_("Statement import error"),