-
-
- ## date
-
${_('Reference')}
- ## period
-
${_('Partenaire')}
- ## move
-
${_('Montant')}
- ## journal
-
-
- <% sum_statement = 0.0 %>
- %for statementline in statement.line_ids:
-
- ## curency code
-
${statementline.name or '' }
- ## currency balance
-
${statementline.partner_id.name or '' }
- ## currency balance cumulated
-
${formatLang(statementline.amount) | amount }
- <% sum_statement += statementline.amount %>
-
- %endfor
-
- ## curency code
-
- ## currency balance
-
Total
- ## currency balance cumulated
-
${formatLang(sum_statement) }
+
+
+
+
+ ## date
+
${_('Reference')}
+ ## period
+
${_('Partenaire')}
+ ## move
+
${_('Montant')}
+ ## journal
+
+ <% sum_statement = 0.0 %>
+ %for statementline in statement.line_ids:
+
+ ## curency code
+
${statementline.name or '' }
+ ## currency balance
+
${statementline.partner_id.name or '' }
+ ## currency balance cumulated
+
${formatLang(statementline.amount) | amount }
+ <% sum_statement += statementline.amount %>
+
+ %endfor
+
+ ## curency code
+
+ ## currency balance
+
Total
+ ## currency balance cumulated
+
${formatLang(sum_statement) }
+
+
+
+ %endfor
-
- %endfor
-
diff --git a/account_statement_ext/report/bank_statement_report.py b/account_statement_ext/report/bank_statement_report.py
index 19ba2efe..a06c1d9a 100644
--- a/account_statement_ext/report/bank_statement_report.py
+++ b/account_statement_ext/report/bank_statement_report.py
@@ -27,6 +27,8 @@ import pooler
from operator import add, itemgetter
from itertools import groupby
from datetime import datetime
+
+#from common_report_header_webkit import CommonReportHeaderWebkit
from report_webkit import webkit_report
class BankStatementWebkit(report_sxw.rml_parse):
@@ -64,7 +66,7 @@ class BankStatementWebkit(report_sxw.rml_parse):
statement_lines = statement_obj.browse(self.cr,self.uid,statement_line_ids)
return statement_lines
-webkit_report.WebKitParser('report.bank_statement_webkit',
+webkit_report.WebKitParser('report.report_bank_statement_webkit',
'account.bank.statement',
- 'addons/account_statement_ext/report/bank_statement_report.mako',
+ 'addons/account_statement_import/report/bank_statement_report.mako',
parser=BankStatementWebkit)
diff --git a/account_statement_ext/security/ir.model.access.csv b/account_statement_ext/security/ir.model.access.csv
deleted file mode 100644
index 8164447d..00000000
--- a/account_statement_ext/security/ir.model.access.csv
+++ /dev/null
@@ -1,3 +0,0 @@
-id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_account_bank_st_profile_user,account.statement.profil,model_account_statement_profil,account.group_account_user,1,0,0,0
-access_account_bank_st_profile_manager,account.statement.profil,model_account_statement_profil,account.group_account_manager,1,1,1,1
diff --git a/account_statement_ext/statement.py b/account_statement_ext/statement.py
index b35ebc95..5fba0b19 100644
--- a/account_statement_ext/statement.py
+++ b/account_statement_ext/statement.py
@@ -20,28 +20,22 @@
##############################################################################
from tools.translate import _
+from account_statement_ext.file_parser.parser import FileParser
import datetime
import netsvc
logger = netsvc.Logger()
from openerp.osv.orm import Model, fields
-from openerp.osv import fields, osv
class AccountStatementProfil(Model):
- """
- A Profile will contain all infos related to the type of
- bank statement, and related generated entries. It defines the
- journal to use, the partner and commision account and so on.
- """
_name = "account.statement.profil"
_description = "Statement Profil"
_columns = {
'name': fields.char('Name', size=128, required=True),
'partner_id': fields.many2one('res.partner',
- 'Bank/Payment Office partner',
- help="Put a partner if you want to have it on the commission move \
- (and optionaly on the counterpart of the intermediate/banking move \
- if you tic the corresponding checkbox)."),
+ 'Credit insitute partner',
+ help="Put a partner if you want to have it on the commission move (and optionaly\
+ on the counterpart of the intermediate/banking move if you tic the corresponding checkbox)."),
'journal_id': fields.many2one('account.journal',
'Financial journal to use for transaction',
required=True),
@@ -60,16 +54,13 @@ class AccountStatementProfil(Model):
in the counterpart of the intermediat/banking move."
),
'balance_check': fields.boolean('Balance check',
- help="Tic that box if you want OpenERP to control the start/end \
- balance before confirming a bank statement. If don't ticked, no \
- balance control will be done."
+ help="Tic that box if you want OpenERP to control the start/end balance\
+ before confirming a bank statement. If don't ticked, no balance control will be done."
),
- 'bank_statement_prefix': fields.char('Bank Statement Prefix', size=32),
- 'bank_statement_ids': fields.one2many('account.bank.statement', 'profile_id', 'Bank Statement Imported'),
-
-
}
-
+
+ _defaults = {}
+
def _check_partner(self, cr, uid, ids, context=None):
obj = self.browse(cr, uid, ids[0], context=context)
if obj.partner_id == False and obj.force_partner_on_bank:
@@ -82,42 +73,43 @@ class AccountStatementProfil(Model):
class AccountBankSatement(Model):
- """
- We improve the bank statement class mostly for :
- - Removing the period and compute it from the date of each line.
- - Allow to remove the balance check depending on the chosen profil
- - Report errors on confirmation all at once instead of crashing onr by one
- - Add a profil notion that can change the generated entries on statement
- confirmation.
- For this, we had to override quite some long method and we'll need to maintain
- them up to date. Changes are point up by '#Chg' comment.
- """
+ """A kind of bank statement for intermediate move between customer and real bank, used
+ for manageing check, payment office like paypal or marketplace like amazon.
+ We inherit account.bank.statement because it's a very close object with only some
+ difference. But we want some method to be completely different, so we create a new object."""
_inherit = "account.bank.statement"
_columns = {
- 'profile_id': fields.many2one('account.statement.profil',
- 'Profil', required=True, readonly=True, states={'draft': [('readonly', False)]}),
+ 'import_config_id': fields.many2one('account.statement.profil',
+ 'Profil', required=True, states={'draft': [('readonly', False)]}),
'credit_partner_id': fields.related(
- 'profile_id',
+ 'import_config_id',
'partner_id',
type='many2one',
relation='res.partner',
string='Financial Partner',
store=True, readonly=True),
'balance_check': fields.related(
- 'profile_id',
+ 'import_config_id',
'balance_check',
type='boolean',
string='Balance check',
store=True, readonly=True),
'journal_id': fields.related(
- 'profile_id',
+ 'import_config_id',
'journal_id',
type='many2one',
relation='account.journal',
string='Journal',
store=True, readonly=True),
+ # 'line_ids': fields.one2many('account.bank.statement.line',
+ # 'statement_id', 'Statement lines',
+ # states={'confirm':[('readonly', True)]}),
+ # 'move_line_ids': fields.one2many('account.move.line', 'statement_treasury_id',
+ # 'Entry lines', states={'confirm':[('readonly',True)]}),
+ # Redefine this field to avoid his computation (it is a function field on bank statement)
+ # 'balance_end': fields.dummy(string="Computed Balance"),
'period_id': fields.many2one('account.period', 'Period', required=False, readonly=True),
}
@@ -127,17 +119,17 @@ class AccountBankSatement(Model):
def create(self, cr, uid, vals, context=None):
"""Need to pass the journal_id in vals anytime because of account.cash.statement
- need it."""
- if 'profile_id' in vals:
+ that need it."""
+ if 'import_config_id' in vals:
profil_obj = self.pool.get('account.statement.profil')
- profile = profil_obj.browse(cr,uid,vals['profile_id'],context)
+ profile = profil_obj.browse(cr,uid,vals['import_config_id'],context)
vals['journal_id'] = profile.journal_id.id
return super(AccountBankSatement, self).create(cr, uid, vals, context=context)
def _get_period(self, cursor, uid, date, context=None):
- """
- Find matching period for date, used in the statement line creation.
- """
+ '''
+ Find matching period for date, used in thestatement line creation.
+ '''
period_obj = self.pool.get('account.period')
periods = period_obj.find(cursor, uid, dt=date, context=context)
return periods and periods[0] or False
@@ -157,46 +149,24 @@ class AccountBankSatement(Model):
return False
return True
+ # Redefine the constraint, or it still refer to the original method
_constraints = [
(_check_company_id, 'The journal and period chosen have to belong to the same company.', ['journal_id','period_id']),
]
- def button_cancel(self, cr, uid, ids, context={}):
- """
- We cancel the related move, delete them and finally put the
- statement in draft state. So no need to unreconcile all entries,
- then unpost them, then finaly cancel the bank statement.
- """
- done = []
- for st in self.browse(cr, uid, ids, context=context):
- if st.state=='draft':
- continue
- ids = []
- for line in st.line_ids:
- for move in line.move_ids:
- move.button_cancel(context=context)
- move.unlink(context=context)
- done.append(st.id)
- self.write(cr, uid, done, {'state':'draft'}, context=context)
- return True
-
def create_move_from_st_line(self, cr, uid, st_line_id, company_currency_id, st_line_number, context=None):
- """
- Override a large portion of the code to compute the periode for each line instead of
+ """Override a large portion of the code to compute the periode for each line instead of
taking the period of the whole statement.
Remove the entry posting on generated account moves.
- We change the move line generated from the lines depending on the profil:
+ Point to account.bank.statement.line instead of account.bank.statement.line.
+ In Treasury Statement, unlike the Bank statement, we will change the move line generated from the
+ lines depending on the profil (config import):
- If receivable_account_id is set, we'll use it instead of the "partner" one
- If partner_id is set, we'll us it for the commission (when imported throufh the wizard)
- If partner_id is set and force_partner_on_bank is ticked, we'll let the partner of each line
for the debit line, but we'll change it on the credit move line for the choosen partner_id
- => This will ease the reconciliation process with the bank as the partner will match the bank
+ => This will ease the reconsiliation process with the bank as the partner will match the bank
statement line
-
- :param int/long: st_line_id: account.bank.statement.line ID
- :param int/long: company_currency_id: res.currency ID
- :param char: st_line_number: that will be used as the name of the generated account move
- :return: int/long: ID of the created account.move
"""
if context is None:
context = {}
@@ -276,8 +246,8 @@ class AccountBankSatement(Model):
amount_currency = st_line.amount
currency_id = st.currency.id
# GET THE RIGHT PARTNER ACCORDING TO THE CHOSEN PROFIL # Chg
- if st.profile_id.force_partner_on_bank: # Chg
- bank_parrtner_id = st.profile_id.partner_id.id # Chg
+ if st.import_config_id.force_partner_on_bank: # Chg
+ bank_parrtner_id = st.import_config_id.partner_id.id # Chg
else: # Chg
bank_parrtner_id = ((st_line.partner_id) and st_line.partner_id.id) or False # Chg
@@ -310,40 +280,24 @@ class AccountBankSatement(Model):
account_move_obj.post(cr, uid, [move_id], context=context)
return move_id
- def _get_st_number_period_profil(self, cr, uid, date, profile_id):
- """
- Retrieve the name of bank statement from sequence, according to the period
- corresponding to the date passed in args. Add a prefix if set in the profil.
-
- :param: date: date of the statement used to compute the right period
- :param: int/long: profile_id: the account.statement.profil ID from which to take the
- bank_statement_prefix for the name
- :return: char: name of the bank statement (st_number)
-
- """
+ def _get_st_number_period(self, cr, uid, date, journal_sequence_id):
+ """Retrieve the name of bank statement from sequence, according to the period
+ corresponding to the date passed in args"""
year = self.pool.get('account.period').browse(cr, uid, self._get_period(cr, uid, date)).fiscalyear_id.id
- profile = self.pool.get('account.statement.profil').browse(cr,uid, profile_id)
c = {'fiscalyear_id': year}
obj_seq = self.pool.get('ir.sequence')
- journal_sequence_id = profile.journal_id.sequence_id and profile.journal_id.sequence_id.id or False
if journal_sequence_id:
st_number = obj_seq.next_by_id(cr, uid, journal_sequence_id, context=c)
else:
st_number = obj_seq.next_by_code(cr, uid, 'account.bank.statement', context=c)
- if profile.bank_statement_prefix:
- st_number = profile.bank_statement_prefix + st_number
return st_number
def button_confirm_bank(self, cr, uid, ids, context=None):
- """
- Completely override the method in order to have
- an error message which displays all the messages
- instead of having them pop one by one.
- We have to copy paste a big block of code, changing the error
- stack + managing period from date.
-
- TODO: Log the error in a bank statement field instead of using a popup !
- """
+ """Completely override the method in order to have
+ an error message which displays all the messages
+ instead of having them pop one by one.
+ We have to copy paste a big block of code, changing the error
+ stack + managing period from date."""
# obj_seq = self.pool.get('irerrors_stack.sequence')
if context is None:
context = {}
@@ -364,7 +318,13 @@ class AccountBankSatement(Model):
st_number = st.name
else:
# Begin Changes
- st_number = self._get_st_number_period_profil(cr, uid, st.date, st.profile_id.id)
+ seq_id = st.journal_id.sequence_id and st.journal_id.sequence_id.id or False
+ st_number = self._get_st_number_period(cr, uid, st.date, seq_id)
+ # c = {'fiscalyear_id': st.period_id.fiscalyear_id.id}
+ # if st.journal_id.sequence_id:
+ # st_number = obj_seq.next_by_id(cr, uid, st.journal_id.sequence_id.id, context=c)
+ # else:
+ # st_number = obj_seq.next_by_code(cr, uid, 'account.bank.statement', context=c)
# End Changes
for line in st.move_line_ids:
if line.state <> 'valid':
@@ -399,19 +359,60 @@ class AccountBankSatement(Model):
self.log(cr, uid, st.id, _('Statement %s is confirmed, journal items are created.') % (st_number,))
return self.write(cr, uid, ids, {'state':'confirm'}, context=context)
- def get_account_for_counterpart(self, cursor, uid,
+ def get_partner_from_so(self, cursor, uid,transaction_id):
+ """Look for the SO that has the given transaction_id, if not
+ found, try to match the SO name instead. If still nothing,
+ return False"""
+ so_obj = self.pool.get('sale.order')
+ so_id = so_obj.search(cursor, uid, [('transaction_id', '=', transaction_id)])
+ if so_id and len(so_id) == 1:
+ return so_obj.browse(cursor, uid, so_id[0]).partner_id.id
+ else:
+ so_id2 = so_obj.search(cursor, uid, [('name', '=', transaction_id)])
+ if so_id2 and len(so_id2) == 1:
+ return so_obj.browse(cursor, uid, so_id2[0]).partner_id.id
+ return False
+
+
+ def get_default_accounts(self, cursor, uid, receivable_account_id, context=None):
+ """We try to determine default accounts if not receivable_account_id set, otherwise
+ take it for both receivable and payable account"""
+ account_receivable = False
+ account_payable = False
+ if receivable_account_id:
+ account_receivable = account_payable = receivable_account_id
+ else:
+ context = context or {}
+ property_obj = self.pool.get('ir.property')
+ model_fields_obj = self.pool.get('ir.model.fields')
+ model_fields_ids = model_fields_obj.search(
+ cursor,
+ uid,
+ [('name', 'in', ['property_account_receivable',
+ 'property_account_payable']),
+ ('model', '=', 'res.partner'),],
+ context=context
+ )
+ property_ids = property_obj.search(
+ cursor,
+ uid, [
+ ('fields_id', 'in', model_fields_ids),
+ ('res_id', '=', False),
+ ],
+ context=context
+ )
+
+ for erp_property in property_obj.browse(cursor, uid,
+ property_ids, context=context):
+ if erp_property.fields_id.name == 'property_account_receivable':
+ account_receivable = erp_property.value_reference.id
+ elif erp_property.fields_id.name == 'property_account_payable':
+ account_payable = erp_property.value_reference.id
+ return account_receivable, account_payable
+
+ def _get_account_id(self, cursor, uid,
amount, account_receivable, account_payable):
- """
- Give the amount, payable and receivable account (that can be found using
- get_default_pay_receiv_accounts method) and receive the one to use. This method
- should be use when there is no other way to know which one to take.
-
- :param float: amount of the line
- :param int/long: account_receivable the receivable account
- :param int/long: account_payable the payable account
- :return: int/long :the default account to be used by statement line as the counterpart
- of the journal account depending on the amount.
- """
+ "return the default account to be used by statement line"
account_id = False
if amount >= 0:
account_id = account_receivable
@@ -424,71 +425,33 @@ class AccountBankSatement(Model):
)
return account_id
- def get_default_pay_receiv_accounts(self, cursor, uid, context=None):
- """
- We try to determine default payable/receivable accounts to be used as counterpart
- from the company default propoerty. This is to be used if there is no otherway to
- find the good one, or to find a default value that will be overriden by a completion
- method (rules of account_statement_base_completion) afterwards.
-
- :return: tuple of int/long ID that give account_receivable, account_payable based on
- company default.
- """
- account_receivable = False
- account_payable = False
- context = context or {}
- property_obj = self.pool.get('ir.property')
- model_fields_obj = self.pool.get('ir.model.fields')
- model_fields_ids = model_fields_obj.search(
- cursor,
- uid,
- [('name', 'in', ['property_account_receivable',
- 'property_account_payable']),
- ('model', '=', 'res.partner'),],
- context=context
- )
- property_ids = property_obj.search(
- cursor,
- uid, [
- ('fields_id', 'in', model_fields_ids),
- ('res_id', '=', False),
- ],
- context=context
- )
-
- for erp_property in property_obj.browse(cursor, uid,
- property_ids, context=context):
- if erp_property.fields_id.name == 'property_account_receivable':
- account_receivable = erp_property.value_reference.id
- elif erp_property.fields_id.name == 'property_account_payable':
- account_payable = erp_property.value_reference.id
- return account_receivable, account_payable
-
def balance_check(self, cr, uid, st_id, journal_type='bank', context=None):
- """
- Balance check depends on the profil. If no check for this profil is required,
- return True and do nothing, otherwise call super.
-
- :param int/long st_id: ID of the concerned account.bank.statement
- :param char: journal_type that concern the bank statement
- :return: True
- """
+ """Balance check depends on the profil. If no check for this profil is required,
+ return True"""
st = self.browse(cr, uid, st_id, context=context)
if st.balance_check:
return super(AccountBankSatement,self).balance_check(cr, uid, st_id, journal_type, context)
else:
return True
-
- def onchange_imp_config_id(self, cr, uid, ids, profile_id, context=None):
- """
- Compute values on the change of the profile.
- :param: int/long: profile_id that changed
- :return dict of dict with key = name of the field
+ def _get_value_from_import_config(self, cr, uid, import_config_id):
+ """Return a dict with with values taken from the given config.
+ e.g. (journal_id, partner_id, commission_account_id, mode, forced_account_id)
"""
- if not profile_id:
+ # Get variable from config
+ import_config = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
+ forced_account_id = import_config.receivable_account_id and import_config.receivable_account_id.id or False
+ journal_id = import_config.journal_id and import_config.journal_id.id or False
+ partner_id = import_config.partner_id and import_config.partner_id.id or False
+ commission_account_id = import_config.commission_account_id.id
+ commission_analytic_id = import_config.commission_analytic_id and import_config.commission_analytic_id.id or False
+ force_partner_on_bank = import_config.force_partner_on_bank
+ return journal_id, partner_id, commission_account_id, commission_analytic_id, forced_account_id, force_partner_on_bank
+
+ def onchange_imp_config_id(self, cr, uid, ids, import_config_id, context=None):
+ if not import_config_id:
return {}
- import_config = self.pool.get("account.statement.profil").browse(cr,uid,profile_id)
+ import_config = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
journal_id = import_config.journal_id.id
account_id = import_config.journal_id.default_debit_account_id.id
credit_partner_id = import_config.partner_id and import_config.partner_id.id or False
@@ -497,106 +460,166 @@ class AccountBankSatement(Model):
'credit_partner_id':credit_partner_id,
}}
+ def credit_statement_import(self, cursor, uid, ids,
+ import_config_id,
+ file_stream,
+ ftype="csv",
+ context=None):
+ "Create statement from file stream encoded in base 64"
+ context = context or {}
+ statement_obj = self.pool.get('account.bank.statement')
+ statement_line_obj = self.pool.get('account.bank.statement.line')
+ attachment_obj = self.pool.get('ir.attachment')
+
+ # Get variable from config
+ journal_id, partner_id, commission_account_id, commission_analytic_id, \
+ forced_account_id, force_partner_on_bank = self._get_value_from_import_config(cursor,uid,import_config_id)
+
+ account_receivable, account_payable = self.get_default_accounts(cursor, uid, forced_account_id)
+
+ ##Order of cols does not matter but first row has to be header
+ keys = ['transaction_id', 'label', 'date', 'amount', 'commission_amount']
+ #required_values = ['transaction_id', 'amount', 'commission_amount']
+ convertion_dict = {
+ 'transaction_id': unicode,
+ 'label': unicode,
+ 'date': datetime.datetime,
+ 'amount': float,
+ 'commission_amount': float
+ }
+
+ f_parser = FileParser(file_stream,
+ keys_to_validate=keys,
+ decode_base_64=True,
+ ftype=ftype)
+ statement_lines = f_parser.parse()
+ statement_lines = f_parser.cast_rows(statement_lines, convertion_dict)
+ journal = self.pool.get('account.journal').browse(cursor, uid, journal_id)
+ statement_id = statement_obj.create(cursor,
+ uid,
+ { 'import_config_id':import_config_id,
+ 'journal_id': journal_id,
+ 'journal_id': journal_id,
+ 'credit_partner_id': partner_id,
+ 'statement_type': 'credit_partner',
+ },
+ context)
+ commission_global_amount = 0.0
+ if not journal.default_debit_account_id \
+ or not journal.default_credit_account_id:
+ raise osv.except_osv(
+ _("Missing default account on journal %s")%(journal.name),
+ _("Please correct the journal"))
+ try:
+ for line in statement_lines:
+ line_partner_id = False
+ line_to_reconcile = False
+ # We ensure that required values of the line are set
+# for val in required_values:
+# if not line.get(val, False) and line.get(val, False) != 0.0:
+# raise osv.except_osv(
+# _("Field %s not set for line %s")%(str(line),),
+# _("Please correct the file"))
+
+ commission_global_amount += line.get('commission_amount', 0.0)
+ values = {
+ 'name': "IN %s %s"%(line['transaction_id'],
+ line.get('label', '')),
+ 'date': line.get('date', datetime.datetime.now().date()),
+ 'amount': line['amount'],
+ 'ref': "TID_%s"%(line['transaction_id'],),
+ 'type': 'customer',
+ 'statement_id': statement_id,
+ #'account_id': journal.default_debit_account_id
+ }
+ values['account_id'] = self._get_account_id(
+ cursor,
+ uid,
+ line['amount'],
+ account_receivable,
+ account_payable
+ )
+ if not line_partner_id:
+ line_partner_id = self.get_partner_from_so(cursor,
+ uid, line['transaction_id'])
+ values['partner_id'] = line_partner_id
+ # we finally create the line in system
+ statement_line_obj.create(cursor, uid, values, context=context)
+
+ # we create commission line
+ if commission_global_amount:
+ comm_values = {
+ 'name': 'IN '+ _('Commission line'),
+ 'date': datetime.datetime.now().date(),
+ 'amount': commission_global_amount,
+ 'partner_id': partner_id,
+ 'type': 'general',
+ 'statement_id': statement_id,
+ 'account_id': commission_account_id,
+ 'ref': 'commission',
+ 'analytic_account_id': commission_analytic_id
+ }
+ statement_line_obj.create(cursor, uid,
+ comm_values,
+ context=context)
+
+ attachment_obj.create(
+ cursor,
+ uid,
+ {
+ 'name': 'statement file',
+ 'datas': file_stream,
+ 'datas_fname': "%s.%s"%(datetime.datetime.now().date(),
+ ftype),
+ 'res_model': 'account.bank.statement',
+ 'res_id': statement_id,
+ },
+ context=context
+ )
+ except Exception, exc:
+ logger.notifyChannel("Statement import",
+ netsvc.LOG_ERROR,
+ _("Statement can not be created %s") %(exc,))
+
+ statement_obj.unlink(cursor, uid, [statement_id])
+ raise exc
+ return statement_id
+
+
class AccountBankSatementLine(Model):
- """
- Override to compute the period from the date of the line, add a method to retrieve
- the values for a line from the profile. Override the on_change method to take care of
- the profile when fullfilling the bank statement manually. Set the reference to 64
- Char long instead 32.
- """
_inherit = "account.bank.statement.line"
def _get_period(self, cursor, user, context=None):
- """
- Return a period from a given date in the context.
- """
date = context.get('date', None)
periods = self.pool.get('account.period').find(cursor, user, dt=date)
return periods and periods[0] or False
- def _get_default_account(self, cursor, user, context=None):
- return self.get_values_for_line(cursor, user, context = context)['account_id']
-
_columns = {
- # Set them as required + 64 char instead of 32
- 'ref': fields.char('Reference', size=64, required=True),
+ # 'statement_id': fields.many2one('account.bank.statement', 'Statement',
+ # select=True, required=True, ondelete='cascade'),
+ # 'move_ids': fields.many2many('account.move',
+ # 'account_treasury_statement_line_move_rel', 'statement_line_id','move_id',
+ # 'Moves'),
+ 'ref': fields.char('Reference', size=32, required=True),
'period_id': fields.many2one('account.period', 'Period', required=True),
}
_defaults = {
'period_id': _get_period,
- 'account_id': _get_default_account,
}
-
- def get_values_for_line(self, cr, uid, profile_id = False, partner_id = False, line_type = False, amount = False, context = None):
- """
- Return the account_id to be used in the line of a bank statement. It'll base the result as follow:
- - If a receivable_account_id is set in the profil, return this value and type = general
- - Elif line_type is given, take the partner receivable/payable property (payable if type= supplier, receivable
- otherwise)
- - Elif amount is given, take the partner receivable/payable property (receivable if amount >= 0.0,
- payable otherwise). In that case, we also fullfill the type (receivable = customer, payable = supplier)
- so it is easier for the accountant to know why the receivable/payable has been chosen
- - Then, if no partner are given we look and take the property from the company so we always give a value
- for account_id. Note that in that case, we return the receivable one.
-
- :param int/long profile_id of the related bank statement
- :param int/long partner_id of the line
- :param char line_type: a value from: 'general', 'supplier', 'customer'
- :param float: amount of the line
- :return: A dict of value that can be passed directly to the write method of
- the statement line:
- {'partner_id': value,
- 'account_id' : value,
- 'type' : value,
- ...
- }
- """
- if context is None:
- context = {}
- res = {}
- obj_partner = self.pool.get('res.partner')
- obj_stat = self.pool.get('account.bank.statement')
- receiv_account = pay_account = account_id = False
- # If profil has a receivable_account_id, we return it in any case
- if profile_id:
- profile = self.pool.get("account.statement.profil").browse(cr,uid,profile_id)
- if profile.receivable_account_id:
- res['account_id'] = profile.receivable_account_id.id
- res['type'] = 'general'
- return res
- # If partner -> take from him
- if partner_id:
- part = obj_partner.browse(cr, uid, partner_id, context=context)
- pay_account = part.property_account_payable.id
- receiv_account = part.property_account_receivable.id
- # If no value, look on the default company property
- if not pay_account or not receiv_account:
- receiv_account, pay_account = obj_stat.get_default_pay_receiv_accounts(cr, uid, context=None)
- # Now we have both pay and receive account, choose the one to use
- # based on line_type first, then amount, otherwise take receivable one.
- if line_type is not False:
- if line_type == 'supplier':
- res['account_id'] = pay_account
- else:
- res['account_id'] = receiv_account
- elif amount is not False:
- if amount >= 0:
- res['account_id'] = receiv_account
- res['type'] = 'customer'
- else:
- res['account_id'] = pay_account
- res['type'] = 'supplier'
- if not account_id:
- res['account_id'] = receiv_account
- return res
-
-
- def onchange_partner_id(self, cr, uid, ids, partner_id, profile_id, context=None):
- """
- Override of the basic method as we need to pass the profile_id in the on_change_type
- call.
- """
+
+ # WARNING => Crash cause the super method here calls onchange_type => and then
+ # we don't call it from the good model.... => We'll need to override the complete method here
+ def onchange_partner_id(self, cr, uid, ids, partner_id, import_config_id, context=None):
+ # import pdb;pdb.set_trace()
+ # if context is None:
+ # context = {}
+ # res = super(AccountTreasurySatementLine,self).onchange_partner_id(cr, uid, ids, partner_id, context)
+ # c = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
+ # acc_id=c.receivable_account_id and c.receivable_account_id.id or False
+ # if acc_id:
+ # res['value'].update({'account_id':acc_id})
+ # return res
obj_partner = self.pool.get('res.partner')
if context is None:
context = {}
@@ -612,23 +635,34 @@ class AccountBankSatementLine(Model):
type = 'supplier'
if part.customer == True:
type = 'customer'
- res_type = self.onchange_type(cr, uid, ids, partner_id, type, profile_id, context=context) # Chg
+ res_type = self.onchange_type(cr, uid, ids, partner_id, type, import_config_id, context=context)
if res_type['value'] and res_type['value'].get('account_id', False):
- return {'value': {'type': type, 'account_id': res_type['value']['account_id']}}
- return {'value': {'type': type}}
+ res = {'value': {'type': type, 'account_id': res_type['value']['account_id']}}
+ else:
+ res = {'value': {'type': type}}
+
+ c = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
+ acc_id=c.receivable_account_id and c.receivable_account_id.id or False
+ if acc_id:
+ res['value'].update({'account_id':acc_id})
+ return res
- def onchange_type(self, cr, uid, line_id, partner_id, type, profile_id, context=None):
- """
- Keep the same features as in standard and call super. If an account is returned,
- call the method to compute line values.
- """
+ # TOFIX
+ def onchange_type(self, cr, uid, line_id, partner_id, type, import_config_id, context=None):
if context is None:
context = {}
res = super(AccountBankSatementLine,self).onchange_type(cr, uid, line_id, partner_id, type, context)
- if 'account_id' in res['value']:
- result = self.get_values_for_line(cr, uid, profile_id = profile_id,
- partner_id = partner_id, line_type = type, context = context)
- if result:
- res['value'].update({'account_id':result['account_id']})
+ c = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
+ acc_id=c.receivable_account_id and c.receivable_account_id.id or False
+ if acc_id:
+ res['value'].update({'account_id':acc_id})
return res
+# class AccountMoveLine(Model):
+# _inherit = "account.move.line"
+#
+# _columns = {
+# 'statement_treasury_id': fields.many2one('account.bank.statement', 'Statement', help="The intermediate statement used for reconciliation", select=1),
+# }
+
+
diff --git a/account_statement_ext/statement_view.xml b/account_statement_ext/statement_view.xml
index 62a51b89..0ea59c0a 100644
--- a/account_statement_ext/statement_view.xml
+++ b/account_statement_ext/statement_view.xml
@@ -15,14 +15,12 @@
- account.move.line.search.add_field
account.move.line
search
-
@@ -42,7 +40,6 @@
-
@@ -93,8 +90,7 @@
search
-
-
+
@@ -112,11 +108,8 @@
tree
-
-
-
-
+
@@ -138,12 +131,12 @@
-
-
-
+
+
+
-
+
@@ -158,7 +151,7 @@
-
+
@@ -173,36 +166,53 @@
-
+
-
+
-
+
-
+
-
+
-
-
+
diff --git a/account_statement_base_import/wizard/__init__.py b/account_statement_ext/wizard/__init__.py
similarity index 92%
rename from account_statement_base_import/wizard/__init__.py
rename to account_statement_ext/wizard/__init__.py
index 5dbd2b0c..3d0490eb 100644
--- a/account_statement_base_import/wizard/__init__.py
+++ b/account_statement_ext/wizard/__init__.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
##############################################################################
#
-# Author Nicolas Bessi, Joel Grand-Guillaume. Copyright Camptocamp SA
+# Author Nicolas Bessi. Copyright Camptocamp SA
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
diff --git a/account_statement_base_import/wizard/import_statement.py b/account_statement_ext/wizard/import_statement.py
similarity index 75%
rename from account_statement_base_import/wizard/import_statement.py
rename to account_statement_ext/wizard/import_statement.py
index 574a8979..6c53f804 100644
--- a/account_statement_base_import/wizard/import_statement.py
+++ b/account_statement_ext/wizard/import_statement.py
@@ -28,25 +28,15 @@ from tools.translate import _
import os
class CreditPartnerStatementImporter(osv.osv_memory):
+ """Import Credit statement"""
+
_name = "credit.statement.import"
-
- def default_get(self, cr, uid, fields, context=None):
- if context is None: context = {}
- res = {}
- if (context.get('active_model', False) == 'account.statement.profil' and
- context.get('active_ids', False)):
- ids = context['active_ids']
- assert len(ids) == 1, 'You cannot use this on more than one profile !'
- res['profile_id'] = ids[0]
- other_vals = self.onchange_profile_id(cr, uid, [], res['profile_id'], context=context)
- res.update(other_vals.get('value',{}))
- return res
-
+ _description = __doc__
_columns = {
- 'profile_id': fields.many2one('account.statement.profil',
+
+ 'import_config_id': fields.many2one('account.statement.profil',
'Import configuration parameter',
required=True),
- 'input_statement': fields.binary('Statement file', required=True),
'partner_id': fields.many2one('res.partner',
'Credit insitute partner',
),
@@ -71,12 +61,13 @@ class CreditPartnerStatementImporter(osv.osv_memory):
help="Tic that box if you want OpenERP to control the start/end balance\
before confirming a bank statement. If don't ticked, no balance control will be done."
),
+
}
-
- def onchange_profile_id(self, cr, uid, ids, profile_id, context=None):
+
+ def onchange_import_config_id(self, cr, uid, ids, import_config_id, context=None):
res={}
- if profile_id:
- c = self.pool.get("account.statement.profil").browse(cr,uid,profile_id)
+ if import_config_id:
+ c = self.pool.get("account.statement.profil").browse(cr,uid,import_config_id)
res = {'value': {'partner_id': c.partner_id and c.partner_id.id or False,
'journal_id': c.journal_id and c.journal_id.id or False, 'commission_account_id': \
c.commission_account_id and c.commission_account_id.id or False,
@@ -86,35 +77,31 @@ class CreditPartnerStatementImporter(osv.osv_memory):
'balance_check':c.balance_check,}}
return res
- def _check_extension(self, filename):
- (shortname, ftype) = os.path.splitext(filename)
- if not ftype:
- #We do not use osv exception we do not want to have it logged
- raise Exception(_('Please use a file with an extention'))
- return ftype
-
def import_statement(self, cursor, uid, req_id, context=None):
"""This Function import credit card agency statement"""
context = context or {}
if isinstance(req_id, list):
req_id = req_id[0]
importer = self.browse(cursor, uid, req_id, context)
- ftype = self._check_extension(importer.file_name)
+ (shortname, ftype) = os.path.splitext(importer.file_name)
+ if not ftype:
+ #We do not use osv exception we do not want to have it logged
+ raise Exception(_('Please use a file with an extention'))
sid = self.pool.get(
- 'account.statement.profil').statement_import(
+ 'account.bank.statement').credit_statement_import(
cursor,
uid,
False,
- importer.profile_id.id,
+ importer.import_config_id.id,
importer.input_statement,
ftype.replace('.',''),
context=context
- )
- return {
- 'domain': "[('id','in', ["+','.join(map(str,[sid]))+"])]",
- 'name': 'Imported Bank Statement',
- 'view_type': 'form',
- 'view_mode': 'tree,form',
- 'res_model': 'account.bank.statement',
- 'type': 'ir.actions.act_window',
- }
+ )
+ obj_data = self.pool.get('ir.model.data')
+ act_obj = self.pool.get('ir.actions.act_window')
+ result = obj_data.get_object_reference(cursor, uid, 'account_statement_import', 'action_treasury_statement_tree')
+
+ id = result and result[1] or False
+ result = act_obj.read(cursor, uid, [id], context=context)[0]
+ result['domain'] = str([('id','in',[sid])])
+ return result
diff --git a/account_statement_base_import/wizard/import_statement_view.xml b/account_statement_ext/wizard/import_statement_view.xml
similarity index 88%
rename from account_statement_base_import/wizard/import_statement_view.xml
rename to account_statement_ext/wizard/import_statement_view.xml
index 57fd8476..77d2dd25 100644
--- a/account_statement_base_import/wizard/import_statement_view.xml
+++ b/account_statement_ext/wizard/import_statement_view.xml
@@ -8,7 +8,7 @@