From 1d800663c63da5229a9f6750907c7f88d134b8c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miquel=20Ra=C3=AFch?= Date: Wed, 8 Jun 2022 13:46:22 +0200 Subject: [PATCH] [FIX] account_reconcile_model_strict_match_amount: communication_flag test The communication_flag test the match of aml.name, am.name and am.ref, not aml.ref. --- .../models/account_reconcile_model.py | 12 ++++++------ ...st_account_reconcile_model_strict_match_amount.py | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/account_reconcile_model_strict_match_amount/models/account_reconcile_model.py b/account_reconcile_model_strict_match_amount/models/account_reconcile_model.py index 16e1a17d..100790d1 100644 --- a/account_reconcile_model_strict_match_amount/models/account_reconcile_model.py +++ b/account_reconcile_model_strict_match_amount/models/account_reconcile_model.py @@ -45,9 +45,9 @@ class AccountReconcileModel(models.Model): , FALSE) AND CASE - WHEN abs(st_line.amount) < abs(aml.balance) THEN abs(st_line.amount) / abs(aml.balance) * 100 - WHEN abs(st_line.amount) > abs(aml.balance) THEN abs(aml.balance) / abs(st_line.amount) * 100 - ELSE 100 + WHEN abs(st_line.amount) < abs(aml.balance) THEN abs(st_line.amount) / abs(aml.balance) * 100.0 + WHEN abs(st_line.amount) > abs(aml.balance) THEN abs(aml.balance) / abs(st_line.amount) * 100.0 + ELSE 100.0 END >= {match_total_amount_param} AS communication_flag """.format( match_total_amount_param=self.match_total_amount_param @@ -67,9 +67,9 @@ class AccountReconcileModel(models.Model): , FALSE) AND CASE - WHEN abs(st_line.amount) < abs(aml.balance) THEN abs(st_line.amount) / abs(aml.balance) * 100 - WHEN abs(st_line.amount) > abs(aml.balance) THEN abs(aml.balance) / abs(st_line.amount) * 100 - ELSE 100 + WHEN abs(st_line.amount) < abs(aml.balance) THEN abs(st_line.amount) / abs(aml.balance) * 100.0 + WHEN abs(st_line.amount) > abs(aml.balance) THEN abs(aml.balance) / abs(st_line.amount) * 100.0 + ELSE 100.0 END >= {match_total_amount_param} AS payment_reference_flag """.format( match_total_amount_param=self.match_total_amount_param diff --git a/account_reconcile_model_strict_match_amount/tests/test_account_reconcile_model_strict_match_amount.py b/account_reconcile_model_strict_match_amount/tests/test_account_reconcile_model_strict_match_amount.py index c9582be6..785cbc26 100644 --- a/account_reconcile_model_strict_match_amount/tests/test_account_reconcile_model_strict_match_amount.py +++ b/account_reconcile_model_strict_match_amount/tests/test_account_reconcile_model_strict_match_amount.py @@ -14,9 +14,9 @@ class TestAccountReconcileModelStrictMatchAmount(TestReconciliationMatchingRules cls.partner_5 = cls.env["res.partner"].create({"name": "partner_5"}) cls.partner_6 = cls.env["res.partner"].create({"name": "partner_6"}) cls.invoice_line_5 = cls._create_invoice_line(150, cls.partner_3, "out_invoice") - cls.invoice_line_5.ref = "ABC001XYZ" + cls.invoice_line_5.name = "ABC001XYZ" cls.invoice_line_6 = cls._create_invoice_line(300, cls.partner_4, "out_invoice") - cls.invoice_line_6.name = "ABC002XYZ" + cls.invoice_line_6.move_id.name = "ABC002XYZ" cls.invoice_line_7 = cls._create_invoice_line(450, cls.partner_5, "out_invoice") cls.invoice_line_7.move_id.ref = "ABC003XYZ" cls.invoice_line_8 = cls._create_invoice_line(600, cls.partner_6, "out_invoice")