From 106d8d50d37704d138508bc0eb2d67269f55495b Mon Sep 17 00:00:00 2001 From: Matthieu Dietrich Date: Thu, 28 Apr 2016 11:40:14 +0200 Subject: [PATCH] PEP8 + add xlrd --- .travis.yml | 1 + account_statement_base_import/models/account_journal.py | 4 +++- account_statement_base_import/models/account_move.py | 4 ---- account_statement_base_import/tests/test_base_completion.py | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index eb8abdd0..3dd73edf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -31,6 +31,7 @@ install: - git clone --depth=1 https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH} - travis_install_nightly + - pip install xlrd script: - travis_run_tests diff --git a/account_statement_base_import/models/account_journal.py b/account_statement_base_import/models/account_journal.py index ac37f0e7..8f8f6eab 100644 --- a/account_statement_base_import/models/account_journal.py +++ b/account_statement_base_import/models/account_journal.py @@ -132,7 +132,9 @@ class AccountJournal(models.Model): 'account_id': commission_account_id, 'already_completed': True, } - move_line_obj.with_context(check_move_validity=False).create(comm_values) + move_line_obj.with_context( + check_move_validity=False + ).create(comm_values) # Counterpart line if total_amount > 0.0: receivable_account_id = self.receivable_account_id.id or False diff --git a/account_statement_base_import/models/account_move.py b/account_statement_base_import/models/account_move.py index efffe561..2f328a90 100644 --- a/account_statement_base_import/models/account_move.py +++ b/account_statement_base_import/models/account_move.py @@ -319,10 +319,6 @@ class AccountMoveLine(models.Model): def _update_line(self, vals): """ Do raw update into database because ORM is awfully slow when cheking security. - TODO / WARM: sparse fields are skipped by the method. IOW, if your - completion rule update an sparse field, the updated value will never - be stored in the database. It would be safer to call the update method - from the ORM for records updating this kind of fields. """ cols = self._get_available_columns([vals]) vals = self._prepare_insert(vals, cols) diff --git a/account_statement_base_import/tests/test_base_completion.py b/account_statement_base_import/tests/test_base_completion.py index 2b953ab4..98a86f56 100644 --- a/account_statement_base_import/tests/test_base_completion.py +++ b/account_statement_base_import/tests/test_base_completion.py @@ -48,10 +48,10 @@ NAMES_COMPLETION_CASES = [ ] -class base_completion(common.TransactionCase): +class BaseCompletion(common.TransactionCase): def setUp(self): - super(base_completion, self).setUp() + super(BaseCompletion, self).setUp() tools.convert_file(self.cr, 'account', get_module_resource('account', 'test', 'account_minimal_test.xml'),