mirror of
https://github.com/OCA/account-financial-tools.git
synced 2025-02-02 12:47:26 +02:00
8f225d8aa3
The whole point of this module is to allow VIES failures. However, when running mass checks, if one single partner failed, the whole process had to start again. FWIW that can be also problematic due to rate limits in VIES service. For that same reason, we now skip partners that are validated already, and those that are will inherit the status from their parent anyway. Now, the process will just continue and report failures at the end. It includes new tests, removes dead code, and reduces pre-existing tests verbosity. @moduon MT-7763
88 lines
3.7 KiB
Python
88 lines
3.7 KiB
Python
# Copyright 2015 Tecnativa - Antonio Espinosa
|
|
# Copyright 2016 Tecnativa - Sergio Teruel
|
|
# Copyright 2017 Tecnativa - David Vidal
|
|
# Copyright 2022 Moduon - Eduardo de Miguel
|
|
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
|
|
|
|
from unittest.mock import patch
|
|
|
|
from odoo.exceptions import ValidationError
|
|
from odoo.tests import common
|
|
from odoo.tools import mute_logger
|
|
|
|
|
|
class TestResPartner(common.TransactionCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
def check_vies(vat_number):
|
|
return {"valid": vat_number == "ESB87530432"}
|
|
|
|
super().setUpClass()
|
|
cls.company = cls.env.user.company_id
|
|
cls.company.vat_check_vies = True
|
|
cls.partner = cls.env["res.partner"].create(
|
|
{"name": "Test partner", "is_company": True}
|
|
)
|
|
cls.vatnumber_path = "odoo.addons.base_vat.models.res_partner.check_vies"
|
|
|
|
cls._vies_check_func = check_vies
|
|
|
|
@mute_logger("odoo.addons.base_vat.models.res_partner")
|
|
def test_validate_vat_vies(self):
|
|
with patch(self.vatnumber_path, type(self)._vies_check_func):
|
|
values = {"vat": "ESB87530432", "country_id": self.env.ref("base.be").id}
|
|
field_onchange = self.partner._onchange_spec()
|
|
result = self.partner.onchange(
|
|
values=values,
|
|
field_name=["vat", "country_id"],
|
|
field_onchange=field_onchange,
|
|
)
|
|
self.assertEqual(result.get("value", {}).get("vies_passed"), True)
|
|
self.assertEqual(self.partner.vies_passed, False)
|
|
self.partner.write(values)
|
|
self.assertEqual(self.partner.vies_passed, True)
|
|
|
|
@mute_logger("odoo.addons.base_vat.models.res_partner")
|
|
def test_exception_vat_vies(self):
|
|
with patch(self.vatnumber_path, side_effect=Exception()):
|
|
values = {"vat": "87530432", "country_id": self.env.ref("base.es").id}
|
|
field_onchange = self.partner._onchange_spec()
|
|
result = self.partner.onchange(
|
|
values=values,
|
|
field_name=["vat", "country_id"],
|
|
field_onchange=field_onchange,
|
|
)
|
|
self.assertEqual(result.get("value", {}).get("vies_passed"), True)
|
|
with self.assertRaises(ValidationError):
|
|
self.partner.write(values)
|
|
self.assertEqual(self.partner.vies_passed, False)
|
|
|
|
def test_no_validate_vat(self):
|
|
with patch(self.vatnumber_path) as mock_vatnumber:
|
|
mock_vatnumber.check_vies.return_value = False
|
|
with self.assertRaises(ValidationError):
|
|
self.partner.vat = "ESB11"
|
|
self.assertEqual(self.partner.vies_passed, False)
|
|
|
|
def test_validate_simple_vat_vies(self):
|
|
with patch(self.vatnumber_path) as mock_vatnumber:
|
|
self.company.vat_check_vies = False
|
|
mock_vatnumber.check_vies.return_value = False
|
|
self.partner.vat = "MXGODE561231GR8"
|
|
self.partner.country_id = self.env.ref("base.mx")
|
|
self.assertEqual(self.partner.vies_passed, False)
|
|
|
|
@mute_logger("odoo.addons.base_vat.models.res_partner")
|
|
def test_validate_vies_passed_false_when_vat_set_to_false(self):
|
|
with patch(self.vatnumber_path) as mock_vatnumber:
|
|
mock_vatnumber.check_vies.return_value = True
|
|
self.partner.vat = "ESB87530432"
|
|
self.partner.country_id = self.env.ref("base.be")
|
|
self.assertEqual(self.partner.vies_passed, True)
|
|
self.partner.vat = False
|
|
self.assertEqual(self.partner.vies_passed, False)
|
|
|
|
def test_validate_wrong_vat_shows_simple_message(self):
|
|
with self.assertRaisesRegex(ValidationError, "does not seem to be valid"):
|
|
self.partner.vat = "ES11111111A"
|