Commit Graph

27 Commits

Author SHA1 Message Date
Valentin Vinagre Urteaga
7485740bb3 [FIX] account_asset_management: FIX empty asset reference
If the assets are created before posting the invoice, they wouldn't have a name and the "code" field of the assets will be empty, but they would have the invoice name.
2022-04-13 10:57:57 +02:00
Ernesto Tejeda
7dff7f3db4 [FIX] account_asset_management: fix remaining_value cache miss error. 2022-04-13 10:57:57 +02:00
Valentin Vinagre Urteaga
528741b9e2 [IMP] account_asset_management: Add chatter entry in invoice for generated asset 2022-04-13 10:57:57 +02:00
Andrea
c6d4e3eda4 Fix of pre-commit: E741 ambiguous variable name 'l' 2022-04-13 10:57:57 +02:00
Quentin Groulard
2dd8c15cfe [IMP] account_asset_management: Depreciation board compute upon asset confirmation 2022-04-13 10:57:57 +02:00
Pedro M. Baeza
22a8c32378 [IMP] account_asset_management: Simplify code for opening related entries
We don't need the search having the one2many field and no need also for list
comprehension having mapped operator.
2022-04-13 10:57:57 +02:00
Pedro M. Baeza
73ce4ce508 [FIX] account_asset_management: Avoid error
Steps to reproduce the problem:

* Go to assets view
* Group by profile
* Unfold a group and click on an asset
* Click on "Journal Entries" smart-button
* Go back to the asset list
* Click again on the same asset (or another).
* Click on "Journal Entries" smart-button

Current behavior:

Error saying "KeyError: 'profile_id'"

Expected behavior:

No error

The cause for this is that Odoo stores in the context the key `group_by` with the
value `profile_id` in the specified chain of steps. That context entry is used for
grouping records in the list, and system tries to group the journal entries also
by that field, which doesn't exists in the other model, and thus the error.

We avoided it copying the context to be passes and leaving out that entry.
2022-04-13 10:57:57 +02:00
ernestotejeda
ed4314c237 [MIG] account_asset_management: Migration to 13.0 2022-04-13 10:57:57 +02:00
ernestotejeda
00ef1051fb [IMP] account_asset_management: black, isort 2022-04-13 10:57:57 +02:00
Luc De Meyer
05a0d1f7a3 [12.0][FIX]traceback when deviating FY 2022-04-13 10:57:57 +02:00
Iván Todorovich
b0a28ac3df [12.0][FIX][account_asset_management] local variable 'asset' referenced before assignment
tools/account_asset_management/models/account_asset.py", line 970, in _compute_entries
    % (asset.name, asset.code) or asset.name
UnboundLocalError: local variable 'asset' referenced before assignment
2022-04-13 10:57:57 +02:00
Joan Sisquella
8ca62153fe [ADD] allows setting a depreciation ending date 2022-04-13 10:57:57 +02:00
Saran
91167ba799 [ADD] options 'use_leap_years' 2022-04-13 10:57:57 +02:00
Saran
8f7d81d3dd [12.0][IMP] account_asset_management 2022-04-13 10:57:57 +02:00
Pedro M. Baeza
5358104889 [MIG+FIX+IMP] account_asset_management: Rework migration scripts + make asset group m2m 2022-04-13 10:57:57 +02:00
Henrik Norlin
aa9a6be74d [IMP] removed type, parent_id, parent_path, child_ids from account.asset & account.asset.profile 2022-04-13 10:57:57 +02:00
Pedro M. Baeza
7ebeeff4a3 [FIX] account_asset_management: Don't depend on account.fiscal.year created records
* There's no need of forcing to create such records if your fiscal years are regular ones.
* FY date range computation duplicates code that is already on core.
* DummyFY is a good idea, but was not used at all. Now it is.
2022-04-13 10:57:57 +02:00
Luc De Meyer
8d2424e84a [FIX][12.0]asset_management - fix date string compare 2022-04-13 10:57:57 +02:00
Pedro M. Baeza
6e64ea2dea [FIX] account_asset_management: Provide hook _compute_depreciation_amount_per_fiscal_year
This way, other method_time mechanism like localization ones is able to overwrite it.

You also got an error of variable `number` not set due to previous code. Although no
alternate implementation for a new method_time, now you don't have any error,
fallbacking to standard proportional repartition.
2022-04-13 10:57:56 +02:00
Henrik
4fae2e0ae9 [12.0][FIX] account_asset_management: date_range -> account_fiscal_year, account_analytic_id without domain 2022-04-13 10:57:56 +02:00
Bejaoui Souheil
e7f2beb6fb Finish 12.0 migration of account_asset_management
* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year
2022-04-13 10:57:56 +02:00
Maxence Groine
8b8831980c Included PR #828 Fix computation of depreciation lines when having multiple assets in invoice 2022-04-13 10:57:56 +02:00
Henrik Norlin
b67fe0b79c [MIG] account_asset_management: Migration to 12.0 2022-04-13 10:57:56 +02:00
Akim Juillerat
93e4756698 [MIG] account_asset_management: Migration to 11.0 2022-04-13 10:57:56 +02:00
Luc De Meyer
8ad64ceb73 [FIX] account_asset_management: Test data + onchange 2022-04-13 10:57:56 +02:00
Akim Juillerat
e89dc8ed20 [FIX+IMP] account_asset_management: 2 things:
* Fix compute methods dependencies and small optimizations
* Rename demo file to test and move it into the right folder
2022-04-13 10:57:56 +02:00
Luc De Meyer
2fe06219b6 [10.0][MIG]account_asset_management suite refactoring + 10.0 port 2022-04-13 10:57:56 +02:00