Commit Graph

40 Commits

Author SHA1 Message Date
Luc De Meyer
b9cb2867bb [13.0][FIX]account_chart_update refactor tax update 2022-02-09 21:41:00 +01:00
Luc De Meyer
66f3db4adb [FIX] account_chart_update: ignore template fields that do not exist in real 2021-10-18 19:26:14 +02:00
Reyes4711
df635240be [14.0][MIG] account_chart_update: Migration to 14.0 2021-05-07 12:54:52 +02:00
Luc De Meyer
0b6546efd4 [13.0][FIX]account_chart_update inactive taxes false positives 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
2c2de5ce5d [IMP] account_chart_update: Search for real XML-IDs only
Previously, only a check on an existing XML-ID which is not coming from exportation
was done, but now we check that the XML-ID is the exact one. With this, we avoid
that the same record changed their XML-ID and thus, there's no more link between
them.
2021-03-08 16:17:38 +01:00
ps-tubtim
ecdcfb21c1 [13.0][FIX] account_chart_update: Remove @api.multi 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
0267982250 [FIX+IMP] account_chart_update: Add consistency method
With this, we prevent lock due to infinite loop if children taxes are matched, but
not the parent one and it's marked to be created.
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
7156b9cb14 [FIX+IMP] account_chart_update: Create taxes in batch
With this, we gain some performance, but also prevent an error if there are template
taxes that have children taxes, as Odoo standard method forces that in the same call
all of them are created simultaneously, or it will enter in an infinite loop.
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
a2a4301820 [FIX] account_chart_update: Clear caches before searching
If not, changes done in for example taxes are not reflected.
2021-03-08 16:17:38 +01:00
ernestotejeda
2bf3046a7c [MIG] account_chart_update: Migration to 13.0 2021-03-08 16:17:38 +01:00
ernestotejeda
63d5714a79 [IMP] account_chart_update: black, isort 2021-03-08 16:17:38 +01:00
ernesto
b6e2359d01 [MIG] account_chart_update: Migration to 12.0 2021-03-08 16:17:38 +01:00
ernesto
001f2e95ea account_chart_update: Fix number of updates and insertions in log 2021-03-08 16:17:38 +01:00
ernesto
434b80be66 account_chart_update: allows to set the matching value order
It allows to set the order of matching for Account, Taxes and
Fiscal position.
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
ea78ba2884 [IMP] account_chart_update: Include field selection
With this option, you can select which fields do you want to compare for updating.

Use case: you have specific accounts in taxes, and you don't want to lose them,
but you want to update their groups through the wizard. Before this, the update
was all or nothing. Now, you have total control!
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
c5a6eb2bf4 [FIX] account_chart_update: Handle updated m2m correctly 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
0f19f777a9 [MIG] account_chart_update: Additional needed changes 2021-03-08 16:17:38 +01:00
amcor
f9642d9e84 [MIG] account_chart_update: Migration to 11.0 2021-03-08 16:17:38 +01:00
Stéphane Bidoul (ACSONE)
53fa385d08 account_chart_update: copy inactive tax templates too
In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
a305c894f4 [FIX+IMP] account_chart_update: Major refactoring
* Compare all fields from template

  Not all fields were properly compared with previous code. This means also
  to exclude some of them, but now we have a full and extensible system.

* Optimize cached method
* Generate accounts and fiscal positions using Odoo methods (tax already did)
* README by fragments
* Add tests up to full coverage
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
492fc9dd20 [FIX] account_chart_update: Don't cache recordsets
When marking methods as ormcache, you can't return recordsets, as they keep
the cursor information, and that cursor can be closed (worker spawn for example)
when you need to access again data.

This is fixed returning IDs instead, and browsing when needed
2021-03-08 16:17:38 +01:00
moutio
42e9a0a584 [FIX] account_chart_update: Limit fiscal position search with same name (#651) 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
7dc18f67c6 [FIX] account_chart_update: Fetch account code digits correctly 2021-03-08 16:17:38 +01:00
Sylvain Van Hoof
7e0b0d1411 [MIG] account_chart_update: Migration to 10.0 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
87eec28f3a [FIX+IMP] account_chart_update: Fix fiscal position mapping + translations + clean authors
As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.
2021-03-08 16:17:38 +01:00
Jairo Llopis
58434748ae [MIG][9.0][account_chart_update] Migrate.
- New-style license headers.
- Remove .pot file.
- Remove tax codes stuff, now removed from v9.
- Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive.
- Only update fields that have any kind of change on any updated record.
- Place the wizard in the configuration page, instead of its own menu item.
- Display amount of disabled taxes at ending page.
2021-03-08 16:17:38 +01:00
Stéphane Bidoul
8db0ee95b5 [FIX] account_chart_update:
* Process price_include field
* Detect change in price_include field
2021-03-08 16:17:38 +01:00
PabloCM
04c00c11dd [FIX] Include acc templates from parent CoA templates 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
7fdb3ff8fe [FIX] account_chart_update: Don't write code on account update
As there's a constraint that forbids to write the code of the account
if it has moves, we delete the corresponding entry on update only,
because the method that prepares the values is the same for new and
existing accounts.
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
fddeb5f730 [FIX] account_chart_update: Call mapping function instead of removed cache. Closes #240 2021-03-08 16:17:38 +01:00
Antonio Espinosa
8961f0cdf5 [FIX+IMP] account_chart_update: Several things
* Set updated taxes as active
* Check parent_id field in '_is_different_tax' method
* PEP8
* Spanish translation
2021-03-08 16:17:38 +01:00
Pedro M. Baeza
24fac18c57 [IMP] account_chart_update: Whole refactoring
* Fix calculated field when showing inactives + add field to view
* Migrated to new API.
* Provided hooks for detecting changes and for adding update/create values.
* Purge dead error detection code (not applying).
* Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa.
* Number fields computed by a function field instead of being computed by hand.
* Use recordsets as indexes instead of ids to avoid repetitive browses.
* Re-enable local cache variables
* README + authors
2021-03-08 16:17:38 +01:00
Stéphane Bidoul
b9c7c74812 [FIX+IMP] account_chart_update: Several things
* search on code first to match tax codes

  The tax code code should be more discriminant that the tax code name.

* compare more fields in tax codes
* deletion of tax codes removed from templates

  For tax codes, it make sense to propose deletion, since tax codes
  are normally defined by the tax authority and the user does not
  customize them.

* update accounts on taxes even if an update of the account was not requested

  Useful when the chart of taxes changes but the chart of account
  need not be updated.

* depth-first search of tax codes

  This helps creating parents before children.

* compare more fields in taxes
* add active field on tax code

  Deactivate tax codes which are not in the template.

* deactivate taxes that are not in the template
* multi-company criteria for taxes
* avoid inserting duplicates in presence of inactive taxes or tax codes
2021-03-08 16:17:38 +01:00
Adrien Peiffer
78b56d23ca [MIG] account_chart_update: Migration to 8.0
* Move out of unported
* Set account_chart_update installable
* value_reference of ir.property is a char
* Use get_by_record method of ir.property
* number digits is returned before assignment in case of property exist but account not
* product_obj isn't used
2021-03-08 16:17:38 +01:00
Nicolas Bessi
35d775ccea Set all addons to uninstallable 2021-03-08 16:17:38 +01:00
Pedro M. Baeza
53c56a152e [FIX] account_chart_update: Selection of operations to do now is working.
[FIX] account_chart_update: Adapted to work with inherited account chart templates.
[FIX] account_chart_update: Remove required=True for chart_template_id on DB and put on screen to avoid error when removing chart templates.
[FIX] account_chart_update: Change method to compare taxes of fiscal positions to match with the one comparing taxes.
[FIX] account_chart_update: Change method to compare accounts of fiscal positions to match with the one comparing accounts.
[IMP] account_chart_update: Wizard now shows in tree view modification notes.
[IMP] account_chart_update: For new data to be created, it is marked on notes the reason for the creation (just for clarity).
[IMP] account_chart_update: Tabs for operations that are not going to be performed are hidden.
[IMP] account_chart_update: Some PEP8 here and there.
[IMP] account_chart_update: Enhance a little the mapping searches (there's more room to improve).
[IMP] account_chart_update: Now it takes into account name and description for mapping taxes.
2021-03-08 16:17:38 +01:00
Stéphane Bidoul
1c457b43e9 [IMP] attempt to match tax code on code if no match on name was found 2021-03-08 16:17:38 +01:00
Yann Papouin
f25a71b71c FIX: wrong dict passed in _update_accounts 2021-03-08 16:17:38 +01:00
Invitu
229b780aa8 [IMP] small improvement : calling reopen method in action_init + indentation 2021-03-08 16:17:38 +01:00
Joaquin Gutierrez
e097a93712 [MIG]: account_char_update: Migration to version 7.0
[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel.
[FIX]: Fix deletion method for some fields of objects.
[FIX]: Contributions have been written in the standard format of the community.
[FIX]: Changes in the form to work as a real wizard.
[FIX]: Remove 'init_xml' keys, because it's no longer needed in v7.
[FIX]: Rename 'demo_xml' key to the new standard 'demo'.
[FIX]: Change imports calls.
[FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py).
[FIX]: Update view definitions to version 7.0
[FIX]: Rename variables to OpenERP standard.
[FIX]: Increased compatibility with standard PEP8.
[IMP]:  User Invitu add the method call _reopen to keep open the wizard.
[MRG]: User Invitu add frech language.
2021-03-08 16:17:38 +01:00