Commit Graph

22 Commits

Author SHA1 Message Date
Pedro M. Baeza
51433806b3 [IMP] account_asset_management: Simplify code for opening related entries
We don't need the search having the one2many field and no need also for list
comprehension having mapped operator.
2024-05-28 12:50:12 +02:00
Pedro M. Baeza
eff83ba8b8 [FIX] account_asset_management: Avoid error
Steps to reproduce the problem:

* Go to assets view
* Group by profile
* Unfold a group and click on an asset
* Click on "Journal Entries" smart-button
* Go back to the asset list
* Click again on the same asset (or another).
* Click on "Journal Entries" smart-button

Current behavior:

Error saying "KeyError: 'profile_id'"

Expected behavior:

No error

The cause for this is that Odoo stores in the context the key `group_by` with the
value `profile_id` in the specified chain of steps. That context entry is used for
grouping records in the list, and system tries to group the journal entries also
by that field, which doesn't exists in the other model, and thus the error.

We avoided it copying the context to be passes and leaving out that entry.
2024-05-28 12:50:12 +02:00
ernestotejeda
3b0087f059 [MIG] account_asset_management: Migration to 13.0 2024-05-28 12:50:12 +02:00
ernestotejeda
1cf04b7db2 [IMP] account_asset_management: black, isort 2024-05-28 12:50:12 +02:00
Luc De Meyer
a997710035 [12.0][FIX]traceback when deviating FY 2024-05-28 12:50:12 +02:00
Iván Todorovich
92aae8bc62 [12.0][FIX][account_asset_management] local variable 'asset' referenced before assignment
tools/account_asset_management/models/account_asset.py", line 970, in _compute_entries
    % (asset.name, asset.code) or asset.name
UnboundLocalError: local variable 'asset' referenced before assignment
2024-05-28 12:50:12 +02:00
Joan Sisquella
eeb1c16a93 [ADD] allows setting a depreciation ending date 2024-05-28 12:50:12 +02:00
Saran
22282538ef [ADD] options 'use_leap_years' 2024-05-28 12:50:12 +02:00
Saran
6a63d99fd4 [12.0][IMP] account_asset_management 2024-05-28 12:50:12 +02:00
Pedro M. Baeza
bbcf1e1cf6 [MIG+FIX+IMP] account_asset_management: Rework migration scripts + make asset group m2m 2024-05-28 12:50:12 +02:00
Henrik Norlin
da264360e6 [IMP] removed type, parent_id, parent_path, child_ids from account.asset & account.asset.profile 2024-05-28 12:50:12 +02:00
Pedro M. Baeza
92c8f32440 [FIX] account_asset_management: Don't depend on account.fiscal.year created records
* There's no need of forcing to create such records if your fiscal years are regular ones.
* FY date range computation duplicates code that is already on core.
* DummyFY is a good idea, but was not used at all. Now it is.
2024-05-28 12:50:12 +02:00
Luc De Meyer
d147e9e3d6 [FIX][12.0]asset_management - fix date string compare 2024-05-28 12:50:12 +02:00
Pedro M. Baeza
08b0239cc2 [FIX] account_asset_management: Provide hook _compute_depreciation_amount_per_fiscal_year
This way, other method_time mechanism like localization ones is able to overwrite it.

You also got an error of variable `number` not set due to previous code. Although no
alternate implementation for a new method_time, now you don't have any error,
fallbacking to standard proportional repartition.
2024-05-28 12:50:12 +02:00
Henrik
2556371e9b [12.0][FIX] account_asset_management: date_range -> account_fiscal_year, account_analytic_id without domain 2024-02-13 13:44:45 +01:00
Bejaoui Souheil
ae6c15da04 Finish 12.0 migration of account_asset_management
* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year
2024-02-13 13:44:45 +01:00
Maxence Groine
984f683d59 Included PR #828 Fix computation of depreciation lines when having multiple assets in invoice 2024-02-13 13:44:45 +01:00
Henrik Norlin
e3d5115f01 [MIG] account_asset_management: Migration to 12.0 2024-02-13 13:44:45 +01:00
Akim Juillerat
d0ea4ac10a [MIG] account_asset_management: Migration to 11.0 2024-02-13 13:44:45 +01:00
Luc De Meyer
cf15cc7356 [FIX] account_asset_management: Test data + onchange 2024-02-13 13:44:45 +01:00
Akim Juillerat
7d112bf691 [FIX+IMP] account_asset_management: 2 things:
* Fix compute methods dependencies and small optimizations
* Rename demo file to test and move it into the right folder
2024-02-13 13:44:45 +01:00
Luc De Meyer
eaba3e4ed5 [10.0][MIG]account_asset_management suite refactoring + 10.0 port 2024-02-13 13:44:45 +01:00