Commit Graph

56 Commits

Author SHA1 Message Date
Pedro M. Baeza
466194ef34 [IMP] account_chart_update: Create account groups in batch
For improving performance.
2023-08-03 16:46:15 +02:00
Enric Tobella
6603b37466 [IMP] account_chart_update: Update account groups too 2023-08-03 16:45:28 +02:00
Lois Rilo
85b7b6d4e7 [FIX] account_chart_update: do not repartion in groups + do append False IDs
1) In tax groups repartition lines are not used, however when creating
tax groups from templates the default repartition lines are created.
If you run the chart update again, it will detect those "useless"
default repartition lines and mark them to removal, raising an
error when trying to do so as a minial of 2 repartition lines are
needed (on base and one tax).

2) When matching taxes, if not match, do not add `False` to the list.
2023-07-12 11:03:22 +02:00
OCA-git-bot
cfec0b0947 Merge PR #1552 into 15.0
Signed-off-by pedrobaeza
2023-01-13 07:29:57 +00:00
Jairo Llopis
f2f6485264 [FIX] account_chart_update: false positive detecting diff on Html fields
When executing the chart updater and selecting the "notes" field from fiscal positions, you were getting differences 100% of the time.

This was because [fiscal position's notes field is Html][1], while [the template field is Text][2].

@moduon MT-1912

[1]: 5ef647d5d4/addons/account/models/partner.py (L32)
[2]: 5ef647d5d4/addons/account/models/chart_template.py (L1470)
2023-01-11 10:48:22 +00:00
Jairo Llopis
ea6cd69dcf [FIX] account_chart_update: responsive views
Make its 2nd step usable.

@moduon MT-1923
2023-01-11 10:45:33 +00:00
Lois Rilo
171a989930 [IMP] account_chart_update: improve extensibility 2022-10-24 13:41:22 +02:00
Pedro M. Baeza
9930b8e3ae [FIX] account_chart_update: Incorrect call in find account method
Clear copy/paste error.
2022-08-03 18:37:28 +02:00
manu
a472d9947f [15.0][FIX] account_chart_update: do not browse rep_line in _update_taxes_pending_for_accounts 2022-06-02 11:40:37 +02:00
Fernando La Chica
cb32510413 Migration and some fixes:
* Ignore changes in mail thread fields
   * account.tax.template._generate_tax return dict of objects
     and wizard fails
   * Load generic coa localization module to improve the test
2022-04-12 16:41:26 +02:00
Lois Rilo
d552b7c713 [FIX] account_chart_update: do not match twice the same repartition line
When updating a tax with several repartition lines, the same existing
candidates were considered in all iteration which could lead the wizard
to match the same repartition line with different lines of the template
and not detecting any change to do.
2022-04-09 22:20:38 +02:00
Miquel Raïch
116c6f32ec [FIX] account_loan: post() -> action_post() 2022-04-09 22:20:38 +02:00
Miquel Raïch
b94506eb5f [FIX] account_chart_update: Warning -> UserError 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
48f56eda9b [FIX] account_chart_update: cash_basis_base_account_id no longer exists
This field disappears in this version.
2022-04-09 22:20:38 +02:00
Luc De Meyer
970c0212e3 [13.0][FIX]account_chart_update refactor tax update 2022-04-09 22:20:38 +02:00
Luc De Meyer
a0ed803a88 [FIX] account_chart_update: ignore template fields that do not exist in real 2022-04-09 22:20:38 +02:00
Reyes4711
cd240a0bf1 [14.0][MIG] account_chart_update: Migration to 14.0 2022-04-09 22:20:38 +02:00
Luc De Meyer
961005777f [13.0][FIX]account_chart_update inactive taxes false positives 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
b3c4aae11f [IMP] account_chart_update: Search for real XML-IDs only
Previously, only a check on an existing XML-ID which is not coming from exportation
was done, but now we check that the XML-ID is the exact one. With this, we avoid
that the same record changed their XML-ID and thus, there's no more link between
them.
2022-04-09 22:20:38 +02:00
ps-tubtim
a58e23be7c [13.0][FIX] account_chart_update: Remove @api.multi 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
9518b140df [FIX+IMP] account_chart_update: Add consistency method
With this, we prevent lock due to infinite loop if children taxes are matched, but
not the parent one and it's marked to be created.
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
44d7a1c3b2 [FIX+IMP] account_chart_update: Create taxes in batch
With this, we gain some performance, but also prevent an error if there are template
taxes that have children taxes, as Odoo standard method forces that in the same call
all of them are created simultaneously, or it will enter in an infinite loop.
2022-04-09 22:20:38 +02:00
OCA-git-bot
c45bec68f4 pre-commit update 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
3487d3bf02 [FIX] account_chart_update: Clear caches before searching
If not, changes done in for example taxes are not reflected.
2022-04-09 22:20:38 +02:00
ernestotejeda
7ca88693b5 [MIG] account_chart_update: Migration to 13.0 2022-04-09 22:20:38 +02:00
ernestotejeda
6e7662e7e4 [IMP] account_chart_update: black, isort 2022-04-09 22:20:38 +02:00
ernesto
2fa9693437 [MIG] account_chart_update: Migration to 12.0 2022-04-09 22:20:38 +02:00
ernesto
7b9ac0e92b account_chart_update: Fix number of updates and insertions in log 2022-04-09 22:20:38 +02:00
ernesto
3fbd586688 account_chart_update: allows to set the matching value order
It allows to set the order of matching for Account, Taxes and
Fiscal position.
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
12a6bd5ae1 [IMP] account_chart_update: Include field selection
With this option, you can select which fields do you want to compare for updating.

Use case: you have specific accounts in taxes, and you don't want to lose them,
but you want to update their groups through the wizard. Before this, the update
was all or nothing. Now, you have total control!
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
69113c3327 [FIX] account_chart_update: Handle updated m2m correctly 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
77149f257a [MIG] account_chart_update: Additional needed changes 2022-04-09 22:20:38 +02:00
amcor
3362140b15 [MIG] account_chart_update: Migration to 11.0 2022-04-09 22:20:38 +02:00
Stéphane Bidoul (ACSONE)
8f1146fb78 account_chart_update: copy inactive tax templates too
In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
15e360a0c0 [FIX+IMP] account_chart_update: Major refactoring
* Compare all fields from template

  Not all fields were properly compared with previous code. This means also
  to exclude some of them, but now we have a full and extensible system.

* Optimize cached method
* Generate accounts and fiscal positions using Odoo methods (tax already did)
* README by fragments
* Add tests up to full coverage
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
9ebfe20e56 [FIX] account_chart_update: Don't cache recordsets
When marking methods as ormcache, you can't return recordsets, as they keep
the cursor information, and that cursor can be closed (worker spawn for example)
when you need to access again data.

This is fixed returning IDs instead, and browsing when needed
2022-04-09 22:20:38 +02:00
moutio
a016612a9b [FIX] account_chart_update: Limit fiscal position search with same name (#651) 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
2652f2b583 [FIX] account_chart_update: Fetch account code digits correctly 2022-04-09 22:20:38 +02:00
Sylvain Van Hoof
4dab46bfc6 [MIG] account_chart_update: Migration to 10.0 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
dc9dd56a07 [FIX+IMP] account_chart_update: Fix fiscal position mapping + translations + clean authors
As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.
2022-04-09 22:20:38 +02:00
Jairo Llopis
b1b71a0931 [MIG][9.0][account_chart_update] Migrate.
- New-style license headers.
- Remove .pot file.
- Remove tax codes stuff, now removed from v9.
- Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive.
- Only update fields that have any kind of change on any updated record.
- Place the wizard in the configuration page, instead of its own menu item.
- Display amount of disabled taxes at ending page.
2022-04-09 22:20:38 +02:00
Stéphane Bidoul
8f3ca7bdce [FIX] account_chart_update:
* Process price_include field
* Detect change in price_include field
2022-04-09 22:20:38 +02:00
PabloCM
5713f567b7 [FIX] Include acc templates from parent CoA templates 2022-04-09 22:20:38 +02:00
Pedro M. Baeza
4ec95b4473 [FIX] account_chart_update: Don't write code on account update
As there's a constraint that forbids to write the code of the account
if it has moves, we delete the corresponding entry on update only,
because the method that prepares the values is the same for new and
existing accounts.
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
63339f1b62 [FIX] account_chart_update: Call mapping function instead of removed cache. Closes #240 2022-04-09 22:20:38 +02:00
Antonio Espinosa
a701f89d0b [FIX+IMP] account_chart_update: Several things
* Set updated taxes as active
* Check parent_id field in '_is_different_tax' method
* PEP8
* Spanish translation
2022-04-09 22:20:38 +02:00
Pedro M. Baeza
b7530f280c [IMP] account_chart_update: Whole refactoring
* Fix calculated field when showing inactives + add field to view
* Migrated to new API.
* Provided hooks for detecting changes and for adding update/create values.
* Purge dead error detection code (not applying).
* Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa.
* Number fields computed by a function field instead of being computed by hand.
* Use recordsets as indexes instead of ids to avoid repetitive browses.
* Re-enable local cache variables
* README + authors
2022-04-09 22:20:38 +02:00
Stéphane Bidoul
95916d029a [FIX+IMP] account_chart_update: Several things
* search on code first to match tax codes

  The tax code code should be more discriminant that the tax code name.

* compare more fields in tax codes
* deletion of tax codes removed from templates

  For tax codes, it make sense to propose deletion, since tax codes
  are normally defined by the tax authority and the user does not
  customize them.

* update accounts on taxes even if an update of the account was not requested

  Useful when the chart of taxes changes but the chart of account
  need not be updated.

* depth-first search of tax codes

  This helps creating parents before children.

* compare more fields in taxes
* add active field on tax code

  Deactivate tax codes which are not in the template.

* deactivate taxes that are not in the template
* multi-company criteria for taxes
* avoid inserting duplicates in presence of inactive taxes or tax codes
2022-04-09 22:20:38 +02:00
Adrien Peiffer
f34fb5625f [MIG] account_chart_update: Migration to 8.0
* Move out of unported
* Set account_chart_update installable
* value_reference of ir.property is a char
* Use get_by_record method of ir.property
* number digits is returned before assignment in case of property exist but account not
* product_obj isn't used
2022-04-09 22:20:38 +02:00
Nicolas Bessi
9594eec772 Set all addons to uninstallable 2022-04-09 22:20:38 +02:00