From f7d40f64ebd73dc32b6f4cdfa80c227ea349e20d Mon Sep 17 00:00:00 2001
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@camptocamp.com>
Date: Fri, 26 Oct 2012 10:08:53 +0200
Subject: [PATCH] [FIX] set state to done when no no lines are generated on
 selected policies (lp:c2c-addons/6.1  rev 89.1.28)

---
 account_credit_control/partner_view.xml | 2 +-
 account_credit_control/run.py           | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/account_credit_control/partner_view.xml b/account_credit_control/partner_view.xml
index 240706082..fec1d0b48 100644
--- a/account_credit_control/partner_view.xml
+++ b/account_credit_control/partner_view.xml
@@ -15,7 +15,7 @@
 
     <act_window
       id="act_partner_credit_relation_relation"
-      name="Credit lines"
+      name="Credit Lines"
       groups="account_credit_control.group_account_credit_control_manager,account_credit_control.group_account_credit_control_user"
       domain="[('partner_id', '=',  active_id)]"
       res_model="credit.control.line"
diff --git a/account_credit_control/run.py b/account_credit_control/run.py
index b96e6e2e5..abc96514f 100644
--- a/account_credit_control/run.py
+++ b/account_credit_control/run.py
@@ -111,6 +111,8 @@ class CreditControlRun(Model):
             try:
                 lines = policy._get_moves_line_to_process(run.date, context=context)
                 tmp_manual = policy._check_lines_policies(lines, context=context)
+                # FIXME why do not use only sets instead of converting them each
+                # time ?
                 lines = list(set(lines) - set(tmp_manual))
                 manually_managed_lines += tmp_manual
                 if not lines:
@@ -139,13 +141,14 @@ class CreditControlRun(Model):
                            context=context)
                 return False
             vals = {'report': u"Number of generated lines : %s \n" % (len(credit_line_ids),),
-                    'state': 'done',
                     'manual_ids': [(6, 0, manually_managed_lines)]}
+
             if errors:
                 vals['report'] += u"Following line generation errors appends:"
                 vals['report'] += u"----\n".join(errors)
-                vals['state'] = 'done'
+
             run.write(vals, context=context)
+        run.write({'state': 'done'}, context=context)
         # lines will correspond to line that where not treated
         return lines