audrius/account-financial-tools
1
0
Fork 0
mirror of https://github.com/OCA/account-financial-tools.git synced 2025-02-02 12:47:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] account_document_reversal: reversal from bank statement lines was not working correctly

Browse Source 
It was probably incorrectly migrated
This commit is contained in:
Jordi Ballester Alomar
2023-07-10 17:01:10 +02:00
parent 3c023cefec
commit e41e858ede
3 changed files with 13 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
account_document_reversal/models/account_payment.py
View File

@@ -26,12 +26,11 @@ class AccountPayment(models.Model):
def action_document_reversal(self, date=None, journal_id=None):
""" Reverse all moves related to this payment + set state to cancel """
# Check document readiness
valid_state = (
len(self.mapped("state")) == 1
and list(set(self.mapped("state")))[0] == "posted"
)
if not valid_state:
raise UserError(_("Only validated document can be cancelled (reversal)"))
for payment in self:
if payment.state not in ["sent", "posted"]:
raise UserError(
_("Only validated document can be cancelled (reversal)")
)
# Find moves to get reversed
move_lines = self.mapped("move_line_ids").filtered(
lambda x: x.journal_id == self.mapped("journal_id")[0]