diff --git a/base_vat_optional_vies/README.rst b/base_vat_optional_vies/README.rst new file mode 100644 index 000000000..5ca7ff050 --- /dev/null +++ b/base_vat_optional_vies/README.rst @@ -0,0 +1,110 @@ +=================================== +Optional validation of VAT via VIES +=================================== + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Faccount--financial--tools-lightgray.png?logo=github + :target: https://github.com/OCA/account-financial-tools/tree/12.0/base_vat_optional_vies + :alt: OCA/account-financial-tools +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-base_vat_optional_vies + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png + :target: https://runbot.odoo-community.org/runbot/92/12.0 + :alt: Try me on Runbot + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module extends base_vat module features allowing to know if VIES +validation was passed or not. + +Then you can use "VIES validation passed" field in order to show VAT ID with +or without country preffix in invoices, for instance. + +*NOTE*: Although VIES validation is set in your company, this validation +will not block VAT ID write (main difference to Odoo standard behavior) if this +VAT ID is valid in its country. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +In order to activate VIES validation, you must set this option in Settings: +Settings > Account > Verify VAT Numbers + +Usage +===== + +When VIES VAT Check is activated: + +* Odoo will try to validate VAT against VIES online service +* If passed, then "VIES validation passed" field will be True +* If not passed, then try to validate using country validation method +* If validated, then "VIES validation passed" field will be False +* If not validated, then a ValidationError will be shown to user + +When VIES VAT Check is not activated: + +* "VIES validation passed" field will be always False + +You must prefix VAT with country code (ISO 3166-1 alpha-2) and if you want to +bypass country validation you can use "EU" code + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* Tecnativa + +Contributors +~~~~~~~~~~~~ + +* Rafael Blasco +* Antonio Espinosa +* Sergio Teruel +* David Vidal +* Rodrigo Bonilla +* Alexandre Díaz + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/account-financial-tools `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/base_vat_optional_vies/__init__.py b/base_vat_optional_vies/__init__.py new file mode 100644 index 000000000..0650744f6 --- /dev/null +++ b/base_vat_optional_vies/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/base_vat_optional_vies/__manifest__.py b/base_vat_optional_vies/__manifest__.py new file mode 100644 index 000000000..02639915c --- /dev/null +++ b/base_vat_optional_vies/__manifest__.py @@ -0,0 +1,24 @@ +# Copyright 2015 Tecnativa - Antonio Espinosa +# Copyright 2016 Tecnativa - Sergio Teruel +# Copyright 2017 Tecnativa - David Vidal +# Copyright 2019 FactorLibre - Rodrigo Bonilla +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +{ + 'name': "Optional validation of VAT via VIES", + 'category': 'Accounting', + 'version': '12.0.1.0.0', + 'depends': [ + 'base_vat', + ], + 'external_dependencies': { + 'python': ['vatnumber'], + }, + 'data': [ + 'views/res_partner_view.xml', + ], + 'author': 'Tecnativa,' + 'Odoo Community Association (OCA)', + 'website': 'https://github.com/OCA/account-financial-tools', + 'license': 'AGPL-3', + 'installable': True, +} diff --git a/base_vat_optional_vies/i18n/.gitkeep b/base_vat_optional_vies/i18n/.gitkeep new file mode 100644 index 000000000..e69de29bb diff --git a/base_vat_optional_vies/i18n/base_vat_optional_vies.pot b/base_vat_optional_vies/i18n/base_vat_optional_vies.pot new file mode 100644 index 000000000..5a5a2cdb1 --- /dev/null +++ b/base_vat_optional_vies/i18n/base_vat_optional_vies.pot @@ -0,0 +1,26 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * base_vat_optional_vies +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 12.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: <>\n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: base_vat_optional_vies +#: model:ir.model,name:base_vat_optional_vies.model_res_partner +msgid "Contact" +msgstr "" + +#. module: base_vat_optional_vies +#: model:ir.model.fields,field_description:base_vat_optional_vies.field_res_partner__vies_passed +#: model:ir.model.fields,field_description:base_vat_optional_vies.field_res_users__vies_passed +msgid "VIES validation" +msgstr "" + diff --git a/base_vat_optional_vies/models/__init__.py b/base_vat_optional_vies/models/__init__.py new file mode 100644 index 000000000..91fed54d4 --- /dev/null +++ b/base_vat_optional_vies/models/__init__.py @@ -0,0 +1 @@ +from . import res_partner diff --git a/base_vat_optional_vies/models/res_partner.py b/base_vat_optional_vies/models/res_partner.py new file mode 100644 index 000000000..1cf0a3bc7 --- /dev/null +++ b/base_vat_optional_vies/models/res_partner.py @@ -0,0 +1,41 @@ +# Copyright 2015 Tecnativa - Antonio Espinosa +# Copyright 2017 Tecnativa - David Vidal +# Copyright 2019 FactorLibre - Rodrigo Bonilla +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +from odoo import api, fields, models + + +class ResPartner(models.Model): + _inherit = 'res.partner' + + vies_passed = fields.Boolean( + string="VIES validation", readonly=True) + + @api.model + def simple_vat_check(self, country_code, vat_number): + res = super(ResPartner, self).simple_vat_check( + country_code, vat_number, + ) + partner = self.env.context.get('vat_partner') + if partner and self.vies_passed: + # Can not be sure that this VAT is signed up in VIES + partner.update({'vies_passed': False}) + return res + + @api.model + def vies_vat_check(self, country_code, vat_number): + partner = self.env.context.get('vat_partner') + if partner: + # If there's an exception checking VIES, the upstream method will + # call simple_vat_check and thus the flag will be removed + partner.update({'vies_passed': True}) + res = super(ResPartner, self).vies_vat_check(country_code, vat_number) + if not res: + return self.simple_vat_check(country_code, vat_number) + return res + + @api.constrains('vat', 'commercial_partner.country_id') + def check_vat(self): + for partner in self: + partner = partner.with_context(vat_partner=partner) + super(ResPartner, partner).check_vat() diff --git a/base_vat_optional_vies/readme/CONFIGURE.rst b/base_vat_optional_vies/readme/CONFIGURE.rst new file mode 100644 index 000000000..416676fbf --- /dev/null +++ b/base_vat_optional_vies/readme/CONFIGURE.rst @@ -0,0 +1,2 @@ +In order to activate VIES validation, you must set this option in Settings: +Settings > Account > Verify VAT Numbers diff --git a/base_vat_optional_vies/readme/CONTRIBUTORS.rst b/base_vat_optional_vies/readme/CONTRIBUTORS.rst new file mode 100644 index 000000000..c6804a036 --- /dev/null +++ b/base_vat_optional_vies/readme/CONTRIBUTORS.rst @@ -0,0 +1,6 @@ +* Rafael Blasco +* Antonio Espinosa +* Sergio Teruel +* David Vidal +* Rodrigo Bonilla +* Alexandre Díaz diff --git a/base_vat_optional_vies/readme/DESCRIPTION.rst b/base_vat_optional_vies/readme/DESCRIPTION.rst new file mode 100644 index 000000000..c430079de --- /dev/null +++ b/base_vat_optional_vies/readme/DESCRIPTION.rst @@ -0,0 +1,9 @@ +This module extends base_vat module features allowing to know if VIES +validation was passed or not. + +Then you can use "VIES validation passed" field in order to show VAT ID with +or without country preffix in invoices, for instance. + +*NOTE*: Although VIES validation is set in your company, this validation +will not block VAT ID write (main difference to Odoo standard behavior) if this +VAT ID is valid in its country. diff --git a/base_vat_optional_vies/readme/USAGE.rst b/base_vat_optional_vies/readme/USAGE.rst new file mode 100644 index 000000000..ba8e2f7cb --- /dev/null +++ b/base_vat_optional_vies/readme/USAGE.rst @@ -0,0 +1,14 @@ +When VIES VAT Check is activated: + +* Odoo will try to validate VAT against VIES online service +* If passed, then "VIES validation passed" field will be True +* If not passed, then try to validate using country validation method +* If validated, then "VIES validation passed" field will be False +* If not validated, then a ValidationError will be shown to user + +When VIES VAT Check is not activated: + +* "VIES validation passed" field will be always False + +You must prefix VAT with country code (ISO 3166-1 alpha-2) and if you want to +bypass country validation you can use "EU" code diff --git a/base_vat_optional_vies/static/description/icon.png b/base_vat_optional_vies/static/description/icon.png new file mode 100644 index 000000000..3a0328b51 Binary files /dev/null and b/base_vat_optional_vies/static/description/icon.png differ diff --git a/base_vat_optional_vies/static/description/index.html b/base_vat_optional_vies/static/description/index.html new file mode 100644 index 000000000..16adba305 --- /dev/null +++ b/base_vat_optional_vies/static/description/index.html @@ -0,0 +1,454 @@ + + + + + + +Optional validation of VAT via VIES + + + +
+

Optional validation of VAT via VIES

+ + +

Beta License: AGPL-3 OCA/account-financial-tools Translate me on Weblate Try me on Runbot

+

This module extends base_vat module features allowing to know if VIES +validation was passed or not.

+

Then you can use “VIES validation passed” field in order to show VAT ID with +or without country preffix in invoices, for instance.

+

NOTE: Although VIES validation is set in your company, this validation +will not block VAT ID write (main difference to Odoo standard behavior) if this +VAT ID is valid in its country.

+

Table of contents

+ +
+

Configuration

+

In order to activate VIES validation, you must set this option in Settings: +Settings > Account > Verify VAT Numbers

+
+
+

Usage

+

When VIES VAT Check is activated:

+
    +
  • Odoo will try to validate VAT against VIES online service
    • +
  • If passed, then “VIES validation passed” field will be True
    • +
  • If not passed, then try to validate using country validation method
    • +
  • If validated, then “VIES validation passed” field will be False
    • +
  • If not validated, then a ValidationError will be shown to user
    • +
+

When VIES VAT Check is not activated:

+
    +
  • “VIES validation passed” field will be always False
    • +
+

You must prefix VAT with country code (ISO 3166-1 alpha-2) and if you want to +bypass country validation you can use “EU” code

+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Tecnativa
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/account-financial-tools project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/base_vat_optional_vies/tests/__init__.py b/base_vat_optional_vies/tests/__init__.py new file mode 100644 index 000000000..d57d215f9 --- /dev/null +++ b/base_vat_optional_vies/tests/__init__.py @@ -0,0 +1 @@ +from . import test_res_partner diff --git a/base_vat_optional_vies/tests/test_res_partner.py b/base_vat_optional_vies/tests/test_res_partner.py new file mode 100644 index 000000000..09430fafb --- /dev/null +++ b/base_vat_optional_vies/tests/test_res_partner.py @@ -0,0 +1,37 @@ +# Copyright 2015 Tecnativa - Antonio Espinosa +# Copyright 2016 Tecnativa - Sergio Teruel +# Copyright 2017 Tecnativa - David Vidal +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +import mock +from odoo.tests import common + + +class TestResPartner(common.TransactionCase): + def setUp(self): + super(TestResPartner, self).setUp() + self.company = self.env.user.company_id + self.company.vat_check_vies = True + self.partner = self.env['res.partner'].create({ + 'name': 'Test partner', + }) + self.vatnumber_path = ( + 'odoo.addons.base_vat.models.res_partner.vatnumber' + ) + + def test_validate_vat_vies(self): + with mock.patch(self.vatnumber_path) as mock_vatnumber: + mock_vatnumber.check_vies.return_value = True + self.partner.vat = 'ESB87530432' + self.assertEqual(self.partner.vies_passed, True) + + def test_exception_vat_vies(self): + with mock.patch(self.vatnumber_path) as mock_vatnumber: + mock_vatnumber.check_vies.side_effect = Exception() + self.partner.vat = 'ESB87530432' + self.assertEqual(self.partner.vies_passed, False) + + def test_no_validate_vat(self): + with mock.patch(self.vatnumber_path) as mock_vatnumber: + mock_vatnumber.check_vies.return_value = False + self.partner.vat = 'ESB87530432' + self.assertEqual(self.partner.vies_passed, False) diff --git a/base_vat_optional_vies/views/res_partner_view.xml b/base_vat_optional_vies/views/res_partner_view.xml new file mode 100644 index 000000000..e267ec791 --- /dev/null +++ b/base_vat_optional_vies/views/res_partner_view.xml @@ -0,0 +1,13 @@ + + + + Add VIES passed fields + res.partner + + + + + + + + diff --git a/setup/_metapackage/VERSION.txt b/setup/_metapackage/VERSION.txt index db81d9488..f02af6ed0 100644 --- a/setup/_metapackage/VERSION.txt +++ b/setup/_metapackage/VERSION.txt @@ -1 +1 @@ -12.0.20190718.0 \ No newline at end of file +12.0.20190719.0 \ No newline at end of file diff --git a/setup/_metapackage/setup.py b/setup/_metapackage/setup.py index aa404a5ec..03f6a1734 100644 --- a/setup/_metapackage/setup.py +++ b/setup/_metapackage/setup.py @@ -28,6 +28,7 @@ setuptools.setup( 'odoo12-addon-account_renumber', 'odoo12-addon-account_tag_menu', 'odoo12-addon-account_type_menu', + 'odoo12-addon-base_vat_optional_vies', ], classifiers=[ 'Programming Language :: Python', diff --git a/setup/base_vat_optional_vies/odoo/addons/base_vat_optional_vies b/setup/base_vat_optional_vies/odoo/addons/base_vat_optional_vies new file mode 120000 index 000000000..bfd41bde2 --- /dev/null +++ b/setup/base_vat_optional_vies/odoo/addons/base_vat_optional_vies @@ -0,0 +1 @@ +../../../../base_vat_optional_vies \ No newline at end of file diff --git a/setup/base_vat_optional_vies/setup.py b/setup/base_vat_optional_vies/setup.py new file mode 100644 index 000000000..28c57bb64 --- /dev/null +++ b/setup/base_vat_optional_vies/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +)