From af8de1b846580d40f3f261a94e95ee2a224eca85 Mon Sep 17 00:00:00 2001
From: Alexis de Lattre <alexis.delattre@akretion.com>
Date: Fri, 13 Nov 2020 17:41:13 +0100
Subject: [PATCH] [MIG] account_menu from v13 to v14

---
 account_menu/__manifest__.py                  |  4 ++--
 account_menu/models/account_group.py          |  1 -
 account_menu/models/account_tag.py            |  7 ------
 account_menu/models/account_tax_group.py      |  1 -
 account_menu/readme/CONTRIBUTORS.rst          |  1 +
 account_menu/readme/DESCRIPTION.rst           | 11 +++++++---
 account_menu/views/menu.xml                   |  3 ++-
 .../views/view_account_account_template.xml   |  9 +++++++-
 .../view_account_fiscal_position_template.xml | 13 +++++------
 account_menu/views/view_account_group.xml     |  9 +++++++-
 account_menu/views/view_account_tag.xml       | 22 ++++++++-----------
 account_menu/views/view_account_tax_group.xml |  5 ++---
 12 files changed, 46 insertions(+), 40 deletions(-)

diff --git a/account_menu/__manifest__.py b/account_menu/__manifest__.py
index 98cdd53f3..430a519f8 100644
--- a/account_menu/__manifest__.py
+++ b/account_menu/__manifest__.py
@@ -4,11 +4,11 @@
 
 {
     "name": "Account - Missing Menus",
-    "version": "13.0.1.0.0",
+    "version": "14.0.1.0.0",
     "category": "Accounting",
     "license": "AGPL-3",
     "summary": "Adds missing menu entries for Account module",
-    "author": "GRAP, Odoo Community Association (OCA)",
+    "author": "GRAP, Akretion, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-financial-tools",
     "depends": ["account"],
     "data": [
diff --git a/account_menu/models/account_group.py b/account_menu/models/account_group.py
index 3d8bf3462..214462450 100644
--- a/account_menu/models/account_group.py
+++ b/account_menu/models/account_group.py
@@ -11,5 +11,4 @@ class AccountGroup(models.Model):
         comodel_name="account.account",
         inverse_name="group_id",
         string="Accounts",
-        help="Assigned accounts.",
     )
diff --git a/account_menu/models/account_tag.py b/account_menu/models/account_tag.py
index 2d5032aab..86d7878d6 100644
--- a/account_menu/models/account_tag.py
+++ b/account_menu/models/account_tag.py
@@ -11,11 +11,4 @@ class AccountAccountTag(models.Model):
         comodel_name="account.account",
         relation="account_account_account_tag",
         string="Accounts",
-        help="Assigned accounts for custom reporting",
-    )
-    tax_ids = fields.Many2many(
-        comodel_name="account.tax",
-        relation="account_tax_account_tag",
-        string="Taxes",
-        help="Assigned taxes for custom reporting",
     )
diff --git a/account_menu/models/account_tax_group.py b/account_menu/models/account_tax_group.py
index 3313e3af8..fa9f58077 100644
--- a/account_menu/models/account_tax_group.py
+++ b/account_menu/models/account_tax_group.py
@@ -11,5 +11,4 @@ class AccountTaxGroup(models.Model):
         comodel_name="account.tax",
         inverse_name="tax_group_id",
         string="Taxes",
-        help="Assigned taxes.",
     )
diff --git a/account_menu/readme/CONTRIBUTORS.rst b/account_menu/readme/CONTRIBUTORS.rst
index 9d38778af..c299dcdb2 100644
--- a/account_menu/readme/CONTRIBUTORS.rst
+++ b/account_menu/readme/CONTRIBUTORS.rst
@@ -1,2 +1,3 @@
 * Sylvain LE GAL <https://twitter.com/legalsylvain>
 * Raf Ven <raf.ven@dynapps.be>
+* Alexis de Lattre <alexis.delattre@akretion.com>
diff --git a/account_menu/readme/DESCRIPTION.rst b/account_menu/readme/DESCRIPTION.rst
index 3f1beb67e..788f4db51 100644
--- a/account_menu/readme/DESCRIPTION.rst
+++ b/account_menu/readme/DESCRIPTION.rst
@@ -1,7 +1,12 @@
-This module adds all missing menu entries for **Account** module.
+This module adds all missing menu entries for the **Account** module.
 
-* Chart of Account Templates
 * Account Types
 * Account Tags
-* Account Group
+* Account Groups
+* Account Tax Groups
 * Bank Statements
+* Cash Registers
+* Chart of Account Templates
+* Account Templates
+* Tax Templates
+* Fiscal Position Templates
diff --git a/account_menu/views/menu.xml b/account_menu/views/menu.xml
index e6ed25d93..b5055d400 100644
--- a/account_menu/views/menu.xml
+++ b/account_menu/views/menu.xml
@@ -13,8 +13,9 @@ License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
     />
     <menuitem
         id="menu_account_coa_settings"
-        sequence="50"
+        sequence="200"
         name="Templates"
         parent="account.menu_finance_configuration"
+        groups="base.group_no_one"
     />
 </odoo>
diff --git a/account_menu/views/view_account_account_template.xml b/account_menu/views/view_account_account_template.xml
index f4da77569..afea9d453 100644
--- a/account_menu/views/view_account_account_template.xml
+++ b/account_menu/views/view_account_account_template.xml
@@ -5,9 +5,16 @@ Copyright (C) 2019 - Today: GRAP (http://www.grap.coop)
 License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 -->
 <odoo>
+
+    <record id="account_account_template_action" model="ir.actions.act_window">
+        <field name="name">Account Templates</field>
+        <field name="res_model">account.account.template</field>
+        <field name="view_mode">tree,form</field>
+    </record>
+
     <menuitem
         id="menu_account_account_template"
-        action="account.action_account_template_form"
+        action="account_account_template_action"
         parent="menu_account_coa_settings"
         sequence="20"
     />
diff --git a/account_menu/views/view_account_fiscal_position_template.xml b/account_menu/views/view_account_fiscal_position_template.xml
index f7c40a3cd..0fb859bcc 100644
--- a/account_menu/views/view_account_fiscal_position_template.xml
+++ b/account_menu/views/view_account_fiscal_position_template.xml
@@ -5,16 +5,15 @@ Copyright (C) 2019 - Today: GRAP (http://www.grap.coop)
 License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 -->
 <odoo>
-    <!-- Renaming this action because this default name is not the correct one -->
-    <record
-        id="account.action_account_fiscal_position_template_form"
-        model="ir.actions.act_window"
-    >
-        <field name="name">Fiscal Position Templates</field>
+    <record id="account_fiscal_position_template_action" model="ir.actions.act_window">
+            <field name="name">Fiscal Position Templates</field>
+            <field name="res_model">account.fiscal.position.template</field>
+            <field name="view_mode">tree,form</field>
     </record>
+
     <menuitem
         id="menu_account_fiscal_position_template"
-        action="account.action_account_fiscal_position_template_form"
+        action="account_fiscal_position_template_action"
         parent="menu_account_coa_settings"
         sequence="40"
     />
diff --git a/account_menu/views/view_account_group.xml b/account_menu/views/view_account_group.xml
index baccc0920..54c79568e 100644
--- a/account_menu/views/view_account_group.xml
+++ b/account_menu/views/view_account_group.xml
@@ -20,9 +20,16 @@
             </xpath>
         </field>
     </record>
+
+    <record id="account_group_action" model="ir.actions.act_window">
+        <field name="name">Account Groups</field>
+        <field name="res_model">account.group</field>
+        <field name="view_mode">tree,form</field>
+    </record>
+
     <menuitem
         id="account_group_menu"
-        action="account.action_account_group_tree"
+        action="account_group_action"
         sequence="50"
         parent="account.account_account_menu"
     />
diff --git a/account_menu/views/view_account_tag.xml b/account_menu/views/view_account_tag.xml
index 409248603..120e9c0b0 100644
--- a/account_menu/views/view_account_tag.xml
+++ b/account_menu/views/view_account_tag.xml
@@ -7,7 +7,7 @@
         <field name="arch" type="xml">
             <xpath expr="//group" position="after">
                 <group>
-                    <group id="aplicability">
+                    <group id="applicability">
                         <field name="applicability" widget="selection" />
                     </group>
                 </group>
@@ -24,25 +24,21 @@
                             attrs="{'invisible':[('applicability','!=', 'accounts')]}"
                             options="{'no_create_edit': True}"
                         />
-                        <label
-                            for="tax_ids"
-                            attrs="{'invisible':[('applicability','!=', 'taxes')]}"
-                        />
-                        <field
-                            name="tax_ids"
-                            widget="many2many_tags"
-                            nolabel="1"
-                            attrs="{'invisible':[('applicability','!=', 'taxes')]}"
-                            options="{'no_create_edit': True}"
-                        />
                     </group>
                 </group>
             </xpath>
         </field>
     </record>
+
+    <record id="account_account_tag_action" model="ir.actions.act_window">
+        <field name="name">Account Tags</field>
+        <field name="res_model">account.account.tag</field>
+        <field name="view_mode">tree,form</field>
+    </record>
+
     <menuitem
         id="account_tag_menu"
-        action="account.account_tag_action"
+        action="account_account_tag_action"
         sequence="40"
         parent="account.account_account_menu"
     />
diff --git a/account_menu/views/view_account_tax_group.xml b/account_menu/views/view_account_tax_group.xml
index e8ed88ae4..2bef40ffd 100644
--- a/account_menu/views/view_account_tax_group.xml
+++ b/account_menu/views/view_account_tax_group.xml
@@ -54,15 +54,14 @@
             </tree>
         </field>
     </record>
-    <record id="action_account_tax_group_tree" model="ir.actions.act_window">
+    <record id="action_account_tax_group" model="ir.actions.act_window">
         <field name="name">Account Tax Groups</field>
         <field name="res_model">account.tax.group</field>
         <field name="view_mode">tree,form</field>
-        <field name="search_view_id" ref="view_account_tax_group_search" />
     </record>
     <menuitem
         id="account_tax_group_menu"
-        action="action_account_tax_group_tree"
+        action="action_account_tax_group"
         sequence="51"
         parent="account.account_account_menu"
     />