From ad44b408071cceebea68da81398bf57856f156c1 Mon Sep 17 00:00:00 2001
From: cubells <vicent@vcubells.net>
Date: Wed, 20 Sep 2017 12:44:24 +0200
Subject: [PATCH] [FIX] account_credit_control: groups in view instead of
 fields (#537)

This way, fields are not read if you don't belong to the group and you don't see a permission error.
---
 account_credit_control/__openerp__.py            |  2 +-
 account_credit_control/views/account_invoice.xml | 11 ++++-------
 account_credit_control/views/res_partner.xml     |  4 ++--
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/account_credit_control/__openerp__.py b/account_credit_control/__openerp__.py
index dec7c6713..d6de5efc2 100644
--- a/account_credit_control/__openerp__.py
+++ b/account_credit_control/__openerp__.py
@@ -5,7 +5,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     'name': 'Account Credit Control',
-    'version': '9.0.1.0.0',
+    'version': '9.0.1.0.1',
     'author': "Camptocamp, "
               "Tecnativa, "
               "Odoo Community Association (OCA)",
diff --git a/account_credit_control/views/account_invoice.xml b/account_credit_control/views/account_invoice.xml
index 5fede04d6..92212cb9b 100644
--- a/account_credit_control/views/account_invoice.xml
+++ b/account_credit_control/views/account_invoice.xml
@@ -13,20 +13,17 @@
         <field name="name">invoice.followup.form.view</field>
         <field name="model">account.invoice</field>
         <field name="inherit_id" ref="account.invoice_form"/>
+        <field name="groups_id" eval="[(4, ref('account_credit_control.group_account_credit_control_manager')), (4, ref('account_credit_control.group_account_credit_control_user')), (4, ref('account_credit_control.group_account_credit_control_info'))]"/>
         <field name="arch" type="xml">
             <notebook position="inside">
-                <page string="Credit Control"
-                      groups="account_credit_control.group_account_credit_control_manager,account_credit_control.group_account_credit_control_user,account_credit_control.group_account_credit_control_info">
+                <page string="Credit Control">
                     <group>
                         <field name="credit_policy_id"
                                string="Manual Credit Control Policy"
-                               attrs="{'invisible': [('credit_policy_id', '=', False)]}"
-                               groups="account_credit_control.group_account_credit_control_manager,account_credit_control.group_account_credit_control_user,account_credit_control.group_account_credit_control_info"/>
+                               attrs="{'invisible': [('credit_policy_id', '=', False)]}"/>
                     </group>
                     <separator string="Issued Lines" colspan="4"/>
-                    <field name="credit_control_line_ids" colspan="4"
-                           nolabel="1"
-                           groups="account_credit_control.group_account_credit_control_manager,account_credit_control.group_account_credit_control_user,account_credit_control.group_account_credit_control_info">
+                    <field name="credit_control_line_ids" colspan="4" nolabel="1">
                         <tree string="Credit Control Lines">
                             <field name="date"/>
                             <field name="level"/>
diff --git a/account_credit_control/views/res_partner.xml b/account_credit_control/views/res_partner.xml
index ddfe35f30..7b4ccbd90 100644
--- a/account_credit_control/views/res_partner.xml
+++ b/account_credit_control/views/res_partner.xml
@@ -5,10 +5,10 @@
         <field name="name">partner.credit_control.form.view</field>
         <field name="model">res.partner</field>
         <field name="inherit_id" ref="account.view_partner_property_form"/>
+        <field name="groups_id" eval="[(4, ref('account_credit_control.group_account_credit_control_manager')), (4, ref('account_credit_control.group_account_credit_control_user'))]"/>
         <field name="arch" type="xml">
             <field name="credit" position="after">
-                <field name="credit_policy_id" widget="selection"
-                       groups="account_credit_control.group_account_credit_control_manager,account_credit_control.group_account_credit_control_user"/>
+                <field name="credit_policy_id" widget="selection"/>
             </field>
         </field>
     </record>