From 20e9113568586f161bb5482ef14fb1fae6abdfe2 Mon Sep 17 00:00:00 2001 From: Guewen Baconnier Date: Wed, 29 Oct 2014 16:03:38 +0100 Subject: [PATCH] Recordset is not a set, need to use |= instead of += to have unique ids --- account_credit_control/policy.py | 2 +- account_credit_control/run.py | 4 ++-- account_credit_control/wizard/credit_control_communication.py | 2 +- .../wizard/credit_control_policy_changer.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/account_credit_control/policy.py b/account_credit_control/policy.py index 4119740ee..dae28cbb1 100644 --- a/account_credit_control/policy.py +++ b/account_credit_control/policy.py @@ -402,5 +402,5 @@ class CreditControlPolicyLevel(models.Model): method = self._get_first_level_move_lines else: method = self._get_other_level_move_lines - matching_lines += method(controlling_date, lines) + matching_lines |= method(controlling_date, lines) return matching_lines diff --git a/account_credit_control/run.py b/account_credit_control/run.py index 2b11788a6..780057581 100644 --- a/account_credit_control/run.py +++ b/account_credit_control/run.py @@ -108,7 +108,7 @@ class CreditControlRun(models.Model): lines = policy._get_move_lines_to_process(self.date) manual_lines = policy._lines_different_policy(lines) lines -= manual_lines - manually_managed_lines += manual_lines + manually_managed_lines |= manual_lines policy_lines_generated = cr_line_obj.browse() if lines: # policy levels are sorted by level @@ -119,7 +119,7 @@ class CreditControlRun(models.Model): policy_lines_generated += create(level_lines, level, self.date) - generated += policy_lines_generated + generated |= policy_lines_generated if policy_lines_generated: report += (_("Policy \"%s\" has generated %d Credit " "Control Lines.\n") % diff --git a/account_credit_control/wizard/credit_control_communication.py b/account_credit_control/wizard/credit_control_communication.py index 4ed345572..4ebbf31db 100644 --- a/account_credit_control/wizard/credit_control_communication.py +++ b/account_credit_control/wizard/credit_control_communication.py @@ -207,7 +207,7 @@ class CreditCommunication(models.TransientModel): line_obj = self.env['credit.control.line'] lines = line_obj.browse() for comm in self: - lines += comm.credit_control_line_ids + lines |= comm.credit_control_line_ids lines.write({'state': 'sent'}) return lines diff --git a/account_credit_control/wizard/credit_control_policy_changer.py b/account_credit_control/wizard/credit_control_policy_changer.py index 61bf0a340..6829d7aff 100644 --- a/account_credit_control/wizard/credit_control_policy_changer.py +++ b/account_credit_control/wizard/credit_control_policy_changer.py @@ -64,7 +64,7 @@ class credit_control_policy_changer(models.TransientModel): ('move_id', '=', invoice.move_id.id), ('reconcile_id', '=', False)] move_lines = move_line_obj.search(domain) - selected_lines += move_lines + selected_lines |= move_lines return selected_lines move_line_ids = fields.Many2many('account.move.line',