From 0d22f0a6cc48d79a253a1f7b99065f6e77f7aac4 Mon Sep 17 00:00:00 2001 From: remi-filament <30716308+remi-filament@users.noreply.github.com> Date: Wed, 15 Mar 2023 11:45:31 +0100 Subject: [PATCH] [FIX] account_move_name_sequence: computed fields raising warning --- account_move_name_sequence/__manifest__.py | 2 +- .../i18n/account_move_name_sequence.pot | 12 ++++++++++ account_move_name_sequence/i18n/hr.po | 23 +++++++++++++++---- .../models/account_journal.py | 3 +++ .../models/account_move.py | 5 +++- 5 files changed, 38 insertions(+), 7 deletions(-) diff --git a/account_move_name_sequence/__manifest__.py b/account_move_name_sequence/__manifest__.py index b9b695b92..e6914cdef 100644 --- a/account_move_name_sequence/__manifest__.py +++ b/account_move_name_sequence/__manifest__.py @@ -7,7 +7,7 @@ { "name": "Account Move Number Sequence", - "version": "16.0.1.1.2", + "version": "16.0.1.1.3", "category": "Accounting", "license": "AGPL-3", "summary": "Generate journal entry number from sequence", diff --git a/account_move_name_sequence/i18n/account_move_name_sequence.pot b/account_move_name_sequence/i18n/account_move_name_sequence.pot index 4b400c5d1..0fbe285c5 100644 --- a/account_move_name_sequence/i18n/account_move_name_sequence.pot +++ b/account_move_name_sequence/i18n/account_move_name_sequence.pot @@ -42,6 +42,11 @@ msgstr "" msgid "Entry Sequence" msgstr "" +#. module: account_move_name_sequence +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_journal__has_sequence_holes +msgid "Has Sequence Holes" +msgstr "" + #. module: account_move_name_sequence #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__highest_name #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__highest_name @@ -59,6 +64,13 @@ msgstr "" msgid "Journal Entry" msgstr "" +#. module: account_move_name_sequence +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__made_sequence_hole +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__made_sequence_hole +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_payment__made_sequence_hole +msgid "Made Sequence Hole" +msgstr "" + #. module: account_move_name_sequence #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__name #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__name diff --git a/account_move_name_sequence/i18n/hr.po b/account_move_name_sequence/i18n/hr.po index 71e8a203c..06e5c7d93 100644 --- a/account_move_name_sequence/i18n/hr.po +++ b/account_move_name_sequence/i18n/hr.po @@ -29,8 +29,8 @@ msgstr "" #. module: account_move_name_sequence #: model:ir.model.fields,help:account_move_name_sequence.field_account_journal__refund_sequence msgid "" -"Check this box if you don't want to share the same sequence for invoices and" -" credit notes made from this journal" +"Check this box if you don't want to share the same sequence for invoices and " +"credit notes made from this journal" msgstr "" "Označite ovu kućicu ako ne želite dijeliti istu sekvencu za račune i " "odobrenja/storna napravljena iz ovog dnevnika" @@ -50,6 +50,11 @@ msgstr "Dedicirana sekvenca za odobrenja" msgid "Entry Sequence" msgstr "Ulazna sekvenca" +#. module: account_move_name_sequence +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_journal__has_sequence_holes +msgid "Has Sequence Holes" +msgstr "" + #. module: account_move_name_sequence #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__highest_name #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__highest_name @@ -67,6 +72,13 @@ msgstr "Dnevnik" msgid "Journal Entry" msgstr "Stavka dnevnika" +#. module: account_move_name_sequence +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__made_sequence_hole +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__made_sequence_hole +#: model:ir.model.fields,field_description:account_move_name_sequence.field_account_payment__made_sequence_hole +msgid "Made Sequence Hole" +msgstr "" + #. module: account_move_name_sequence #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_bank_statement_line__name #: model:ir.model.fields,field_description:account_move_name_sequence.field_account_move__name @@ -79,8 +91,8 @@ msgstr "Broj" #: code:addons/account_move_name_sequence/models/account_journal.py:0 #, python-format msgid "" -"On journal '%s', the same sequence is used as Entry Sequence and Credit Note" -" Entry Sequence." +"On journal '%s', the same sequence is used as Entry Sequence and Credit Note " +"Entry Sequence." msgstr "" "Na dnevniku '%s', ista sekvenca se koristi za regularna i storno knjiženja." @@ -146,4 +158,5 @@ msgstr "" #. module: account_move_name_sequence #: model:ir.model.fields,help:account_move_name_sequence.field_account_journal__sequence_id msgid "This sequence will be used to generate the journal entry number." -msgstr "Ova sekvenca će biti korištena za generiranje broja knjiženja dnevnika." +msgstr "" +"Ova sekvenca će biti korištena za generiranje broja knjiženja dnevnika." diff --git a/account_move_name_sequence/models/account_journal.py b/account_move_name_sequence/models/account_journal.py index 3531cb80f..24c24198f 100644 --- a/account_move_name_sequence/models/account_journal.py +++ b/account_move_name_sequence/models/account_journal.py @@ -34,6 +34,9 @@ class AccountJournal(models.Model): ) # Redefine the default to True as <=v13.0 refund_sequence = fields.Boolean(default=True) + # has_sequence_holes is not relevant anymore (since based on sequence_prefix/number) + # -> compute=False to improve perf and to avoid displaying warning + has_sequence_holes = fields.Boolean(compute=False) @api.constrains("refund_sequence_id", "sequence_id") def _check_journal_sequence(self): diff --git a/account_move_name_sequence/models/account_move.py b/account_move_name_sequence/models/account_move.py index f7338dcf1..2027e996f 100644 --- a/account_move_name_sequence/models/account_move.py +++ b/account_move_name_sequence/models/account_move.py @@ -9,11 +9,14 @@ class AccountMove(models.Model): _inherit = "account.move" name = fields.Char(compute="_compute_name_by_sequence") - # highest_name, sequence_prefix and sequence_number are not needed any more + # highest_name, sequence_prefix, sequence_number are not needed any more # -> compute=False to improve perf highest_name = fields.Char(compute=False) sequence_prefix = fields.Char(compute=False) sequence_number = fields.Integer(compute=False) + # made_sequence_hole is not relevant anymore (since based on sequence_prefix/number) + # -> compute=False to improve perf and to avoid displaying warning + made_sequence_hole = fields.Boolean(compute=False) _sql_constraints = [ (